Skip to content

Conversation

@Fonta1n3
Copy link
Contributor

@Fonta1n3 Fonta1n3 commented Nov 7, 2021

This PR:

  • detects when the machine is going to sleep and resigns Tor if it does
  • this ought to fix a crash which could happen after the computer wakes up

@shannona
Copy link
Contributor

shannona commented Nov 17, 2021

Tested out on my M1 Pro MacBook (2021) running Monterey (12.0). Seems fine. Started and stopped mainnet and testnet and tor. Refreshed hidden services. Verified signatures. Linked via QuickConnect to Gordian Wallet and Fully Noded.

Put it to sleep and awakened it. Closed laptop, waited for it to lose connection, and opened. Both seemed to recover correctly.

Some bugs remains, particularly #162 (occasionally, but I hit it on my first test of the DMG) and #163 (whenever there are two networks), but since those are extant I wouldn't suggest getting in the way of the new release.

Test out most of the menu items. Bitcore Core Config doesn't seem to do anything, otherwise fine.

Glanced through the code, and this changes are minimal, so I would suggest a quick, easy release of this.

As noted above, I also merged back some informational updates: marking this as 1.0.1 and updating the copyright to say Blockchain Commons and 2021.

@shannona
Copy link
Contributor

The Config file problem seem consistent, but only on my M1 Pro testbed, not my old Intel testbed. Filed as #170.

@shannona
Copy link
Contributor

Did the same tests on my intel Mac Mini (2018) running Monterey (12.0.1). Everything worked including, as alluded to the bug I'd hit with the config file only on my M1 (#170).

Would suggest releasing.

@shannona
Copy link
Contributor

Per @ChristopherA, merging

@shannona shannona merged commit be1c7f0 into BlockchainCommons:master Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants