RPC Authentication #182
Merged
RPC Authentication #182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…inary. Bitcoin Core v25 is now default. Fixes the kill all disclaimer, no wallets are deleted. Fixes bitcoin version from duplicating in the UI.
Contributor
Author
|
9d152f7 fixes an annoying bug that currently pops up if running v25.0, it will constantly ask you to downgrade to Bitcoin Core v24.2. |
Contributor
|
Thanks! I'm putting it on our TODO to test and release, but We're closing out the year right now, so it'll likely be January. |
This removes all python related code and build settings while maintaining rpcauth functionality.
Contributor
Author
|
Hey @shannona and @ChristopherA , I just removed python completely and am generating the rpc creds with native swift code, I think this PR is now mergable? |
Contributor
|
Thanks @Fonta1n3! We've got limited resources, but we've now got this on our TODO, and I'm hoping to be able to test & rerelease with your patches next week. |
Contributor
|
merging this into dev for testing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
arm64andx86_64binaries for Bitcoin Core.VERSIONenvironment variable was being set incorrectly. Which may have caused a bug.currentVersionvariable correctly for Bitcoin Core v25.0.0.