-
Notifications
You must be signed in to change notification settings - Fork 18
DesktopStreamer: use full user name as default stream name #141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| /* Copyright (c) 2016, EPFL/Blue Brain Project | ||
| * Raphael Dumusc <raphael.dumusc@epfl.ch> | ||
| * | ||
| * This file is part of Deflect <https://github.com/BlueBrain/Deflect> | ||
| * | ||
| * This library is free software; you can redistribute it and/or modify it under | ||
| * the terms of the GNU Lesser General Public License version 3.0 as published | ||
| * by the Free Software Foundation. | ||
| * | ||
| * This library is distributed in the hope that it will be useful, but WITHOUT | ||
| * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS | ||
| * FOR A PARTICULAR PURPOSE. See the GNU Lesser General Public License for more | ||
| * details. | ||
| * | ||
| * You should have received a copy of the GNU Lesser General Public License | ||
| * along with this library; if not, write to the Free Software Foundation, Inc., | ||
| * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. | ||
| */ | ||
|
|
||
| #include "nameUtils.h" | ||
|
|
||
| #ifndef _WIN32 | ||
| #include <pwd.h> | ||
| #endif | ||
|
|
||
| namespace nameutils | ||
| { | ||
|
|
||
| QString getFullUsername() | ||
| { | ||
| #ifdef _WIN32 | ||
| return qgetenv( "USERNAME" ); | ||
| #else | ||
| const auto username = qgetenv( "USER" ); | ||
| if( username.isEmpty( )) | ||
| return {}; | ||
|
|
||
| if( auto userinfo = getpwnam( username.constData( ))) | ||
| { | ||
| const auto fullname = QString{ userinfo->pw_gecos }; | ||
| if( !fullname.isEmpty( )) | ||
| return fullname; | ||
| } | ||
| return username; | ||
| #endif | ||
| } | ||
|
|
||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| /* Copyright (c) 2016, EPFL/Blue Brain Project | ||
| * Raphael Dumusc <raphael.dumusc@epfl.ch> | ||
| * | ||
| * This file is part of Deflect <https://github.com/BlueBrain/Deflect> | ||
| * | ||
| * This library is free software; you can redistribute it and/or modify it under | ||
| * the terms of the GNU Lesser General Public License version 3.0 as published | ||
| * by the Free Software Foundation. | ||
| * | ||
| * This library is distributed in the hope that it will be useful, but WITHOUT | ||
| * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS | ||
| * FOR A PARTICULAR PURPOSE. See the GNU Lesser General Public License for more | ||
| * details. | ||
| * | ||
| * You should have received a copy of the GNU Lesser General Public License | ||
| * along with this library; if not, write to the Free Software Foundation, Inc., | ||
| * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. | ||
| */ | ||
|
|
||
| #ifndef NAMEUTILS_H | ||
| #define NAMEUTILS_H | ||
|
|
||
| #include <QString> | ||
|
|
||
| /** | ||
| * Cross-plateform utilities to retrieve the name of the user. | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. typo plateform
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. argghh, I'll never get this one right..! thanks |
||
| */ | ||
| namespace nameutils | ||
| { | ||
|
|
||
| /** | ||
| * Retrieve the full name of the user (e.g. "John Doe"). | ||
| * @return full name if available, else the basic username or an empty string. | ||
| */ | ||
| QString getFullUsername(); | ||
|
|
||
| } | ||
|
|
||
| #endif | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| /* Copyright (c) 2016, EPFL/Blue Brain Project | ||
| * Raphael Dumusc <raphael.dumusc@epfl.ch> | ||
| * | ||
| * This file is part of Deflect <https://github.com/BlueBrain/Deflect> | ||
| * | ||
| * This library is free software; you can redistribute it and/or modify it under | ||
| * the terms of the GNU Lesser General Public License version 3.0 as published | ||
| * by the Free Software Foundation. | ||
| * | ||
| * This library is distributed in the hope that it will be useful, but WITHOUT | ||
| * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS | ||
| * FOR A PARTICULAR PURPOSE. See the GNU Lesser General Public License for more | ||
| * details. | ||
| * | ||
| * You should have received a copy of the GNU Lesser General Public License | ||
| * along with this library; if not, write to the Free Software Foundation, Inc., | ||
| * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. | ||
| */ | ||
|
|
||
| #include "nameUtils.h" | ||
|
|
||
| #import <Foundation/NSPathUtilities.h> | ||
|
|
||
| namespace nameutils | ||
| { | ||
|
|
||
| QString getFullUsername() | ||
| { | ||
| const auto fullname = QString{ [NSFullUserName() UTF8String] }; | ||
| if( !fullname.isEmpty( )) | ||
| return fullname; | ||
|
|
||
| return qgetenv( "USER" ); | ||
| } | ||
|
|
||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DEFLECT_NAMEUTILS_H or similar prefix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the other files in DesktopStreamer don't do it. Should we use DESKTOPSTREAMER_ everywhere to avoid conflicts (e.g. in STREAM_H ) ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NAMEUTILS_H sounds very likely to exist somewhere in the world already as a system header. Prefix with DESKTOPSTREAMER_ seems reasonable too. Or pragma once, what Stefan did.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added DESKTOPSTREAMER_ everywhere