This repository was archived by the owner on Feb 26, 2025. It is now read-only.
Add a test that test all types in a scalar way #653
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alkino
force-pushed
the
cornu/all_types
branch
7 times, most recently
from
147ade9 to
03b57c4
Compare
alkino
force-pushed
the
cornu/cleaning
branch
from
1e8136a to
cde6909
Compare
matz-e
previously approved these changes
Nov 25, 2022
alkino
force-pushed
the
cornu/all_types
branch
from
03b57c4 to
d3309ba
Compare
ohm314
reviewed
Dec 6, 2022
|
|
||
| // Create the dataset | ||
| DataSet dataset = | ||
| file.createDataSet(DATASET_NAME, {5}, create_datatype<typename TestType::value_type>()); |
Contributor
There was a problem hiding this comment.
I guess this is causing warnings when {5} is cast to a type where you may lose the sign.
alkino
force-pushed
the
cornu/all_types
branch
from
d3309ba to
a8d305d
Compare
Codecov Report
@@ Coverage Diff @@
## cornu/fix_support_of_bool #653 +/- ##
=============================================================
+ Coverage 80.21% 80.50% +0.29%
=============================================================
Files 66 67 +1
Lines 3973 4027 +54
=============================================================
+ Hits 3187 3242 +55
+ Misses 786 785 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I will endly try to get a full tests of all types we support.
This PR is a WIP to fix #496