This repository was archived by the owner on Feb 26, 2025. It is now read-only.
Avoid templated friend classes. #688
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1uc
force-pushed
the
1uc/avoid-template-friend-classes
branch
from
b6b15d9 to
38dce1c
Compare
There seems to be a compiler bug in numerous version of GCC which
prevent code such as:
class Foo {
template<class Derived>
friend class SomeCRTP<Derived>;
};
This commit removed all such constructs from HighFive, by allowing a
function `detail::make_*` to create `Object`, `Selection` and `Group`
from an `hid_t`.
1uc
force-pushed
the
1uc/avoid-template-friend-classes
branch
from
38dce1c to
3a376eb
Compare
alkino
approved these changes
Feb 20, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There seems to be a compiler bug in numerous version of GCC which
prevent code such as:
This commit removed all such constructs from HighFive, by allowing a
function
detail::make_*to createObject,SelectionandGroupfrom an
hid_t.