This repository was archived by the owner on Feb 26, 2025. It is now read-only.
Fix compilation failures for custom installation locations #726
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an import statement that causes compilations to fail when trying to use HighFive as a header-only library with custom install locations. Symptoms are: (i)
fatal error: 'highfive/H5Utiity.hpp' not foundif the conda environment does not contain a systemhighfiveor (ii) a long error stack starting witherror: redefinition of 'SilencedHDF5' [...]if trying to compile with a custom location while having ahighfivepackage installed. Using the relative import (which is used everywhere else) fixes the issue.How to test this?
cmake .. make -j8 make testTest System
condaenvironment with/withouthighfivepackage installed)