Skip to content
This repository was archived by the owner on Feb 26, 2025. It is now read-only.

Conversation

@1uc
Copy link
Collaborator

@1uc 1uc commented May 30, 2023

This is fixup of #764.

Adds the ability to retrieve the size of the file (on disk) and the amount of tracked unused space.
@codecov
Copy link

codecov bot commented May 30, 2023

Codecov Report

Merging #768 (9d642d0) into master (8058858) will increase coverage by 0.09%.
The diff coverage is 92.15%.

@@            Coverage Diff             @@
##           master     #768      +/-   ##
==========================================
+ Coverage   83.84%   83.94%   +0.09%     
==========================================
  Files          67       67              
  Lines        4551     4602      +51     
==========================================
+ Hits         3816     3863      +47     
- Misses        735      739       +4     
Impacted Files Coverage Δ
include/highfive/H5File.hpp 100.00% <ø> (ø)
include/highfive/bits/H5File_misc.hpp 90.66% <66.66%> (-4.58%) ⬇️
tests/unit/tests_high_five_base.cpp 99.67% <100.00%> (+<0.01%) ⬆️

This includes:
  * rename both methods.
  * add slightly more detailed documentation.
  * split unit-tests and remove hard-coded constants.
@1uc 1uc requested a review from alkino May 30, 2023 10:49
@1uc 1uc marked this pull request as ready for review May 30, 2023 14:16
alkino
alkino previously approved these changes May 30, 2023
Co-authored-by: Luc Grosheintz <luc.grosheintz@gmail.com>
@1uc 1uc requested a review from alkino May 31, 2023 06:24
@1uc 1uc merged commit 094400f into master May 31, 2023
@1uc 1uc deleted the fileSize branch May 31, 2023 12:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants