Skip to content
This repository was archived by the owner on Feb 26, 2025. It is now read-only.

Conversation

@1uc
Copy link
Collaborator

@1uc 1uc commented Dec 18, 2023

See #899 for what the issue is and a safe alternative. Unfortunately, changing an enum to an enum class is a breaking change and can't be done until 3.0.0.

@1uc 1uc added the v3 Anything that needs to be resolved before `v3`. label Dec 18, 2023
@codecov
Copy link

codecov bot commented Dec 18, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (066c188) 86.11% compared to head (a8eed46) 86.13%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #900      +/-   ##
==========================================
+ Coverage   86.11%   86.13%   +0.01%     
==========================================
  Files          90       90              
  Lines        5864     5872       +8     
==========================================
+ Hits         5050     5058       +8     
  Misses        814      814              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@1uc 1uc marked this pull request as ready for review December 18, 2023 09:33
@1uc 1uc marked this pull request as draft December 21, 2023 10:16
@1uc 1uc force-pushed the 1uc/dataspace-enum-class branch from 4425576 to a8eed46 Compare February 9, 2024 10:53
@1uc 1uc marked this pull request as ready for review February 9, 2024 10:54
@1uc 1uc merged commit f1fbf21 into master Feb 9, 2024
@1uc 1uc deleted the 1uc/dataspace-enum-class branch February 9, 2024 16:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

v3 Anything that needs to be resolved before `v3`.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants