Conversation
|
@matz-e you're welcome to read this, I still have to up the coverage, and fix some of the build checks. |
matz-e
left a comment
matz-e
left a comment
There was a problem hiding this comment.
Alright, I think these are my initial 0.02 BTC. I've reached my mental call-graph reconstruction capacity, so I'm sorry if some of these don't make sense.
src/node_sets.cpp
Outdated
| case Op::regex: | ||
| return "$regex"; | ||
| default: | ||
| throw SonataError("Not Implemented NodeSetBasicOperator"); |
There was a problem hiding this comment.
I let clang-format work its magic
There was a problem hiding this comment.
I meant with fmt::format, sorry, not very clear.
use vector<bool> as suggested by Matthias
python/generated/docstrings.h
Outdated
|
|
||
| static const char *__doc_bbp_sonata_NodePopulation_matchAttributeValues_2 = R"doc(Like matchAttributeValues, but for vectors of values to match)doc"; | ||
|
|
||
| static const char *__doc_bbp_sonata_NodePopulation_regexMatch = R"doc()doc"; |
There was a problem hiding this comment.
No documentation?
Also, should we explicitly mark these as extensions to the SONATA™ spec? Or is there an upstream PR amending this situation already?
There was a problem hiding this comment.
thanks, need to add the doc...I will do that.
I think it's worth doing a PR upstream to the docs, at least so ppl can read about the feature
2 participants
No description provided.