Conversation
NadirRoGue
left a comment
There was a problem hiding this comment.
Everything looks good
|
@mgeplf I asked @alkino to make some changes here in regards to the Thus, I suggested to try to keep the original design while still not affecting the performance of |
773fdd2 to
300dd68
Compare
300dd68 to
871c761
Compare
This reverts commit 871c761.
|
I would like to get this merged before I do a libsonata release, but I'm still puzzled by the comments; can you have a look @alkino? |
|
updated |
|
I changed the name of the function, and tried to make the docstrings more clear. @NadirRoGue or @alkino could you clean them up further; things like |
|
I've added some extra doc for the return format of |
|
Ok, I'll take it from here, I guess. Thanks. |
Fix #149