This repository was archived by the owner on Feb 26, 2025. It is now read-only.
Conversation
Collaborator
Author
|
This PR contains two variants:
Note, that the default STL conversion implies a copy. Hence, this is likely the same amount of copies. |
08f43e3 to
e682994
Compare
matz-e
previously approved these changes
Nov 28, 2023
This was referenced Nov 28, 2023
By using an `std::array` we can removed the differences between `RawIndex` and `Selection::Ranges`. It also allows us to read `Selection::Ranges` from disk directly via the HighFive API.
This reverts commit 17b1c6b.
e682994 to
91fe2cb
Compare
Collaborator
Author
|
Updates of the BBP stack built on BB5 have been prepared and pass CI: We needed to change: |
mgeplf
approved these changes
Nov 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By using an
std::arraywe can removed the differences betweenRawIndexandSelection::Ranges. It also allows us to readSelection::Rangesfrom disk directly via the HighFive API.