Skip to content

Add general introduction and quick installation.#43

Merged
Will-Guan merged 9 commits intomainfrom
update-mcp-server
Apr 17, 2026
Merged

Add general introduction and quick installation.#43
Will-Guan merged 9 commits intomainfrom
update-mcp-server

Conversation

@jizhen181-dot
Copy link
Copy Markdown
Collaborator

No description provided.

@github-actions
Copy link
Copy Markdown

Code Review Report

Project: BANK OF AI Documentation (@x402-tron/docs)
PR: mainupdate-mcp-server
Review Date: 2026-04-15
Reviewer: AI Code Reviewer (Code Review Skill v1.0.0)


PR Overview

Branch Information

Property Value
From Branch main
To Branch update-mcp-server
Commits 18
Files Changed 24
Lines Added +1,713
Lines Removed -97

Commit History

Hash Message
0134a17 Add general introduction and quick installation.
a936d87 Merge pull request #42 from BofAI/ai-bankofai-patch-1
d286300 Merge branch 'main' into ai-bankofai-patch-1
919cda6 change version
0991037 update name
26c666e Update Claude Code x BANK OF AI API Configuration Guide.md
01d6587 Create Claude Code x BANK OF AI API Configuration Guide.md
aa2681e Rename Claude Code x BANK OF AI API Configuration Guide to claude-code-bank-of-ai.md
a85f6d8 Create Claude Code x BANK OF AI API Configuration Guide
a932d7e Merge pull request #41 from BofAI/update-mcp-server
21d856e Update introduction.md
90d5caa Update quick-start.md
a9f04aa Update introduction.md
d035af7 Update introduction.md
3e5caac Update introduction.md
283d807 Update introduction.md
463dd62 Update quick-start.md
620f06b Update quick-start.md

Review Summary

Verdict

Verdict: Request Changes — the PR is high quality and well-structured, but one Major issue (removal of MCP client restart guidance from troubleshooting) risks leaving users blocked when MCP tools silently fail to appear. Several Minor and Suggestion-level items are also worth addressing before merge.

Findings at a Glance

Critical Major Minor Suggestion
Count 0 1 4 3

Summary

This PR introduces a substantial new "BANK OF AI" documentation section (Intro.md, QuickStart.md, architecture SVG) and refactors the existing MCP Server and SKILLS installation guides to prioritise a new "conversational install" flow alongside the existing CLI options. The overall content quality is high: the three-method structure (Conversational → Auto-Install CLI → Interactive CLI) is consistent across all updated files, the admonition blocks (tip/caution/danger) are used appropriately, and the architecture diagram is a valuable addition for understanding the stack.

The primary concern is a systematic removal of "restart your AI client" instructions across multiple files (TRONMCPServer/QuickStart.md, TRONMCPServer/OfficialServerAccess.md, SUNMCPServer/QuickStart.md, SUNMCPServer/OfficialServerAccess.md). MCP configuration changes typically require a full client restart to take effect, and silently removing that guidance — without explaining why it is no longer needed — will leave users stuck when newly installed MCP tools fail to appear. This should be clarified or restored before merge.

Four Minor issues cover an example password visible in documentation output examples, unverified internal cross-reference links in new pages, a mildly misleading "100% offline" claim, and a subtle security-tone inconsistency in the wallet backup warnings. Three Suggestions cover adding a troubleshooting section for the new conversational install path, clarifying i18n mirror maintenance, and expanding the "What's Next" navigation for the BANK-OF-AI section.


Change Summary

1. New: BANK OF AI Documentation Section

File Change Type Description
docs/BANK-OF-AI/Intro.md Added Full architectural introduction covering all 7 core modules (AI Agent, Skills, Agent-Wallet, x402, 8004, MCP Server, SUN CLI)
docs/BANK-OF-AI/QuickStart.md Added One-sentence "agent install everything" onboarding guide with step-by-step breakdown of what the AI does
docs/BANK-OF-AI/image/bankofai-architecture.svg Added Architecture flow diagram (SVG, 159 lines)
sidebars.js Modified New BANK OF AI category (collapsed: false) added to the top of docsSidebar

Purpose: Introduce BANK OF AI as a top-level product concept with its own navigation section, giving users a single entry point before diving into individual components.


2. Updated: MCP Server Installation Guides (TRON & SUN)

File Change Type Description
docs/McpServer-Skills/MCP/TRONMCPServer/QuickStart.md Modified Replace "tell AI to run command" with structured 3-step conversational install flow
docs/McpServer-Skills/MCP/TRONMCPServer/OfficialServerAccess.md Modified Add Method 1 (Conversational) and Method 3 (Interactive) labels; remove restart step from troubleshooting
docs/McpServer-Skills/MCP/SUNMCPServer/QuickStart.md Modified Same pattern as TRON QuickStart
docs/McpServer-Skills/MCP/SUNMCPServer/OfficialServerAccess.md Modified Same pattern as TRON OfficialServerAccess

Purpose: Standardise installation UX across all MCP guides; make conversational install the recommended default.


3. Updated: SKILLS Installation Guide

File Change Type Description
docs/McpServer-Skills/SKILLS/QuickStart.md Modified Expand single "Quick Auto-Install" block into three labelled methods; add conversational install with example dialog
docs/McpServer-Skills/SKILLS/image/conversational-install.png Added Screenshot demonstrating conversational install flow

Purpose: Mirror the conversational-install pattern from MCP guides into the SKILLS guide for consistency.


4. Updated: Agent-Wallet Quick Start

File Change Type Description
docs/Agent-Wallet/QuickStart.md Modified Add Method 1 (Conversational Setup) before the existing CLI steps; demote CLI steps to Method 2

Purpose: Allow users who already have BANK OF AI skills installed to create a wallet entirely through chat, without touching the terminal.


5. Infrastructure / Config

File Change Type Description
package.json Modified Version bump: 1.2.81.2.9
i18n/.../current.json Modified Sidebar i18n metadata updated for new BANK-OF-AI pages
i18n/.../current/** Added/Modified Mirror of all content changes for i18n locale

Purpose: Minor version bump reflecting new docs content; i18n files kept in sync with English source.


Detailed Findings


Major

[MJ-01] Restart Guidance Removed Without Explanation — Users Will Silently Fail

Property Value
Severity Major
Category Correctness / Documentation
Files docs/McpServer-Skills/MCP/TRONMCPServer/QuickStart.md, docs/McpServer-Skills/MCP/TRONMCPServer/OfficialServerAccess.md, docs/McpServer-Skills/MCP/SUNMCPServer/QuickStart.md, docs/McpServer-Skills/MCP/SUNMCPServer/OfficialServerAccess.md

Description

Across all four MCP installation files, every instruction to restart the AI client after installing an MCP server has been removed. In TRONMCPServer/OfficialServerAccess.md, the troubleshooting checklist item "AI client has been fully quit and restarted (not just refreshed)" was also deleted. MCP configuration changes are written to a local JSON config file; most AI clients (Claude Code, Cursor, VS Code, etc.) only read this file at startup — meaning a restart is required before the new MCP server becomes visible to the model. Silently omitting this step will leave many users confused when they install the server but MCP tools never appear in their session.

Code (removed from TRONMCPServer/QuickStart.md)

-After the command completes, restart your MCP client.
...
-## Restart and Test
-
-After saving the configuration, **completely quit and restart** your AI client.
-After restarting, the client will automatically connect to TRON MCP Server.
-
-Then enter your first query in the chat:
+## Test It Out
+
+Enter your first query in the chat:

Code (removed from TRONMCPServer/OfficialServerAccess.md troubleshooting)

 If you encounter issues, first confirm:
 1. Node.js version >= 20.0.0 (run `node --version` to check)
 2. Network can reach `tron-mcp-server.bankofai.io`
-3. AI client has been fully quit and restarted (not just refreshed)

Recommendation

Either:

  • Restore the restart instruction for the CLI-based Methods 2 and 3, noting that conversational install (Method 1) may handle the restart automatically; or
  • Explicitly explain why a restart is no longer required (e.g., "the conversational install flow triggers a hot-reload automatically"), and restore the troubleshooting checklist item for users who used the CLI path.

Example for OfficialServerAccess.md troubleshooting:

If you encounter issues, first confirm:
1. Node.js version >= 20.0.0 (run `node --version` to check)
2. Network can reach `tron-mcp-server.bankofai.io`
3. If you used Method 2 or 3 (CLI install): fully quit and restart your AI client
   (config changes are only picked up at startup, not via refresh)

Minor

[MN-01] Example Output Shows a Plausible-Looking Real Password

Property Value
Severity Minor
Category Security / Documentation
File docs/Agent-Wallet/QuickStart.md : Lines ~70–80 (new Method 1 section)

Description

The new "Conversational Setup" section shows a sample terminal output that includes a bare password string ($mU80m9fLYB5) inside a code block meant to demonstrate what users will see. While contextually labelled as an example, the string resembles a strong real password. If readers are skimming, they may copy it as a template; malicious actors who encounter this in search results or cached pages might also attempt it against real wallets. Documentation examples for secrets should always use unmistakably fictional placeholder values.

Code

🔐 Wallet password

$mU80m9fLYB5

Recommendation

Replace with an obviously fake placeholder that no user would mistake for a valid password:

🔐 Wallet password

<your-auto-generated-password-appears-here>

Or use a clearly synthetic format:

$ExAmPlE-PaSsWoRd-D0-n0t-Use!

[MN-02] New Pages Contain Unverified Internal Cross-Reference Links

Property Value
Severity Minor
Category Correctness / Documentation
File docs/BANK-OF-AI/Intro.md : multiple link references

Description

BANK-OF-AI/Intro.md contains numerous relative links to pages that are not part of this PR's diff. If any of these paths are wrong or the target pages use different slugs, users will hit 404 errors from the new top-level BANK OF AI section — the most prominent entry point in the sidebar.

Links at risk (not validated in diff):

[LLM Service Introduction](../llmservice/introduction.md)
[Skills Introduction](../McpServer-Skills/SKILLS/Intro.md)
[Agent-Wallet Introduction](../Agent-Wallet/Intro.md)
[x402 Protocol Introduction](../x402/index.md)
[8004 Protocol Introduction](../8004/general.md)
[MCP Server Introduction](../McpServer-Skills/MCP/Intro.md)
[SUN CLI Introduction](../McpServer-Skills/Tools/SUNCli/Intro.md)
[TRON MCP — Local Private Deployment](../McpServer-Skills/MCP/TRONMCPServer/LocalPrivatizedDeployment.md)
[SUN MCP — Local Private Deployment](../McpServer-Skills/MCP/SUNMCPServer/LocalPrivatizedDeployment.md)

Recommendation

Run Docusaurus's built-in broken-link checker before merge:

yarn build 2>&1 | grep -i "broken\|404\|not found"

Or run npx docusaurus-link-checker if available. Fix any 404s before merge since this is the new primary landing section.


[MN-03] "100% Offline" Signing Claim Is Misleading

Property Value
Severity Minor
Category Documentation / Accuracy
File docs/BANK-OF-AI/Intro.md : Agent-Wallet section

Description

The Intro page describes Agent-Wallet's local signing as "100% offline" in bold. The signing step itself is local, but the signed payload must then be broadcast to the blockchain over the internet. Calling the entire process "100% offline" is inaccurate and may cause user confusion or misplaced trust (e.g., users thinking transactions are somehow air-gapped). This is a documentation accuracy issue in freshly written content.

Code

- **Local Signing**: all signing happens entirely on your machine — **100% offline** —
  your private key never leaves your computer

Recommendation

Qualify the claim to describe what is actually offline — the signing step, not the broadcast:

- **Local Signing**: all transaction signing happens entirely on your machine — your
  private key never leaves your computer. Only the signed payload is transmitted to the network.

[MN-04] Inconsistent Security Tone in Password Backup Warnings

Property Value
Severity Minor
Category Documentation / UX
File docs/Agent-Wallet/QuickStart.md : Method 1 section

Description

Two consecutive admonition blocks in Method 1 send contradictory urgency signals about the master password backup. The :::caution block correctly warns that if runtime_secrets.json is lost and no external backup exists, the wallet is permanently unrecoverable. However, the immediately following :::tip says "You don't need to manually export AGENT_WALLET_PASSWORD" — which is true, but may inadvertently downplay the caution just issued. A user who speed-reads could take away "auto-saved = I'm covered" and skip the external backup.

Code

:::caution Back up your wallet password!
Even though the password is auto-saved to `~/.agent-wallet/runtime_secrets.json`,
**you still must copy it separately** into a password manager ...
:::

:::tip Done — no env-var configuration needed
... You don't need to manually export `AGENT_WALLET_PASSWORD`.
:::

Recommendation

Reorder the tip to appear first (installation convenience), then the caution (backup urgency), so the caution is the last thing users read before moving on:

:::tip Done — no env-var configuration needed
Conversational setup auto-saves the password to `~/.agent-wallet/runtime_secrets.json`,
which your AI Agent reads automatically. You don't need to manually export `AGENT_WALLET_PASSWORD`.
:::

:::caution Back up your wallet password!
The auto-saved file is convenient, but it is not a backup.
If the file is deleted, your disk fails, or you reinstall your OS, **you permanently lose wallet access**.
Copy the password to a password manager (1Password, Bitwarden, etc.) right now.
:::

Suggestions

[S-01] No Troubleshooting Section for Conversational Install Method

Files: docs/McpServer-Skills/MCP/TRONMCPServer/QuickStart.md, docs/McpServer-Skills/MCP/SUNMCPServer/QuickStart.md, docs/McpServer-Skills/SKILLS/QuickStart.md

Description: The new Method 1 (conversational install) has no troubleshooting guidance. The CLI methods each link to detailed OfficialServerAccess pages with troubleshooting checklists. Conversational install introduces new failure modes: the AI client may not support shell command execution, Node.js might be missing on the machine hosting the agent, or the AI might misinterpret the pasted prompt. A short :::note If the AI can't complete this step...::: admonition covering these cases would greatly reduce support load for users who choose the "easiest" method.

Suggestion: Add a collapsible "Troubleshooting conversational install" section covering:

  1. AI says it can't run shell commands → switch to Method 2
  2. AI reports "npx not found" → install Node.js first
  3. AI completes but MCP tools don't appear → restart the AI client manually

[S-02] i18n Mirror Files Should Be Noted as Auto-Generated

Files: i18n/*/docusaurus-plugin-content-docs/current/**

Description: The diff includes 10 mirrored i18n files that are byte-for-byte copies of the English source (they appear to be the same content, not yet translated). This is standard Docusaurus i18n scaffold behaviour. However, if future contributors aren't aware that these mirrors exist, they may update the English docs and forget to sync the i18n copies, leading to stale translated content. A brief note in CONTRIBUTING.md (or a CI check) would prevent drift.

Suggestion: Add a CI step using docusaurus write-translations or a simple diff check to detect when English source and i18n copies diverge unexpectedly.


[S-03] BANK-OF-AI QuickStart Missing Verification Link After "agent install everything"

File: docs/BANK-OF-AI/QuickStart.md

Description: The QuickStart tells users to ask the AI "What BANK OF AI Skills do I have installed?" to verify the install, but gives no guidance on what to do if the verification fails. The Agent-Wallet and MCP Quick Start pages have richer "If you encounter issues..." sections. Adding even a brief "If Skills aren't listed, try..." pointer with a link to the detailed troubleshooting pages would make this high-visibility entry point more resilient for beginners.

Suggestion: After the verification step, add:

If the AI can't list any skills, see [SKILLS Quick Start — Troubleshooting](../McpServer-Skills/SKILLS/QuickStart.md#troubleshooting)
or [TRON MCP Troubleshooting](../McpServer-Skills/MCP/TRONMCPServer/OfficialServerAccess.md#troubleshooting).

Positive Observations

Area Observation
Consistency The three-method install pattern (Conversational → Quick Auto-Install → Interactive) is applied uniformly across all six updated MCP/SKILLS guides, making the docs feel like a cohesive system rather than individual pages
Admonition use :::tip, :::caution, :::danger, and :::info admonitions are used appropriately and proportionally — security warnings (password backup) correctly use :::caution and irreversible-action warnings correctly use :::danger
Architecture diagram Adding bankofai-architecture.svg gives users a mental model of the full stack before reading any details; this kind of visual overview significantly reduces cognitive load for onboarding
Security guidance The wallet password backup warnings are thorough and appear at multiple appropriate points; the explanation that "two locks, orders of magnitude safer than plaintext keys" is well-written and accessible to non-technical users
Scoping of Method 1 Conversational install is consistently gated by clear prerequisites (Node.js, shell execution support) so users who can't use it are redirected to CLI methods rather than left stuck
Sidebar structure Placing the new BANK OF AI category at the top of docsSidebar with collapsed: false makes it immediately visible, which is appropriate for a high-level product overview section
Version discipline A minor version bump (1.2.81.2.9) in package.json correctly signals non-breaking, additive documentation changes
Testnet-first advice The "Three Rules for Beginners" warning block in BANK-OF-AI/QuickStart.md proactively steers new users toward testnet practice before touching mainnet funds — best practice for blockchain docs

Checklist Results

Category Items Checked Pass Fail N/A Notes
Correctness 5 4 1 2 MJ-01: restart step removed without explanation
Security 6 5 1 2 MN-01: example password too realistic
Performance 7 0 0 7 Not applicable (documentation-only PR)
Code Quality 8 7 1 1 MN-03: accuracy claim; overall structure excellent
Testing 6 0 0 6 Not applicable (documentation-only PR)
Documentation 8 5 3 0 MN-02 (broken links), MN-04 (tone), S-03 (missing troubleshooting)
Compatibility 5 5 0 0 i18n mirrors updated; sidebar change is backward-compatible
Observability 4 0 0 4 Not applicable (documentation-only PR)

Disclaimer

This is an automated code review. It supplements but does not replace human review. The reviewer analysed only the diff between main and update-mcp-server. Runtime behaviour, integration testing, and deployment impact are not covered. Link validity was assessed by static analysis of the diff — a full Docusaurus build check is strongly recommended before merge.


Report generated by Code Review Skill v1.0.0
Date: 2026-04-15

@github-actions
Copy link
Copy Markdown

Code Review Report

Project: BANK OF AI Documentation Site (@x402-tron/docs)
PR: main -> update-mcp-server
Review Date: 2026-04-16
Reviewer: AI Code Reviewer (Code Review Skill v1.0.0)


PR Overview

Branch Information

Property Value
From Branch main
To Branch update-mcp-server
Commits 18
Files Changed 24
Lines Added +1,921
Lines Removed -97

Commit History

86022be add bankofai
0134a17 Add general introduction and quick installation.
a936d87 Merge pull request #42 from BofAI/ai-bankofai-patch-1
d286300 Merge branch 'main' into ai-bankofai-patch-1
919cda6 change version
0991037 update name
26c666e Update Claude Code x BANK OF AI API Configuration Guide.md
01d6587 Create Claude Code x BANK OF AI API Configuration Guide.md
aa2681e Rename Claude Code x BANK OF AI API Configuration Guide to claude-code-bank-of-ai.md
a85f6d8 Create Claude Code x BANK OF AI API Configuration Guide
a932d7e Merge pull request #41 from BofAI/update-mcp-server
21d856e Update introduction.md
90d5caa Update quick-start.md
a9f04aa Update introduction.md
d035af7 Update introduction.md
3e5caac Update introduction.md
283d807 Update introduction.md
463dd62 Update quick-start.md
620f06b Update quick-start.md

Review Summary

Verdict

Verdict: Request Changes

Findings at a Glance

Critical Major Minor Suggestion
Count 0 3 5 4

Summary

This PR introduces the new BANK OF AI product section (Intro + QuickStart), restructures the MCP Server installation guides across TRON and SUN MCP Servers to add a recommended "Conversational Install" method, restructures the Agent-Wallet Quick Start to present two setup paths, and adds the new BANK OF AI skill installation method to the SKILLS Quick Start. It also bumps package.json from version 1.2.8 to 1.2.9 and registers the new sidebar category in both the main and i18n sidebars.

The documentation is well-structured and the conversational-install paradigm is a genuine UX improvement. However, several issues need to be addressed: the PR silently removes the "restart your AI client" instruction from two installation guides (a correctness regression that will confuse users), a sample wallet output in Agent-Wallet QuickStart exposes what appears to be a real or realistic-looking password, the i18n Chinese sidebar label for "BANK OF AI" is untranslated, and the main sidebars.js loses the "Claude Code" sub-category that existed in main. Minor documentation consistency and structural issues are also present.


Change Summary

1. New BANK OF AI Section (docs/BANK-OF-AI/)

Two entirely new files:

  • docs/BANK-OF-AI/Intro.md — Full product matrix introduction (LLM Service, x402 Payment, 8004 Protocol, Agent Wallet, Skills, MCP Server, Ecosystem Layer)
  • docs/BANK-OF-AI/QuickStart.md — Two-step end-to-end onboarding guide referencing other sections
  • docs/BANK-OF-AI/image/bankofai-architecture.svg — Architecture diagram

2. MCP Server Installation Guides Restructured

Both docs/McpServer-Skills/MCP/TRONMCPServer/ and docs/McpServer-Skills/MCP/SUNMCPServer/ had their QuickStart.md and OfficialServerAccess.md updated to present three tiered methods: Conversational Install (new), Quick Auto-Install (CLI), Interactive Install (most control).

3. SKILLS QuickStart Restructured

docs/McpServer-Skills/SKILLS/QuickStart.md gained a new "Method 1: Conversational Install" section with a screenshot and a detailed example dialog, placed before the existing command-line methods.

4. Agent-Wallet QuickStart Restructured

docs/Agent-Wallet/QuickStart.md was reorganised to present "Method 1: Conversational Setup" first, and the original CLI flow moved to "Method 2: Command-Line Setup". Header levels were adjusted accordingly.

5. Navigation and Configuration

  • sidebars.js and i18n/zh-Hans/docusaurus-plugin-content-docs/current/sidebars.js — new "BANK OF AI" category prepended to the sidebar.
  • i18n/zh-Hans/docusaurus-plugin-content-docs/current.json — i18n entry added for the new sidebar label.
  • package.json — version bumped from 1.2.8 to 1.2.9.
  • i18n mirror files added for all new/changed docs under i18n/zh-Hans/docusaurus-plugin-content-docs/current/.

Detailed Findings

Major Findings


Finding M-1: "Restart your AI client" instruction silently removed from MCP Server installation guides

  • Severity: Major
  • Category: Correctness / Docs
  • Files:
    • docs/McpServer-Skills/MCP/SUNMCPServer/OfficialServerAccess.md (lines ~68, ~141 in new file)
    • docs/McpServer-Skills/MCP/TRONMCPServer/OfficialServerAccess.md (lines ~87, ~160 in new file)
    • docs/McpServer-Skills/MCP/SUNMCPServer/QuickStart.md
    • docs/McpServer-Skills/MCP/TRONMCPServer/QuickStart.md

Description:
The previous main versions of both MCP OfficialServerAccess pages contained the instruction "Once installation is complete, restart your AI Agent" after both the Quick Auto-Install and the interactive installation sections. The PR removes these lines.

Additionally, the Verify Connection troubleshooting list on SUNMCPServer/OfficialServerAccess.md previously included a third bullet:

  1. AI client has been fully quit and restarted (not just refreshed)

This bullet was removed entirely.

MCP clients must restart to load a newly added MCP server into their context. Removing the restart instruction is a functional regression that will cause users to believe the installation failed when the server is simply not yet loaded.

Diff evidence (SUNMCPServer/OfficialServerAccess.md):

-Once installation is complete, restart your AI Agent, and you can start interacting with SunSwap via SUN MCP Server.
+Once installation is complete, you can start interacting with SunSwap via SUN MCP Server.
-3. AI client has been fully quit and restarted (not just refreshed)

Recommendation:
Re-add the restart instruction after the Method 2 (Quick Auto-Install) and Method 3 (Interactive Install) completion steps in all four affected files. The restart instruction remains correct and important; it was only superseded for Method 1 (Conversational Install) where the AI agent detects the install and may handle this automatically. The troubleshooting bullet should also be restored.


Finding M-2: Sample output in Agent-Wallet QuickStart contains an exposed, realistic-looking password

  • Severity: Major
  • Category: Security / Docs
  • File: docs/Agent-Wallet/QuickStart.md

Description:
The new "Method 1: Conversational Setup" section includes a verbatim sample of what the AI assistant returns after wallet creation. That sample includes a concrete-looking password:

🔐 Wallet password

$mU80m9fLYB5

Even if this is an illustrative example, presenting a specific password string (rather than a clearly masked placeholder like <your-unique-password>) in official documentation is a security anti-pattern. Readers may mistakenly believe this is a safe default to reuse, or the example may be confused for credential leakage by automated secret-scanning tools (e.g., GitHub secret scanning, truffleHog).

Diff evidence:

+🔐 Wallet password
+
+$mU80m9fLYB5

Recommendation:
Replace the literal password with a clearly marked placeholder, for example:

🔐 Wallet password

<your-unique-auto-generated-password>

This is consistent with how BANK-OF-AI/QuickStart.md handles the same example (<your unique master password is shown here>).


Finding M-3: sidebars.js in update-mcp-server drops the "Claude Code" sub-category that exists in main

  • Severity: Major
  • Category: Correctness
  • File: sidebars.js

Description:
The main branch version of sidebars.js contains a "Claude Code" sub-category under the "LLM Service" section:

{
  type: 'category',
  label: 'Claude Code',
  collapsed: true,
  items: ['llmservice/Claude-Code/claudecode-bankofai-api-configuration-guide'],
},

This entry is absent from the update-mcp-server version of sidebars.js. The diff for sidebars.js only shows the addition of the "BANK OF AI" category; it does not add back the "Claude Code" category. This means the Claude Code integration guide linked from main would become inaccessible from the navigation after this PR is merged.

Diff evidence:
The diff for sidebars.js shows only an addition (the BANK OF AI category). Cross-referencing both full file contents confirms the "Claude Code" category block is present on main but absent on update-mcp-server.

Recommendation:
Verify whether the "Claude Code" sidebar entry should be preserved. If so, add it back to the update-mcp-server version of sidebars.js. The same check should be applied to the i18n sidebars.js.


Minor Findings


Finding m-1: i18n sidebar label for "BANK OF AI" is untranslated in Chinese

  • Severity: Minor
  • Category: Docs / Quality
  • File: i18n/zh-Hans/docusaurus-plugin-content-docs/current.json

Description:
The new i18n entry for the BANK OF AI sidebar category is:

"sidebar.docsSidebar.category.BANK OF AI": {
  "message": "BANK OF AI",
  "description": "The label for category BANK OF AI in sidebar docsSidebar"
}

The message field is identical to the English key. While "BANK OF AI" is a brand name and may intentionally remain untranslated, all other Chinese i18n entries in this file provide localised labels (e.g., "x402 Payment Protocol""x402支付协议"). At minimum a comment should clarify whether the lack of translation is intentional.

Recommendation:
Either provide a Chinese translation or add a comment to the description field indicating the brand name is intentionally kept in English, e.g., "description": "Brand name — intentionally kept in English".


Finding m-2: Inconsistent instruction prompt between BANK-OF-AI/QuickStart.md and McpServer-Skills/SKILLS/QuickStart.md

  • Severity: Minor
  • Category: Docs / Correctness
  • Files:
    • docs/BANK-OF-AI/QuickStart.md
    • docs/McpServer-Skills/SKILLS/QuickStart.md

Description:
The instruction text users are told to paste into their AI client differs slightly between these two documents.

BANK-OF-AI/QuickStart.md:

Run npx skills add BofAI/skills to install every BANK OF AI Skill. After the install completes, run bankofai-guide to walk me through the next steps.
Note: please install into this Agent's own skills directory.

McpServer-Skills/SKILLS/QuickStart.md:

Run npx skills add BofAI/skills to install all BANK OF AI skills. After installation, use bankofai-guide to guide subsequent operations.
Note: Please install to the skill directory corresponding to the current Agent.

Both are meant to accomplish the same task. The inconsistency in phrasing (especially "walk me through the next steps" vs. "guide subsequent operations") could confuse users who read both pages.

Recommendation:
Standardise the instruction prompt to a single canonical version across all documentation pages. The phrasing in BANK-OF-AI/QuickStart.md is more natural English and is recommended.


Finding m-3: Agent-Wallet QuickStart "Step 2" header is nested under "Method 2" but uses a different heading level inconsistently

  • Severity: Minor
  • Category: Quality / Docs
  • File: docs/Agent-Wallet/QuickStart.md

Description:
Under the new structure, the heading hierarchy within "Method 2: Command-Line Setup" uses ### for the method heading, then #### for sub-steps. However, "Step 2: Feed the Password to Your AI" and its children use ### (as they did in the original, pre-restructuring document), whereas "Step 1" sub-sections use ####. This is a heading-level inconsistency introduced by the restructuring.

Diff evidence:

-## Step 2: Feed the Password to Your AI (Critical!)
+### Step 2: Feed the Password to Your AI (Critical!)

-### 2.1 Save and Activate the Password
+#### 2.1 Save and Activate the Password

While the diff correctly demotes all headings by one level, the rendered TOC will correctly reflect the structure. However, this should be verified against the Docusaurus render to ensure TOC anchors are correct and navigation links (#step-2) from other pages remain functional.

Recommendation:
Check that any cross-document links pointing to heading anchors within Agent-Wallet/QuickStart.md (e.g., ./QuickStart.md#step-2) remain functional after the heading text changes. Update any broken anchors.


Finding m-4: BANK-OF-AI/Intro.md ecosystem table references npx skills add https://docs.etherscan.io — unlikely to be a valid install command

  • Severity: Minor
  • Category: Correctness / Docs
  • File: docs/BANK-OF-AI/Intro.md

Description:
The Ecosystem Layer table for Ethereum lists:

Product Provider Capabilities Install
Etherscan Etherscan Official Query / Tracking / Analytics, 60+ chains npx skills add https://docs.etherscan.io

The install command references https://docs.etherscan.io, which is the Etherscan documentation site, not a GitHub repository or npm package. npx skills add is expected to accept a GitHub user/repo slug or a GitHub URL. An HTTPS URL pointing to a documentation site is almost certainly incorrect and will fail for any user who tries to run it.

Recommendation:
Verify and replace with the correct install reference for the Etherscan skill, whether that is a GitHub repo slug (etherscan/etherscan-skills) or the correct URL. If the skill is not yet publicly available, remove or annotate the install command accordingly.


Finding m-5: SKILLS QuickStart — Method 2 description says "tell your AI Agent to execute" but this is a terminal command, inconsistent with the method's intent

  • Severity: Minor
  • Category: Docs / Clarity
  • File: docs/McpServer-Skills/SKILLS/QuickStart.md

Description:
Method 2 is titled "Quick Auto-Install (Command Line)", implying the user runs this in a terminal. However, its description says:

If you have Node.js installed and prefer the command line, simply tell your AI Agent to execute the following command:

Instructing the user to "tell your AI Agent to execute" a terminal command conflates the conversational-install flow (Method 1) with the direct CLI flow (Method 2). For Method 2, the user should run the command themselves in a terminal.

Recommendation:
Revise the description to read: "If you have Node.js installed and prefer the command line, run the following directly in your terminal:" — consistent with how the same method is described in SUNMCPServer/OfficialServerAccess.md and TRONMCPServer/OfficialServerAccess.md.


Suggestions


Suggestion S-1: Consider adding a "Windows Users" tab in Agent-Wallet QuickStart Method 2

  • Severity: Suggestion
  • Category: Docs / UX
  • File: docs/Agent-Wallet/QuickStart.md

Description:
The "2.1 Save and Activate the Password" section provides tabs for "Mac Users (Zsh)" and "Linux Users" but not for Windows users. Given the conversational-install method (Method 1) is now front-and-center for non-technical users, the CLI method targeting more technical users should still cover Windows to be complete.

Recommendation:
Add a Windows tab with $env:AGENT_WALLET_PASSWORD = 'your-password' (PowerShell) or instructions for setting environment variables via System Properties. Alternatively, note explicitly that Method 2 currently only supports macOS/Linux.


Suggestion S-2: The package.json version bump is not accompanied by a CHANGELOG entry

  • Severity: Suggestion
  • Category: Docs / Maintainability
  • File: package.json

Description:
The version was bumped from 1.2.8 to 1.2.9. No CHANGELOG.md file exists in the repo (and none is expected given this is a docs-only project), but the commit messages are generic ("add bankofai", "Add general introduction and quick installation."). For a documentation site, a brief entry noting what changed in the version is helpful for release tracking.

Recommendation:
Consider adding a CHANGELOG.md or using git tags to mark this release, or at minimum using more descriptive commit messages.


Suggestion S-3: Architecture SVG file uses inline <foreignObject> with HTML — verify cross-browser compatibility

  • Severity: Suggestion
  • Category: Quality
  • File: docs/BANK-OF-AI/image/bankofai-architecture.svg

Description:
The newly added SVG architecture diagram uses <foreignObject> elements to embed HTML content. <foreignObject> rendering in SVG is inconsistently supported across browsers and SVG renderers (e.g., it can fail in Safari, certain PDF exporters, and social media link previews). Docusaurus renders this inline or as an <img> tag depending on usage, and the <img> tag path will not render <foreignObject> HTML.

Recommendation:
Verify the SVG renders correctly in all major browsers and in the Docusaurus build output. If cross-browser consistency is needed, consider generating a rasterized PNG version of the diagram as a fallback.


Suggestion S-4: No i18n Chinese translations provided for the new BANK-OF-AI content

  • Severity: Suggestion
  • Category: Docs / Maintainability
  • Files:
    • i18n/zh-Hans/docusaurus-plugin-content-docs/current/BANK-OF-AI/Intro.md
    • i18n/zh-Hans/docusaurus-plugin-content-docs/current/BANK-OF-AI/QuickStart.md

Description:
The i18n mirror files for BANK-OF-AI under i18n/zh-Hans/docusaurus-plugin-content-docs/current/BANK-OF-AI/ appear to be copies of the English originals (based on the diff showing the same content added to the i18n directory). If the Chinese locale is actively maintained, these files should be translated. If they are intentionally English-only stubs, a comment should indicate this.

Recommendation:
Either translate the content or add a front-matter comment noting the file is a stub pending translation.


Positive Observations

  1. Well-structured tiered installation approach. Presenting "Conversational Install → Quick CLI → Interactive CLI" as three distinct methods with clear labels ("Easiest", "Command Line", "Most Control") is an excellent progressive disclosure pattern. It makes the documentation accessible to both non-technical users and developers.

  2. Strong security guidance in Agent-Wallet documentation. The caution blocks around password backup, the explicit warning about not using double quotes for environment variables with special characters, and the explanation of why echo to shell history is dangerous are all accurate, well-placed, and valuable guidance for users dealing with crypto wallet credentials.

  3. Consistent structure across MCP server documentation. The TRON MCP Server and SUN MCP Server installation guides now share an identical three-method structure with consistent phrasing, making it easy for users to transfer knowledge between sections.

  4. Comprehensive BANK OF AI introduction document. BANK-OF-AI/Intro.md provides a thorough layered overview of the product stack with working cross-references to all sub-product documentation. The "Is BANK OF AI for Me?" section with audience-specific messaging is a good documentation practice.

  5. Version bump is correctly scoped. The package.json version bump from 1.2.8 to 1.2.9 is appropriate for a documentation-only content addition.

  6. i18n files are kept in sync. All changed English documentation files have corresponding changes in the i18n/zh-Hans/ mirror directory, demonstrating good i18n hygiene.


Checklist Results

Category Check Result Notes
Correctness Logic/flow correct FAIL Restart instructions removed from MCP install guides (M-1)
Correctness Cross-references valid PARTIAL Etherscan install command likely invalid (m-4); heading anchors may break (m-3)
Correctness Claude Code sidebar preserved FAIL Claude Code category missing in updated sidebars.js (M-3)
Security No credentials/secrets exposed PARTIAL Realistic password in sample output (M-2)
Security Crypto wallet guidance is accurate PASS Strong guidance throughout
Performance No unbounded operations N/A Documentation-only PR
Quality Consistent terminology PARTIAL Instruction prompts differ between pages (m-2); Method 2 framing inconsistent (m-5)
Quality Heading hierarchy correct PARTIAL Minor inconsistency in Agent-Wallet QuickStart (m-3)
Testing Build/render tested UNKNOWN SVG foreignObject compatibility not verified (S-3)
Docs i18n entries added PARTIAL BANK OF AI label untranslated in zh-Hans (m-1); new content files are English stubs (S-4)
Docs All new sidebar entries registered PARTIAL New BANK OF AI section registered; Claude Code category accidentally dropped (M-3)

Disclaimer

This is an automated code review generated by AI Code Reviewer. All findings should be validated by a human engineer before action is taken. Severity ratings are advisory. Security-related findings in particular should be reviewed by a qualified security engineer.

@github-actions
Copy link
Copy Markdown

Code Review Report

Project: BANK OF AI Documentation (@x402-tron/docs)
PR: mainupdate-mcp-server
Review Date: 2026-04-16
Reviewer: AI Code Reviewer (Code Review Skill v1.0.0)


PR Overview

Branch Information

Property Value
From Branch origin/main
To Branch origin/update-mcp-server
Commits 19
Files Changed 24
Lines Added +1,831
Lines Removed -97

Commit History

Hash Message
2248ef7 add bankofai
86022be add bankofai
0134a17 Add general introduction and quick installation.
a936d87 Merge pull request #42 from BofAI/ai-bankofai-patch-1
d286300 Merge branch 'main' into ai-bankofai-patch-1
919cda6 change version
0991037 update name
26c666e Update Claude Code x BANK OF AI API Configuration Guide.md
01d6587 Create Claude Code x BANK OF AI API Configuration Guide.md
aa2681e Rename Claude Code x BANK OF AI API Configuration Guide
a85f6d8 Create Claude Code x BANK OF AI API Configuration Guide
a932d7e Merge pull request #41 from BofAI/update-mcp-server
21d856e Update introduction.md
90d5caa Update quick-start.md
a9f04aa Update introduction.md
(earlier) (multiple iterative doc updates)

Review Summary

Verdict

Verdict: Request Changes

Findings at a Glance

Critical Major Minor Suggestion
Count 0 2 5 4

Summary

This PR is a documentation-only release for a Docusaurus-based docs site. It introduces the new "BANK OF AI" product section (Intro + QuickStart pages) in both English and Chinese, retrofits all existing MCP Server and Skills install guides with a new "conversational install" method (Method 1), and bumps the package version from 1.2.8 to 1.2.9. The overall quality is high — the content is well-structured, bilingual parity is maintained, and the new conversational install flow is clearly explained with example dialogs.

Two major issues require attention before merge: a realistic-looking wallet password and a real-format wallet address are embedded in documentation example output without sufficient "sample only" labeling, and the deletion of the "restart AI client" troubleshooting step may leave users stranded when the conversational install path (which eliminates the restart) doesn't apply to their setup. Several minor issues cover documentation inconsistencies, an incorrect ecosystem install command, and SVG accessibility gaps.


Change Summary

1. New BANK-OF-AI Section (Docs + i18n)

File Change Type Description
docs/BANK-OF-AI/Intro.md Added Full product-architecture introduction (272 lines, EN)
docs/BANK-OF-AI/QuickStart.md Added Two-step quick-start guide (231 lines, EN)
docs/BANK-OF-AI/image/bankofai-architecture.svg Added Architecture flow diagram (SVG, EN labels)
i18n/zh-Hans/.../BANK-OF-AI/Intro.md Added Chinese translation of Intro (272 lines)
i18n/zh-Hans/.../BANK-OF-AI/QuickStart.md Added Chinese translation of QuickStart (231 lines)
i18n/zh-Hans/.../BANK-OF-AI/image/bankofai-architecture.svg Added Architecture diagram (SVG, CN labels)

Purpose: Introduces the BANK OF AI brand umbrella across its 4-layer architecture (Model / Protocol / Tool / Ecosystem), with a two-step "paste and reply A" quick-start that installs all Skills and auto-creates a wallet.


2. "Conversational Install" Added to Existing Guides

File Change Type Description
docs/McpServer-Skills/MCP/SUNMCPServer/OfficialServerAccess.md Modified Adds Method 1 (conversational); renames existing as Methods 2 & 3
docs/McpServer-Skills/MCP/SUNMCPServer/QuickStart.md Modified Replaces direct command with conversational install flow
docs/McpServer-Skills/MCP/TRONMCPServer/OfficialServerAccess.md Modified Same treatment as SUN MCP
docs/McpServer-Skills/MCP/TRONMCPServer/QuickStart.md Modified Same treatment as SUN MCP
docs/McpServer-Skills/SKILLS/QuickStart.md Modified Adds conversational install; retains CLI and interactive methods
i18n/zh-Hans/... (matching files) Modified Chinese counterparts of all the above

Purpose: Promotes AI-driven installation (the user pastes a prompt into their AI client and the AI runs npx add-mcp / npx skills add) as the primary entry point, demoting the direct CLI approach to Method 2.


3. Agent-Wallet QuickStart Restructured

File Change Type Description
docs/Agent-Wallet/QuickStart.md Modified Adds Method 1 (conversational wallet creation) before existing CLI flow
i18n/zh-Hans/.../Agent-Wallet/QuickStart.md Modified Chinese counterpart

Purpose: The original three-step CLI-only wallet setup is now "Method 2: Command-Line Setup." A new "Method 1: Conversational Setup" is prepended for users who already have BANK OF AI Skills installed.


4. Sidebar & Navigation

File Change Type Description
sidebars.js Modified Adds BANK-OF-AI category (Intro + QuickStart) at the top
i18n/zh-Hans/.../sidebars.js Modified Chinese sidebar counterpart
i18n/zh-Hans/.../current.json Modified Adds sidebar label i18n key for BANK OF AI

Purpose: Registers the new section in the doc navigation.


5. Assets & Version

File Change Type Description
docs/McpServer-Skills/SKILLS/image/conversational-install.png Added Screenshot of conversational install dialog (EN)
i18n/zh-Hans/.../SKILLS/image/conversational-install.png Added Screenshot of conversational install dialog (CN)
package.json Modified Version bump: 1.2.81.2.9

Detailed Findings


Major

[MJ-01] Realistic Wallet Password Embedded in Documentation Without Clear "Sample Only" Disclaimer

Property Value
Severity Major
Category Documentation / Security
File docs/Agent-Wallet/QuickStart.md : Lines 68–77; i18n/zh-Hans/docusaurus-plugin-content-docs/current/Agent-Wallet/QuickStart.md : Lines 68–77

Description

The "Method 1: Conversational Setup" section embeds a sample AI output block that contains a realistic-looking wallet password:

🔐 Wallet password

$mU80m9fLYB5

While this is meant to illustrate example output, there is no inline label (e.g., "example password — yours will differ") on or near the password value itself. The surrounding caution admonition is placed after the code block and refers to backing up "your" password, which could be read as referring to the $mU80m9fLYB5 value shown above. Users who skim the page may copy this value, believe it is pre-configured for them, and attempt to use it. Additionally, sharing even a plausible example password in public documentation normalises the practice of showing passwords in plaintext, counter to the strong security messaging elsewhere on the page.

Code

```text
🔐 Wallet password

$mU80m9fLYB5

**Recommendation**

Replace the literal example password with an obviously non-real placeholder and add an inline note, for example:

```markdown
```text
🔐 Wallet password

<your-auto-generated-password>    ← shown only once; save it now!

Or use a clearly fabricated value like `xxXXxxxxXXxx` alongside an explicit inline comment. Move or duplicate the backup caution admonition directly above the password value so users cannot miss it.

---

#### [MJ-02] Removal of "Restart AI Client" Troubleshooting Step May Leave Users Stranded

| Property | Value |
|----------|-------|
| **Severity** | Major |
| **Category** | Documentation / Correctness |
| **File** | `docs/McpServer-Skills/MCP/SUNMCPServer/OfficialServerAccess.md` : Lines 157–159; `docs/McpServer-Skills/MCP/TRONMCPServer/OfficialServerAccess.md` : (equivalent section); Chinese counterparts of both |

**Description**

This PR removes step 3 from the troubleshooting checklist in both the SUN and TRON MCP Server "Official Server Access" pages:

```diff
-3. AI client has been fully quit and restarted (not just refreshed)

It also removes "restart" language from the Quick Start "Restart and Test" sections (renamed to "Test It Out"), dropping this instruction entirely:

-After completing the configuration, restart your MCP client.
-After saving the configuration, **completely quit and restart** your AI client.

The rationale for these removals is that the new conversational install path (Method 1) does not require a restart. However, Methods 2 and 3 (CLI and interactive) write to the MCP config file on disk — most MCP-supporting AI clients (Claude Desktop, OpenClaw, Cursor) do require a restart to pick up config-file changes. By removing the restart instruction from both the quick-start and troubleshooting sections without scoping it to the conversational install path, users following the CLI methods will be confused when their installed server does not appear.

Code

-3. AI client has been fully quit and restarted (not just refreshed)

and

-## Restart and Test
-After completing the configuration, restart your MCP client. Then try the following query in a conversation:
+## Test It Out
+Try the following query in a conversation:

Recommendation

Re-add the restart note scoped to Methods 2 and 3:

## Test It Out

> **Method 1 (conversational install):** The AI handles reload automatically — no restart needed.
> **Methods 2 & 3 (CLI / interactive):** After installation completes, **completely quit and restart** your AI client so it picks up the updated MCP config.

Then try the following query…

Restore troubleshooting step 3 (or annotate it as applicable only to CLI/interactive install):

3. (CLI/interactive install only) AI client has been fully quit and restarted — not just refreshed.

Minor

[MN-01] Incorrect Ecosystem Install Command for Etherscan

Property Value
Severity Minor
Category Correctness / Documentation
File docs/BANK-OF-AI/Intro.md : Line 350; i18n/zh-Hans/.../BANK-OF-AI/Intro.md : equivalent line

Description

The Ecosystem Layer table lists Etherscan's install command as:

npx skills add https://docs.etherscan.io

https://docs.etherscan.io is Etherscan's documentation site, not a skills repository. This command will fail because npx skills add expects a GitHub repo path or a valid skills package URL, not a docs website URL. The correct reference, if an official Etherscan skill repository exists, should point to that repo (e.g. npx skills add etherscan/skills or similar).

Recommendation

Verify the correct install command with the Etherscan team and update the table. If an official skills package does not yet exist, replace the entry with (coming soon) or remove it until confirmed.


[MN-02] Full Real-Looking Wallet Addresses Embedded in EN Agent-Wallet QuickStart

Property Value
Severity Minor
Category Documentation / Privacy
File docs/Agent-Wallet/QuickStart.md : Lines 62–65

Description

The English Agent-Wallet QuickStart displays full wallet addresses in the example output:

| EVM     | 0x1339Df9ac21E494b39Be47d012A3f33fb9188366          |
| TRON    | TBisApdFay75x3FXNWiG8UE75KzhnFLceY                  |

These are valid-format blockchain addresses. If they belong to a real wallet (e.g., a developer's wallet), publishing them in public documentation exposes that wallet to monitoring and potential social engineering. The corresponding Chinese file and the BANK-OF-AI/QuickStart.md both use truncated addresses (0x7858...4bCA, TLwYeH...q8usz), creating an inconsistency and suggesting the EN file was not updated to match.

Recommendation

Replace the full addresses with truncated, clearly illustrative forms consistent with the other pages:

| EVM  | `0x1339...8366` |
| TRON | `TBisA...LceY`  |

[MN-03] Inconsistency: "Conversational Install" for SKILLS Uses Shorthand Repo Reference

Property Value
Severity Minor
Category Correctness / Documentation
File docs/McpServer-Skills/SKILLS/QuickStart.md : Lines 1057–1058; docs/BANK-OF-AI/QuickStart.md : Line 446

Description

The conversational install prompt for SKILLS uses the shorthand:

Run npx skills add BofAI/skills to install all BANK OF AI skills.

While the CLI Method 2 on the same page uses the full URL:

npx skills add https://github.com/BofAI/skills -y -g

If the skills CLI does not support the owner/repo shorthand (i.e., it does not resolve BofAI/skills against GitHub automatically), the conversational install will fail silently or with an unhelpful error. This is not verified in the diff and creates a discrepancy users may encounter.

Recommendation

Validate that npx skills add BofAI/skills resolves correctly, and document this behavior. If the shorthand is not guaranteed to work across all environments, use the full URL in the conversational prompt for consistency:

Run npx skills add https://github.com/BofAI/skills to install all BANK OF AI Skills.

[MN-04] collapsed: false on New Sidebar Category May Clutter Navigation

Property Value
Severity Minor
Category Code Quality / UX
File sidebars.js : Lines 4–12; i18n/zh-Hans/.../sidebars.js : Lines 4–12

Description

The new BANK-OF-AI sidebar category is added with collapsed: false:

{
  type: 'category',
  label: 'BANK OF AI',
  collapsed: false,
  items: [
    'BANK-OF-AI/Intro',
    'BANK-OF-AI/QuickStart',
  ],
},

This forces the category to be permanently expanded for all visitors, regardless of whether they are interested in this section. No other category in the existing sidebars uses collapsed: false. As the docs grow and more sections are added, having one category pinned open can make the sidebar feel unbalanced.

Recommendation

Remove collapsed: false (or change to collapsed: true) to be consistent with the rest of the sidebar configuration. If the intent is to highlight the new section, consider using Docusaurus's customProps or a doc badge instead.


[MN-05] "Telegram Bot" Listed as Shell-Command-Capable AI Client Without Qualification

Property Value
Severity Minor
Category Documentation / Accuracy
File docs/McpServer-Skills/SKILLS/QuickStart.md : Line 1045; docs/McpServer-Skills/MCP/SUNMCPServer/OfficialServerAccess.md : Line 780; docs/McpServer-Skills/MCP/TRONMCPServer/OfficialServerAccess.md : Line 911; docs/Agent-Wallet/QuickStart.md : Line 26; and Chinese counterparts

Description

Throughout the new content, "a Telegram bot" is listed alongside OpenClaw, Claude Code, and Cursor as an AI agent that supports running shell commands:

(OpenClaw, a Telegram bot, web chat, Claude Code, Cursor, etc.)

Standard Telegram bots cannot execute shell commands — they operate within Telegram's bot API and do not have access to the host machine's shell. This is presumably a reference to a specific BofAI-built Telegram bot integration that exposes shell execution, but this is not clarified anywhere in the text. Readers with a generic Telegram bot will attempt the conversational install and fail.

Recommendation

Replace the vague "a Telegram bot" with a specific reference, e.g., "the BANK OF AI Telegram bot," and link to its setup page. Alternatively, add a footnote clarifying that only AI clients with shell execution capability are supported.


Suggestions

[S-01] SVG Architecture Diagram Lacks Accessibility Attributes

File: docs/BANK-OF-AI/image/bankofai-architecture.svg (and Chinese counterpart)

Description: The architecture SVG diagram contains no <title>, role="img", or aria-labelledby attributes. Screen readers will either skip or poorly announce the diagram. The text content embedded in the SVG is not selectable in some renderers.

Suggestion: Add SVG accessibility metadata:

<svgrole="img" aria-labelledby="svgTitle svgDesc">
  <title id="svgTitle">BANK OF AI Architecture — How Layers Work Together</title>
  <desc id="svgDesc">Flow diagram showing a TRC20 transfer moving through: User → AI Agent → Skills (trc20-token-toolkit) → TRON MCP Server → Agent-Wallet → TRON Blockchain, with a dashed result-feedback path returning to the AI Agent.</desc>
  …

[S-02] Example AI Output in SKILLS QuickStart Uses an OpenClaw-Specific Path

File: docs/McpServer-Skills/SKILLS/QuickStart.md : Lines 1085, 1103

Description: The example AI output hardcodes an OpenClaw-specific installation path:

Location: ~/.openclaw/workspace/.agents/skills/

While OpenClaw is one supported client, readers using Claude Code, Cursor, or other clients will see a path that does not match their environment, which may cause confusion about whether the install succeeded.

Suggestion: Add a parenthetical clarifying the path is client-specific:

Location: ~/.openclaw/workspace/.agents/skills/  ← path varies by AI client

[S-03] BANK-OF-AI/Intro.md BSC MCP Server Install Command Uses Standalone npx Form

File: docs/BANK-OF-AI/Intro.md : Ecosystem Layer table

Description: The BSC MCP Server is listed without an install command in the Ecosystem table (it only says "BSC MCP Server — atomic on-chain operations for BNB Chain") in the product matrix, but the Ecosystem section shows TRON and SUN MCP Servers with npx -y @bankofai/mcp-server-tron style commands while the BSC entry is absent from the ecosystem table entirely. Users who want BSC support have no install path shown at the main overview level.

Suggestion: Either add the BSC MCP Server to the Ecosystem Layer table with its install command, or add a note like (install guide coming soon) so users know to refer to the dedicated BSC MCP docs.


[S-04] Version Bump in package.json Not Reflected in a CHANGELOG

File: package.json : Line 4

Description: The version is bumped from 1.2.8 to 1.2.9 but no CHANGELOG.md or release notes entry is updated or created for this change. For a published documentation package, it is good practice to log what changed between versions.

Suggestion: Add or update a CHANGELOG.md entry summarising the changes in v1.2.9 (new BANK OF AI section, conversational install across all guides, version bump), or document the release notes in the PR description.


Positive Observations

Area Observation
Bilingual parity Every English content change has a faithful, well-translated Chinese counterpart. Terminology is consistent throughout both locales.
Security messaging Password backup warnings (:::caution, :::danger) are used consistently and prominently wherever a wallet password is involved. The "never paste into email/chat/screenshots" warning is explicitly stated.
Progressive disclosure The new three-method installation pattern (Conversational → CLI → Interactive) cleanly tiered by user expertise level is well-structured and follows good UX documentation practice.
Admonition usage Docusaurus admonitions (:::tip, :::caution, :::danger, :::info, :::note) are used appropriately throughout — tips for prerequisites, cautions for irreversible actions, notes for edge-case expectations.
Architecture diagram The SVG architecture diagram is self-contained (no external dependencies), uses a consistent design language, and clearly illustrates the data flow for a real-world operation.
Example dialogs The <details>-collapsed example AI outputs give users clear expectations of what success looks like without cluttering the main reading path.
Internal cross-linking New pages cross-link to related sections (CLI Reference, MCP Server deployment guides, x402, 8004, LLM Service) thoroughly, reducing documentation dead ends.

Checklist Results

Category Items Checked Pass Fail N/A Notes
Correctness 4 2 2 2 Incorrect Etherscan command; missing restart scoping
Security 5 3 2 0 Example password lacks clear placeholder; real addresses in docs
Performance 3 3 0 0 No performance concerns (docs only)
Code Quality 5 3 2 0 Sidebar collapse inconsistency; shorthand vs full URL inconsistency
Testing 2 0 0 2 No automated tests apply to documentation
Documentation 6 4 2 0 Telegram bot unqualified; BSC install path missing from overview
Compatibility 3 3 0 0 i18n parity maintained; sidebar structure valid
Observability 2 2 0 0 N/A for documentation

Disclaimer

This is an automated code review. It supplements but does not replace human review. The reviewer analyzed only the diff between the specified branches. Runtime behavior, integration testing, and deployment impact are not covered. For documentation PRs, "runtime" concerns include link validity, image rendering, and Docusaurus build correctness — these should be verified via a preview deployment (e.g., npm run build or a staging site) before merge.


Report generated by Code Review Skill v1.0.0
Date: 2026-04-16

@github-actions
Copy link
Copy Markdown

Code Review Report

Project: @x402-tron/docs (BANK OF AI Documentation Site)
PR: main -> update-mcp-server
Review Date: 2026-04-16
Reviewer: AI Code Reviewer (Code Review Skill v1.0.0)


PR Overview

Branch Information

Property Value
From Branch main
To Branch update-mcp-server
Commits 21
Files Changed 24
Lines Added +1831
Lines Removed -97

Commit History

Hash Message
a72b661 add bankofai
2248ef7 add bankofai
86022be add bankofai
0134a17 Add general introduction and quick installation.
a936d87 Merge pull request #42 from BofAI/ai-bankofai-patch-1
d286300 Merge branch 'main' into ai-bankofai-patch-1
919cda6 change version
0991037 update name
26c666e Update Claude Code x BANK OF AI API Configuration Guide.md
01d6587 Create Claude Code x BANK OF AI API Configuration Guide.md
aa2681e Rename Claude Code x BANK OF AI API Configuration Guide
a85f6d8 Create Claude Code x BANK OF AI API Configuration Guide
a932d7e Merge pull request #41 from BofAI/update-mcp-server
21d856e Update introduction.md
90d5caa Update quick-start.md
a9f04aa Update introduction.md
d035af7 Update introduction.md
3e5caac Update introduction.md
283d807 Update introduction.md
463dd62 Update quick-start.md
620f06b Update quick-start.md

Review Summary

Verdict

Verdict: Request Changes

Findings at a Glance

Critical Major Minor Suggestion
Count 0 3 4 3

Summary

This PR is a large documentation-only update for the BANK OF AI documentation site (Docusaurus). The central contribution is the addition of a new top-level "BANK OF AI" section with two new pages — an architecture introduction (Intro.md) and a quick-start guide (QuickStart.md) — in both the English (docs/) and Chinese (i18n/zh-Hans/) content trees. Alongside this, several existing pages are significantly expanded: Agent-Wallet/QuickStart.md gains a new Method 1 (conversational setup), McpServer-Skills/SKILLS/QuickStart.md gains two new installation methods, and both TRON and SUN MCP Server quick-start and official-access pages are updated with conversational-install instructions. The sidebars.js files and package.json (version bump to 1.2.9) are also updated.

The overall documentation quality is good: clear step-by-step structure, appropriate Docusaurus callouts (:::tip, :::caution, :::danger), and comprehensive coverage of installation paths. Cross-references between new pages are internally consistent. The Chinese (zh-Hans) translations are provided for all new content.

However, there are three major issues requiring attention before merge: a factual inconsistency in skill counts between installation methods (11 vs 8), a misleading quote-style instruction that contradicts the accompanying code sample, and an exposed example password in a "How it works" output block that could be mistaken for a real credential. Several minor issues also exist, including a Mac-specific terminal command embedded in documentation that should work cross-platform, and a pre-existing omission in the zh-Hans sidebar (missing SKILLS/QuickStart entry) that this PR does not fix despite updating the surrounding content.


Change Summary

New BANK OF AI Section

File Change Type Description
docs/BANK-OF-AI/Intro.md Added Full architecture introduction covering all 4 product layers
docs/BANK-OF-AI/QuickStart.md Added Two-step end-to-end quick-start guide
docs/BANK-OF-AI/image/bankofai-architecture.svg Added Architecture diagram SVG
i18n/zh-Hans/docusaurus-plugin-content-docs/current/BANK-OF-AI/Intro.md Added Chinese translation of Intro
i18n/zh-Hans/docusaurus-plugin-content-docs/current/BANK-OF-AI/QuickStart.md Added Chinese translation of QuickStart
i18n/zh-Hans/docusaurus-plugin-content-docs/current/BANK-OF-AI/image/bankofai-architecture.svg Added Chinese-locale copy of architecture diagram

Purpose: Introduces a new top-level product overview and entry point for the BANK OF AI ecosystem docs.


Agent Wallet QuickStart Expansion

File Change Type Description
docs/Agent-Wallet/QuickStart.md Modified Added Method 1 (conversational setup); original CLI flow becomes Method 2
i18n/zh-Hans/.../Agent-Wallet/QuickStart.md Modified Chinese translation of Method 1 addition

Purpose: Provides a no-terminal "conversational" setup path for users who have already installed the BANK OF AI skills suite.


SKILLS QuickStart Expansion

File Change Type Description
docs/McpServer-Skills/SKILLS/QuickStart.md Modified Added Method 1 (conversational install) and renamed existing methods to Method 2 and Method 3
i18n/zh-Hans/.../McpServer-Skills/SKILLS/QuickStart.md Modified Chinese translation of new methods

Purpose: Mirrors the conversational-install approach used across MCP Server pages.


MCP Server Quick-Start Updates

File Change Type Description
docs/McpServer-Skills/MCP/TRONMCPServer/QuickStart.md Modified Replaced manual JSON config with conversational install via npx add-mcp
docs/McpServer-Skills/MCP/TRONMCPServer/OfficialServerAccess.md Modified Added three-method install section
docs/McpServer-Skills/MCP/SUNMCPServer/QuickStart.md Modified Replaced manual JSON config with conversational install
docs/McpServer-Skills/MCP/SUNMCPServer/OfficialServerAccess.md Modified Added three-method install section
i18n/zh-Hans/... (4 mirror files) Modified Chinese translations of above

Purpose: Standardises all MCP Server installation guidance around the new npx add-mcp conversational workflow.


Navigation and Version

File Change Type Description
sidebars.js Modified Adds BANK-OF-AI category at the top of the sidebar
i18n/zh-Hans/.../sidebars.js Modified Same addition for Chinese locale
i18n/zh-Hans/.../current.json Modified Adds i18n label for new BANK OF AI sidebar category
package.json Modified Version bump 1.2.8 → 1.2.9

Purpose: Wires new pages into site navigation and records the documentation version increment.


Detailed Findings

Major

[M-01] Skill Count Inconsistency: "11 skills" vs "8 skills" in Same Page

Property Value
Severity Major
Category Documentation Correctness
File docs/McpServer-Skills/SKILLS/QuickStart.md : Lines 32, 47, 53 vs Lines 143–203

Description

Method 1 (Conversational Install) and Method 2 (Quick Auto-Install) consistently state that "11 BANK OF AI skills" are installed. However, Method 3 (Interactive Install) shows terminal output reporting "Found 8 skills" and "Installed 8 skills". These are on the same documentation page. A reader comparing options will see contradictory numbers and cannot determine the correct count. The table in Method 1 lists 11 skills (agent-wallet, bankofai-guide, multi-sig-account-permissions, recharge-skill, sunperp-perpetual-futures-trading, sunswap-dex-trading, trc20-token-toolkit, tronscan-data-lookup, trx-staking-sr-voting, usdd-just-protocol, x402-payment), while the interactive example lists only 8 (omitting bankofai-guide, trx-staking-sr-voting, and usdd-just-protocol).

Code

# Method 1 (line 47)
✅ 11 BANK OF AI skills installed!

# Method 3 (line 143)
◇  Found 8 skills
│
◇  Select skills to install (space to toggle)
│  agent-wallet, Multi-Sig & Account Permissions, recharge-skill,
│  SunPerp Perpetual Futures Trading, SunSwap DEX Trading,
│  TRC20 Token Toolkit, TronScan Data Lookup, x402-payment

Recommendation

Reconcile the skill count across all three methods. If the repository now contains 11 skills, update the Method 3 example output to reflect the current state. If 8 is correct, update Methods 1 and 2. The same discrepancy exists in the zh-Hans translation and must be fixed there too.


[M-02] Contradictory Quote-Style Instruction in Private Key Option

Property Value
Severity Major
Category Documentation Correctness
File docs/McpServer-Skills/SKILLS/QuickStart.md : Lines 277–281

Description

In Option 2 (Paste Your Private Key Directly), the code block correctly uses single quotes around the private key value — which is the safe shell practice for values that may contain special characters such as $. However, the immediately following inline warning reads: "⚠️ Important: Don't forget the double quotes on both sides!" This is factually wrong and contradicts the code example. A user following the text instruction would use double quotes, causing shell variable expansion to silently corrupt any private key containing $ or backtick characters. The Agent-Wallet QuickStart (Method 2, Step 2.1) correctly explains this single-quote/double-quote distinction with a clear caution block, but the SKILLS page gets it backwards.

Code

export TRON_PRIVATE_KEY='your_real_or_testnet_private_key'
⚠️ Important: Don't forget the double quotes on both sides!

Recommendation

Change the inline warning to: "⚠️ Important: Keep the single quotes on both sides — single quotes prevent the shell from expanding special characters in your private key." This aligns with the correct guidance on the Agent-Wallet page and prevents a real user error.


[M-03] Example Output Contains a Realistic-Looking Password Value

Property Value
Severity Major
Category Security / Documentation
File docs/Agent-Wallet/QuickStart.md : Lines 44–71

Description

The "When done, you'll see output like this:" code block in Method 1 (Conversational Setup) shows an actual-looking generated password: $mU80m9fLYB5. Unlike other placeholder examples in this PR (e.g. <your-unique-password-will-appear-here> on line 154, or 0x7858...4bCA and TLwYeH...q8usz in BANK-OF-AI/QuickStart.md), this value looks like a real credential. It also contains a leading $ which will cause silent expansion if a user copy-pastes it into double-quoted contexts. While the value itself is not an actual secret, realistic-looking passwords in public documentation cause two problems: (1) users may mistakenly believe this is their actual wallet password and not create their own; (2) if ever indexed and a user happens to have this password set, it becomes a known value. The BANK-OF-AI/QuickStart.md handles this better with a clearly bracketed placeholder.

Code

🔐 Wallet password

$mU80m9fLYB5

Recommendation

Replace the example password with a clearly bracketed placeholder consistent with the rest of the documentation, for example:

🔐 Wallet password

<your-generated-password-will-appear-here>

Minor

[m-01] zh-Hans Sidebar Missing SKILLS/QuickStart Entry

Property Value
Severity Minor
Category Documentation Maintainability
File i18n/zh-Hans/docusaurus-plugin-content-docs/current/sidebars.js : SKILLS section

Description

The English sidebars.js includes 'McpServer-Skills/SKILLS/QuickStart' in the SKILLS navigation items. The zh-Hans sidebars.js does not include this entry in the SKILLS section (pre-existing omission), and this PR does not correct it despite making other zh-Hans sidebar additions. Chinese locale users will not see a SKILLS QuickStart link in their sidebar navigation, even though the translated file i18n/zh-Hans/.../McpServer-Skills/SKILLS/QuickStart.md exists and was updated in this PR.

Code

// English sidebars.js — includes QuickStart
items: [
  'McpServer-Skills/SKILLS/Intro',
  'McpServer-Skills/SKILLS/QuickStart',   // <-- present
  'McpServer-Skills/SKILLS/BANKOFAISkill',
  'McpServer-Skills/SKILLS/Faq',
],

// zh-Hans sidebars.js — missing QuickStart
items: [
  'McpServer-Skills/SKILLS/Intro',
  // 'McpServer-Skills/SKILLS/QuickStart'  <-- absent
  'McpServer-Skills/SKILLS/BANKOFAISkill',
  'McpServer-Skills/SKILLS/Faq',
],

Recommendation

Add 'McpServer-Skills/SKILLS/QuickStart' to the SKILLS items array in i18n/zh-Hans/docusaurus-plugin-content-docs/current/sidebars.js.


[m-02] Mac-Specific Terminal Command in Cross-Platform Private Key Documentation

Property Value
Severity Minor
Category Documentation Correctness
File docs/McpServer-Skills/SKILLS/QuickStart.md : Lines 275–283

Description

Option 2 (Paste Your Private Key Directly) instructs the user: "In Terminal (the black window), type open -e ~/.zshrc and press Enter." The open -e command is macOS-specific and will fail on Linux. The section offers no platform-specific guidance. This contrasts with the Agent-Wallet QuickStart (Method 2, Step 2.1), which correctly uses <Tabs> to present Mac-specific (open -e ~/.zshrc) and Linux-specific (nano ~/.bashrc) instructions separately. Furthermore, .zshrc is the default shell config on macOS, but Linux users (who default to Bash) would need .bashrc.

Recommendation

Either apply the same tab-based, platform-specific pattern used in docs/Agent-Wallet/QuickStart.md, or at minimum add a parenthetical note: "(Mac users: open -e ~/.zshrc; Linux users: nano ~/.bashrc)".


[m-03] Unclear Commit Message History

Property Value
Severity Minor
Category Code Quality / Maintainability
File Git history

Description

Three consecutive commits are all titled "add bankofai" (a72b661, 2248ef7, 86022be). Commit messages provide no indication of what changed in each, making the history difficult to bisect or review granularly. This is especially important given the PR modifies 24 files and these three commits appear to contain the bulk of the new BANK-OF-AI section content.

Recommendation

Squash or reword the three "add bankofai" commits into descriptive messages before merging, e.g.:

  • "Add BANK-OF-AI Intro and QuickStart pages (en + zh-Hans)"
  • "Update SKILLS QuickStart with conversational install method"

[m-04] package.json name Field Mismatch with Project Content

Property Value
Severity Minor
Category Documentation Maintainability
File package.json : Line 2

Description

The package.json name field is "@x402-tron/docs" and the description is "x402-tron documentation". This PR significantly repositions the documentation site as BANK OF AI product documentation, not x402-tron-specific documentation. The package name and description no longer reflect the actual scope of the documentation. While this is not a build-breaking issue, it can cause confusion for developers and in generated metadata.

Recommendation

Update name and description in package.json to reflect the actual project scope, for example:

"name": "@bankofai/docs",
"description": "BANK OF AI documentation site"

Suggestions

[S-01] BANK-OF-AI Intro Uses Inline Emojis in Headings

Property Value
Severity Suggestion
Category Code Quality
File docs/BANK-OF-AI/Intro.md

Description

Section headings use emojis (e.g. ## 🧠 Model Layer, ## 🛤️ Protocol Layer). While visually appealing in rendered form, emoji in headings can cause issues with: (a) auto-generated anchor links that include the emoji, making fragment URLs fragile across platforms; (b) screen reader accessibility; (c) search indexing. Other documentation pages in this repo do not use emojis in headings.

Recommendation

Consider moving emojis to the body text or a lead paragraph rather than the heading itself, or ensure Docusaurus anchor generation handles emoji consistently.


[S-02] Repetitive Node.js Prerequisites Across Multiple Pages

Property Value
Severity Suggestion
Category Code Quality / DRY
File Multiple changed files

Description

The Node.js prerequisite block is repeated nearly verbatim across multiple new/updated pages: SKILLS/QuickStart.md, TRONMCPServer/QuickStart.md, TRONMCPServer/OfficialServerAccess.md, SUNMCPServer/QuickStart.md, and SUNMCPServer/OfficialServerAccess.md. Each uses the same wording: "Node.js is required on the machine where the AI Agent runs (the Agent uses npx under the hood)..."

Recommendation

Extract this into a shared Docusaurus snippet (partial) or a dedicated prerequisites page linked from each page. This reduces maintenance burden when the minimum Node.js version changes.


[S-03] Example Wallet Addresses Are Real-Looking Ethereum/TRON Addresses

Property Value
Severity Suggestion
Category Documentation
File docs/Agent-Wallet/QuickStart.md : Lines 57–58

Description

The example wallet output in Method 1 shows 0x1339Df9ac21E494b39Be47d012A3f33fb9188366 (EVM) and TBisApdFay75x3FXNWiG8UE75KzhnFLceY (TRON) as sample addresses. These appear to be real generated addresses from a test wallet. While using real addresses in documentation is common practice, using clearly shortened or annotated addresses (e.g. 0x1339...8366) as done in BANK-OF-AI/QuickStart.md (0x7858...4bCA) is a safer convention because it unambiguously signals "this is an example" and does not associate real on-chain addresses with documentation tooling.

Recommendation

Replace the full sample addresses with truncated, clearly example-style values such as 0x1339...8366 and TBis...ceY, consistent with the BANK-OF-AI/QuickStart.md pattern.


Positive Observations

Area Observation
Content structure Consistent use of Docusaurus callout types (:::tip, :::caution, :::danger) with appropriate severity mapping throughout all new content
Cross-references All internal links from new BANK-OF-AI pages to existing docs (Agent-Wallet, MCP Server, Skills, x402, 8004, llmservice) are correct and bidirectional
Security guidance The Agent-Wallet QuickStart includes strong, explicit warnings about password backup, master password risks, and the danger of using double quotes vs single quotes for passwords — materially important for a cryptocurrency wallet tool
Translation parity New English content is fully mirrored in zh-Hans translations including images, maintaining complete bilingual documentation coverage
Installation UX The new three-method install pattern (Conversational / Quick Auto-Install / Interactive) is consistent across all updated pages and represents a clear improvement in accessibility for non-technical users
Version management package.json version bump is correctly included in the PR
Sidebar navigation New BANK-OF-AI section is properly registered in both sidebars.js and i18n/zh-Hans/.../sidebars.js, with correct i18n label added to current.json

Checklist Results

Category Items Checked Pass Fail N/A Notes
Correctness 6 4 2 0 Skill count inconsistency (M-01); quote instruction contradiction (M-02)
Security 4 3 1 0 Realistic example password value (M-03)
Performance 3 3 0 0 Static documentation site — no runtime performance concerns
Code Quality 5 3 2 0 Commit messages (m-03); package.json name (m-04); repeated Node.js prereqs (S-02)
Testing 2 2 0 0 Documentation-only PR; no code logic to test
Documentation 5 4 1 0 zh-Hans sidebar missing SKILLS/QuickStart (m-01)
Compatibility 3 2 1 0 Mac-only terminal command in cross-platform section (m-02)
Observability 2 2 0 0 N/A for documentation project

Disclaimer

This is an automated code review. It supplements but does not replace human review.


Report generated by Code Review Skill v1.0.0
Date: 2026-04-16

@github-actions
Copy link
Copy Markdown

Audit Report: PR update-mcp-servermain

Date: 2026-04-16
Reviewer: Claude Sonnet 4.6 (Automated Code Review)
Repository: /app/reports/docs/pr/20260416-120533/code


1. PR Overview

Property Value
From Branch update-mcp-server (remote: origin/update-mcp-server)
To Branch main (remote: origin/main)
Commits 21 commits
Files Changed 24 files
Lines Added ~1,633
Lines Removed ~101
Binary Assets Added 2 PNG images, 2 SVG images

Commit Range Summary

The commits span from foundational MCP server quick-start improvements (620f06b) through iterative introduction updates, culminating in the addition of a new BANK-OF-AI documentation section (c7c6683).


2. Change Summary

Group A: New BANK-OF-AI Documentation Section (New Files)

  • docs/BANK-OF-AI/Intro.md — 272-line introduction to the BANK OF AI platform (4-layer architecture overview, product matrix, ecosystem table)
  • docs/BANK-OF-AI/QuickStart.md — 231-line end-to-end quick-start guide covering 2-step onboarding
  • docs/BANK-OF-AI/image/bankofai-architecture.svg — Architecture diagram SVG

Group B: Navigation & Sidebar Updates (Modified)

  • sidebars.js — Adds BANK OF AI as the first sidebar category with Intro and QuickStart items
  • i18n/zh-Hans/docusaurus-plugin-content-docs/current/sidebars.js — Mirrors the sidebar update for Chinese locale
  • i18n/zh-Hans/docusaurus-plugin-content-docs/current.json — Adds sidebar category label entry for BANK OF AI
  • package.json — Version bump from 1.2.81.2.9

Group C: MCP Server Documentation Revamp (Modified)

  • docs/McpServer-Skills/MCP/SUNMCPServer/OfficialServerAccess.md — Adds "Method 1: Conversational Install" and renames existing methods; removes "restart AI client" step
  • docs/McpServer-Skills/MCP/SUNMCPServer/QuickStart.md — Rewrites install section to conversational-first approach; removes restart step
  • docs/McpServer-Skills/MCP/TRONMCPServer/OfficialServerAccess.md — Same pattern as SUN MCP
  • docs/McpServer-Skills/MCP/TRONMCPServer/QuickStart.md — Same pattern as SUN MCP; removes restart step

Group D: SKILLS Documentation Revamp (Modified)

  • docs/McpServer-Skills/SKILLS/QuickStart.md — Adds Node.js prerequisite tip; converts to 3-method install structure (Conversational / Auto-CLI / Interactive)
  • docs/McpServer-Skills/SKILLS/image/conversational-install.png — New screenshot for conversational install

Group E: Agent-Wallet Quick Start Update (Modified)

  • docs/Agent-Wallet/QuickStart.md — Adds "Method 1: Conversational Setup" as primary path; renames existing CLI steps as "Method 2"; generalizes "OpenClaw" references to "your AI agent"

Group F: i18n Mirrors (New + Modified)

All docs changes in Groups A–E are mirrored under i18n/zh-Hans/docusaurus-plugin-content-docs/current/ with Chinese translations.


3. Detailed Findings

Critical

No Critical findings identified.


Major

[M-01] Incorrect Install Command for Etherscan in Ecosystem Table (Major)

Property Value
Severity Major
Category Correctness / Documentation
File docs/BANK-OF-AI/Intro.md : Line 197

Description:
The ecosystem table lists npx skills add https://docs.etherscan.io as the install command for the Etherscan MCP Server/Skills. https://docs.etherscan.io is a documentation website URL, not a valid GitHub repository path or npm package name. Running this command would fail or install an unintended package. The same error is reproduced in the Chinese translation.

Code:

| **Etherscan** | Etherscan Official | Query / Tracking / Analytics, 60+ chains | `npx skills add https://docs.etherscan.io` |

Recommendation:
Replace with the correct GitHub repository path or npm package name for the Etherscan Skills package. For example:

| **Etherscan** | Etherscan Official | Query / Tracking / Analytics, 60+ chains | `npx skills add etherscan/etherscan-skills` |

Verify the correct install command from Etherscan's official documentation before merging.


[M-02] Removal of Restart Instructions May Leave Users Stuck (Major)

Property Value
Severity Major
Category Correctness / User Experience
File docs/McpServer-Skills/MCP/TRONMCPServer/QuickStart.md, docs/McpServer-Skills/MCP/SUNMCPServer/QuickStart.md, docs/McpServer-Skills/MCP/TRONMCPServer/OfficialServerAccess.md, docs/McpServer-Skills/MCP/SUNMCPServer/OfficialServerAccess.md

Description:
The PR removes all instructions to restart the AI client after MCP Server installation. For CLI-based installs (Methods 2 and 3 in the updated docs), MCP configuration is written to a file that the AI client reads only on startup. Without restarting, the newly installed MCP Server will not be visible or usable. The conversational install (Method 1) may handle this differently by triggering a reload, but no explanation is provided. The removal also deletes a troubleshooting checklist item ("AI client has been fully quit and restarted") that helped users diagnose connection failures.

Code (removed lines):

-After the command completes, restart your MCP client.
-Once installation is complete, restart your AI Agent, and you can start interacting...
-3. AI client has been fully quit and restarted (not just refreshed)

Recommendation:
Either:

  1. Re-add the restart instructions for Methods 2 and 3 (CLI-based), limiting the "no restart needed" claim to Method 1 (conversational), OR
  2. Explain clearly why a restart is no longer needed (e.g., the tool now hot-reloads the config). Without justification, this is a factual regression for CLI users.

[M-03] Inconsistent Install Commands Between BANK-OF-AI and SKILLS QuickStarts (Major)

Property Value
Severity Major
Category Correctness / Consistency
File docs/BANK-OF-AI/QuickStart.md : Lines 15–16 vs docs/McpServer-Skills/SKILLS/QuickStart.md : Lines 23–27

Description:
The BANK-OF-AI QuickStart instructs users (via the AI chat prompt) to install Skills into the Agent's own skills directory (no -g flag), while the SKILLS QuickStart Method 2 uses -y -g (global install). A user who follows the BANK-OF-AI QuickStart would have Skills only for that Agent, while a user following SKILLS QuickStart Method 2 would have a global install. This inconsistency is compounded by subtly different wordings in the two conversational prompts:

  • BANK-OF-AI: "Note: please install into this Agent's own skills directory."
  • SKILLS: "Note: Please install to the skill directory corresponding to the current Agent."

These instructions say similar things but may produce different AI behaviors depending on how the AI client interprets them.

Recommendation:
Align the two documents. Decide which install scope (global vs. agent-specific) is the recommended default and use a single canonical prompt text that both docs reference or quote identically.


Minor

[m-01] BANK OF AI Sidebar Category Label Not Translated in Chinese Locale (Minor)

Property Value
Severity Minor
Category Documentation / i18n
File i18n/zh-Hans/docusaurus-plugin-content-docs/current.json : Lines 6–9

Description:
The new sidebar category entry for BANK OF AI in the Chinese locale file has its message set to "BANK OF AI" (the English brand name), which is acceptable since it is a proper noun. However, all other categories in the same file have translated labels (e.g., "x402支付协议"). The brand name being untranslated is likely intentional but warrants confirmation.

Code:

"sidebar.docsSidebar.category.BANK OF AI": {
  "message": "BANK OF AI",
  "description": "The label for category BANK OF AI in sidebar docsSidebar"
},

Recommendation:
Confirm with stakeholders whether BANK OF AI should remain in English in the Chinese sidebar (acceptable for brand names), or if a Chinese equivalent (e.g., "BANK OF AI ——— AI银行") is preferred.


[m-02] Inconsistent Terminology: "BofAI" vs "bankofai" vs "BankOfAI" (Minor)

Property Value
Severity Minor
Category Code Quality / Consistency
File docs/BANK-OF-AI/Intro.md, docs/McpServer-Skills/SKILLS/QuickStart.md, docs/BANK-OF-AI/QuickStart.md

Description:
Three different capitalizations of the organization/brand name are used in install commands and references throughout the new documentation:

  • BofAI/skills (GitHub shorthand in conversational prompts)
  • https://github.com/BofAI/skills (full GitHub URL in CLI commands)
  • @bankofai/agent-wallet (npm package namespace)
  • bankofai-guide (skill name)

While BofAI as a GitHub org and bankofai as an npm namespace are technically different namespaces, inconsistent casing in user-facing docs can confuse readers.

Recommendation:
Add a brief note or ensure all references consistently use the correct name for each context (GitHub org vs npm package). This also applies to the displayed text where BANK OF AI, BankOfAI, and Bank of AI appear interchangeably in prose.


[m-03] Example Password in Shell Export Section May Mislead Users (Minor)

Property Value
Severity Minor
Category Documentation Clarity
File docs/Agent-Wallet/QuickStart.md : Lines 203–208

Description:
The documentation correctly warns about using single quotes vs double quotes for passwords containing special characters ($). The example uses P@ss$w0rd! to illustrate shell expansion dangers, but this looks like a placeholder "strong password" example that some users might actually copy and use verbatim as their real password.

Code:

# ✅ Correct — single quotes, password saved as-is
export AGENT_WALLET_PASSWORD='P@ss$w0rd!'

# ❌ Wrong — double quotes, $w0rd gets shell-expanded to empty string, password silently breaks
export AGENT_WALLET_PASSWORD="P@ss$w0rd!"  # actual value becomes "P@ss!"

Recommendation:
Use a placeholder format that clearly indicates this is illustrative, such as 'Your-Actual-P@ss$w0rd!' or replace the realistic-looking password with a clearer placeholder like '<your-password-here>' in both the correct and incorrect examples.


[m-04] "Quick Start" Link in Intro.md Skills Section Ambiguous (Minor)

Property Value
Severity Minor
Category Documentation / Link Accuracy
File docs/BANK-OF-AI/Intro.md : Line 149

Description:
In the Skills section of Intro.md, the "Learn more" line links to [Quick Start](./QuickStart.md), which resolves to docs/BANK-OF-AI/QuickStart.md (the BANK-OF-AI overall quick start). However, the natural expectation from a Skills section is a link to the Skills-specific quick start at docs/McpServer-Skills/SKILLS/QuickStart.md.

Code:

👉 Learn more: [Skills Introduction](../McpServer-Skills/SKILLS/Intro.md) · [Quick Start](./QuickStart.md)

Recommendation:
Clarify whether the Quick Start link is intentional (linking to the BANK-OF-AI general quick start as the recommended entry point) or should be changed to the Skills-specific quick start. If the former, rename the link text to [BANK OF AI Quick Start](./QuickStart.md) to avoid ambiguity.


Suggestions

[S-01] Conversational Install Prompt Wording Not Standardized (Suggestion)

Property Value
Severity Suggestion
Category Documentation Quality
File Multiple files

Description:
The "conversational install" prompts that users are asked to paste into their AI chat exist in multiple forms across the new docs. They are similar but not identical:

  • "Run npx skills add BofAI/skills to install every BANK OF AI Skill. After the install completes, run bankofai-guide to walk me through the next steps. Note: please install into this Agent's own skills directory." (BANK-OF-AI QuickStart)
  • "Run npx skills add BofAI/skills to install all BANK OF AI skills. After installation, use bankofai-guide to guide subsequent operations. Note: Please install to the skill directory corresponding to the current Agent." (SKILLS QuickStart)

Slight wording differences ("every" vs "all", "walk me through the next steps" vs "guide subsequent operations") could produce different AI behavior.

Recommendation:
Define a single canonical version of each prompt and reference it consistently, or use a shared include/snippet if the documentation framework supports it.


[S-02] Architecture SVG References Placeholder Transaction Hash (Suggestion)

Property Value
Severity Suggestion
Category Documentation Quality
File docs/BANK-OF-AI/Intro.md : Line 243

Description:
The architecture walkthrough example shows a placeholder transaction hash 0xabc123...def456 with a TronScan link that uses a generic https://tronscan.org URL without an actual transaction path. This is acceptable for illustration but may confuse readers who try to click the link expecting a real example.

Code:

> Tx hash: `0xabc123...def456` ([view on TronScan](https://tronscan.org))

Recommendation:
Either link to a real example transaction on TronScan, or make the placeholder nature explicit (e.g., [view on TronScan](https://tronscan.org/#/transaction/your-tx-hash)).


[S-03] Version Bump in package.json Without Changelog Entry (Suggestion)

Property Value
Severity Suggestion
Category Maintainability
File package.json : Line 3

Description:
The package version is bumped from 1.2.8 to 1.2.9 in this PR. If this project maintains a changelog or release notes, no corresponding entry is visible in the PR changes.

Recommendation:
Ensure a CHANGELOG.md entry (or equivalent) is updated to document the version bump and the changes it encompasses. If the project does not maintain a changelog, this is informational only.


4. Positive Observations

  1. Thorough security warnings on wallet password handling. The Agent-Wallet/QuickStart.md changes include clear :caution: blocks about master password backup, the consequences of loss ("no recovery mechanism, no support team, no backdoor"), and explicit guidance against sharing via chat/email/repos.

  2. Progressive disclosure structure. The three-method install pattern (Conversational → Auto-CLI → Interactive) is well-designed: beginners get the easiest path first, power users get full control without scrolling past irrelevant steps.

  3. Complete i18n mirroring. All English documentation changes are fully mirrored in Chinese (zh-Hans), including the new BANK-OF-AI section, images, and sidebar configuration — demonstrating good internationalization discipline.

  4. Comprehensive cross-referencing. The new BANK-OF-AI/Intro.md provides rich internal linking to every referenced sub-component (llmservice, x402, 8004, Agent-Wallet, Skills, MCP Server), and all cross-referenced files were confirmed to exist in the branch.

  5. Good prerequisite documentation. Node.js requirements are consistently surfaced as :::tip Prerequisite blocks at the top of each installation page, preventing the most common setup failure.

  6. Shell quoting security education. The Agent-Wallet/QuickStart.md actively educates users on the risk of using echo "..." >> .zshrc (shell history exposure) and recommends editing config files directly in an editor instead — practical and security-conscious advice.

  7. SVG architecture diagram. The addition of bankofai-architecture.svg (an inline SVG) avoids external image hosting dependencies and ensures the diagram renders reliably in all documentation environments.


5. Checklist Results

Category Check Status Notes
Correctness Logic errors in changed code Pass Documentation only; no application logic
Correctness All cross-referenced file links resolve Pass All ../path/file.md links verified to exist
Correctness Install commands accurate Fail Etherscan install URL is invalid (M-01)
Correctness Restart instructions accurate Fail Removed without justification for CLI installs (M-02)
Security No hardcoded secrets or credentials Pass No real keys/passwords in changed files
Security Sensitive data handling instructions Pass Explicit warnings about password storage
Security User input / injection risks N/A Documentation only
Performance N/A for documentation N/A
Code Quality Naming consistency Minor Issue BofAI/bankofai/BankOfAI inconsistency (m-02)
Code Quality Dead code / unused content Pass No dead content identified
Code Quality Internal consistency Fail Install command scope differs across docs (M-03)
Testing N/A for documentation N/A
Documentation New sections have appropriate cross-links Pass BANK-OF-AI section is well cross-linked
Documentation i18n coverage Pass Full Chinese translation provided
Documentation Sidebar navigation correct Pass Both English and zh-Hans sidebars updated
Documentation Version bump recorded Suggestion No changelog entry identified (S-03)

6. Review Verdict

Decision: Request Changes

Rationale

This PR delivers a well-structured, security-conscious documentation revamp with strong internationalization support. The content quality is high and the user experience improvements (conversational install as the primary path) are meaningful.

However, three Major findings must be addressed before merge:

  1. [M-01] — The Etherscan install command (npx skills add https://docs.etherscan.io) is factually incorrect and would fail if a user followed it. This is a documentation error that actively harms users.

  2. [M-02] — The removal of AI client restart instructions for CLI-based MCP Server installations removes necessary guidance without explanation. CLI users who install via Method 2 or Method 3 will find their MCP Server invisible until they restart, with no documentation telling them to do so.

  3. [M-03] — The inconsistency between the BANK-OF-AI QuickStart (agent-specific install) and the SKILLS QuickStart (global install) creates a confusing and potentially conflicting user experience.

Addressing these three issues would make this PR ready to merge. The Minor and Suggestion items are non-blocking but should be tracked for follow-up.

@github-actions
Copy link
Copy Markdown

Code Review Report

Project: @x402-tron/docs
PR: mainupdate-mcp-server
Review Date: 2026-04-16
Reviewer: AI Code Reviewer (Code Review Skill v1.0.0)


PR Overview

Branch Information

Property Value
From Branch main
To Branch update-mcp-server
Commits 23
Files Changed 28
Lines Added +1,833
Lines Removed -103

Commit History

Hash Message
c53bdfe add skills
c7c6683 add bankofai
a72b661 add bankofai
2248ef7 add bankofai
86022be add bankofai
0134a17 Add general introduction and quick installation
a936d87 Merge pull request #42 from BofAI/ai-bankofai-patch-1
d286300 Merge branch 'main' into ai-bankofai-patch-1
919cda6 change version
0991037 update name
26c666e Update Claude Code x BANK OF AI API Configuration Guide.md
(+ 12 more) earlier update-mcp-server commits

Review Summary

Verdict

Verdict: Request Changes

Two major issues require resolution before merging: the removal of restart instructions breaks setup for command-line users (and removes an item from the troubleshooting checklist that users rely on), and the conversational install method makes unverified auto-detection claims without any fallback guidance. Two minor issues — a skill-count discrepancy and a likely orphaned image — should also be corrected.

Findings at a Glance

Critical Major Minor Suggestion
Count 0 2 2 2

Summary

This PR is a pure documentation update — no application source code is changed. It introduces a new top-level "BANK OF AI" section (intro + quick-start + architecture diagram), adds documentation for two new skills (usdd-skill and trx-staking-skill), and refactors every existing MCP Server and Skills installation guide to add a new "Conversational Install" method as the recommended beginner path. All changes are mirrored in the i18n/zh-Hans/ locale. The version is bumped from 1.2.8 to 1.2.9.

Overall quality is high: the new content is well-structured, security guidance around wallet passwords is thorough and consistently applied, and the new architecture SVG diagram is a useful visual addition. The refactored installation guides correctly present three clearly-labelled methods with graduated complexity.

However, two significant accuracy problems were introduced during the refactor: (1) restart instructions were silently removed from command-line install methods where they are still required, and (2) the conversational install method claims the AI will "auto-detect which AI client is currently running" with no documentation of what happens if that detection fails. A minor skill-count inconsistency (the text says "Ten" while 11 are listed) and a potentially orphaned image file also need attention.


Change Summary

1 · New BANK OF AI Documentation Section

File Change Type Description
docs/BANK-OF-AI/Intro.md Added 272-line product introduction covering all 4 product layers
docs/BANK-OF-AI/QuickStart.md Added 2-step quick-start guide for new users
docs/BANK-OF-AI/image/bankofai-architecture.svg Added Architecture diagram showing the 6-layer transaction flow
i18n/zh-Hans/.../BANK-OF-AI/Intro.md Added Simplified-Chinese mirror
i18n/zh-Hans/.../BANK-OF-AI/QuickStart.md Added Simplified-Chinese mirror
i18n/zh-Hans/.../BANK-OF-AI/image/bankofai-architecture.svg Added Localised SVG with Chinese labels
sidebars.js Modified New BANK OF AI category added as first collapsed:false entry
i18n/zh-Hans/.../sidebars.js Modified Same sidebar change for zh-Hans locale
i18n/zh-Hans/.../current.json Modified i18n label for new sidebar category

Purpose: Provide a top-level entry point explaining the full BANK OF AI product matrix before users dive into component-specific docs.


2 · Conversational Install Method Added to MCP Server Docs

File Change Type Description
docs/McpServer-Skills/MCP/SUNMCPServer/OfficialServerAccess.md Modified Old "Quick Auto-Install" / "Interactive Installation" → three numbered methods
docs/McpServer-Skills/MCP/SUNMCPServer/QuickStart.md Modified Install section rewritten; "Restart and Test" renamed to "Test It Out"
docs/McpServer-Skills/MCP/TRONMCPServer/OfficialServerAccess.md Modified Same pattern as SUN MCP Server
docs/McpServer-Skills/MCP/TRONMCPServer/QuickStart.md Modified Same pattern as SUN MCP Server
(i18n zh-Hans mirrors of all four files) Modified Same changes in Simplified Chinese

Purpose: Lower the barrier to entry by making chat-driven installation the primary recommended path.


3 · Conversational Install Method Added to Skills Docs + New Skills Documented

File Change Type Description
docs/McpServer-Skills/SKILLS/QuickStart.md Modified Node.js prerequisite added; three install methods introduced
docs/McpServer-Skills/SKILLS/Intro.md Modified Count updated "Eight" → "Ten"; two new skill overview sections added
docs/McpServer-Skills/SKILLS/BANKOFAISkill.md Modified usdd-skill and trx-staking-skill skill reference sections added
docs/McpServer-Skills/SKILLS/image/conversational-install.png Added Screenshot for conversational install flow
(i18n zh-Hans mirrors) Modified/Added Same changes in Simplified Chinese

Purpose: Document two new skills and align the Skills installation guide with the new three-method pattern.


4 · Agent-Wallet QuickStart Restructure

File Change Type Description
docs/Agent-Wallet/QuickStart.md Modified Restructured into Method 1 (Conversational) and Method 2 (Command-Line); heading levels corrected from H3 to H4 for sub-steps
i18n/zh-Hans/.../Agent-Wallet/QuickStart.md Modified Same changes in Simplified Chinese

Purpose: Add conversational wallet creation as the primary path, consistent with the rest of the documentation.


5 · Package Version Bump

File Change Type Description
package.json Modified version bumped from 1.2.8 to 1.2.9

Purpose: Version the documentation release.


Detailed Findings


Major

[MJ-01] Restart Instructions Removed from Command-Line Install Methods

Property Value
Severity Major
Category Correctness / Documentation
File docs/McpServer-Skills/MCP/SUNMCPServer/OfficialServerAccess.md · Method 2 & 3; docs/McpServer-Skills/MCP/SUNMCPServer/QuickStart.md; docs/McpServer-Skills/MCP/TRONMCPServer/OfficialServerAccess.md · Method 2 & 3; docs/McpServer-Skills/MCP/TRONMCPServer/QuickStart.md; same zh-Hans mirrors

Description

The PR removes "restart your AI Agent" instructions from every command-line installation path (Methods 2 and 3), and also deletes the troubleshooting checklist item "AI client has been fully quit and restarted (not just refreshed)" from the SUNMCPServer/OfficialServerAccess.md troubleshooting section.

MCP Servers installed via npx add-mcp write entries into a config file on disk. Most AI clients (Claude Desktop, Cursor, OpenClaw, etc.) do require a full restart to pick up config changes — they only read the MCP configuration at launch. Removing this guidance will result in users seeing no MCP tools available even after a successful install, with no clear explanation.

The original docs even warned explicitly at the Agent-Wallet/QuickStart.md danger callout: "Many people forget this step, then wonder why AI can't find the password!" — yet the parallel restart step for MCP Server installs is now silently dropped.

Code (removed lines):

-Once installation is complete, restart your AI Agent, and you can start interacting
-with SunSwap via SUN MCP Server.
+Once installation is complete, you can start interacting with SunSwap via SUN MCP Server.

-3. AI client has been fully quit and restarted (not just refreshed)

And in TRONMCPServer/QuickStart.md:

-After saving the configuration, **completely quit and restart** your AI client.
-After restarting, the client will automatically connect to TRON MCP Server.
-
-Then enter your first query in the chat:
+## Test It Out
+
+Enter your first query in the chat:

Recommendation

Restore restart instructions specifically for Method 2 (Quick Auto-Install) and Method 3 (Interactive Install), since the conversational Method 1 may handle this differently. For example:

### Method 2: Quick Auto-Install (Command Line)

...

Once installation is complete, **fully restart your AI client** to load the new MCP
Server configuration, then start asking questions.

Also restore the troubleshooting checklist item for the restart step. If the conversational install genuinely avoids the need to restart (e.g. by hot-reloading), document that distinction explicitly rather than silently removing guidance for all paths.


[MJ-02] Conversational Install Claims Unverified AI Auto-Detection with No Fallback

Property Value
Severity Major
Category Correctness / Documentation
File docs/McpServer-Skills/MCP/TRONMCPServer/OfficialServerAccess.md : Method 1; docs/McpServer-Skills/MCP/SUNMCPServer/OfficialServerAccess.md : Method 1; docs/McpServer-Skills/SKILLS/QuickStart.md : Method 1; corresponding QuickStart.md files; all zh-Hans mirrors

Description

The new "Conversational Install (Easiest)" method makes the following specific claims that depend on the AI client's behavior, but provides no fallback guidance when they fail:

  1. "Auto-detects which AI client is currently running"
  2. "Writes the tron-mcp-server entry into the right MCP config file (no manual JSON editing)"
  3. "Reports back with a ✅ confirmation when done"

These behaviors depend on npx add-mcp correctly identifying the active client AND the AI correctly executing and interpreting the command. Neither is guaranteed — npx add-mcp uses heuristics (checks for known config file paths) and may silently install to the wrong config, or the AI may misinterpret the note ("install to the MCP config of the current Agent") and install globally.

If detection fails, the user has no guidance: there is no "if this doesn't work, do X" path in Method 1. The original docs at least ensured the user knew exactly which file was being edited.

Code:

3. The AI handles the entire flow automatically:
   - Detects the remote MCP service URL
   - Auto-detects which AI client is currently running
   - Writes the `tron-mcp-server` entry into the right MCP config file (no manual JSON editing)
   - Reports back with a ✅ confirmation when done

Once the AI confirms the install, the TRON MCP Server is ready — you can start asking
questions right away.

Recommendation

Add a brief fallback/troubleshooting note after the success path to set expectations and give users an escape hatch:

:::tip If the conversational install doesn't work as expected
If the AI reports an error, or if MCP tools are unavailable after install,
fall back to **Method 2** (command-line) which gives you direct control over which
config file is updated. See the [Troubleshooting](#troubleshooting) section below.
:::

Also consider noting that a restart may still be required after conversational install in some clients (see [MJ-01] above).


Minor

[MN-01] Skill Count Inconsistency — "Ten" vs 11 Skills Listed Everywhere

Property Value
Severity Minor
Category Documentation
File docs/McpServer-Skills/SKILLS/Intro.md : Line updated from "Eight" to "Ten"; docs/BANK-OF-AI/Intro.md : skill table lists 11; docs/BANK-OF-AI/QuickStart.md example output shows 11 installed

Description

The PR updates Intro.md to say "Ten core skills", but every other location counts 11 skills:

  • The install example output in BANK-OF-AI/QuickStart.md lists 11 Skills (agent-wallet, bankofai-guide, multi-sig-account-permissions, recharge-skill, sunperp-perpetual-futures-trading, sunswap-dex-trading, trc20-token-toolkit, tronscan-data-lookup, trx-staking-sr-voting, usdd-just-protocol, x402-payment)
  • The skill table in BANK-OF-AI/Intro.md also has 11 rows
  • The -y flag behavior is described as installing "✅ 11 Skills installed"

The count "Ten" was presumably intended to reflect the newly added usdd-skill and trx-staking-skill bringing the total from 8 to 10, but bankofai-guide is also a skill in the suite, making the true count 11.

Code:

-Eight core skills covering the most common scenarios in the TRON ecosystem.
+Ten core skills covering the most common scenarios in the TRON ecosystem.

Recommendation

Update the count to 11 in docs/McpServer-Skills/SKILLS/Intro.md (and its zh-Hans mirror which says "十大核心技能"):

Eleven core skills covering the most common scenarios in the TRON ecosystem.

Alternatively, if bankofai-guide is intentionally excluded from the user-facing count (as it is a meta/onboarding skill rather than a DeFi skill), document that distinction clearly and verify all other references are consistent.


[MN-02] Likely Orphaned Image: conversational-install.png

Property Value
Severity Minor
Category Documentation
File docs/McpServer-Skills/SKILLS/image/conversational-install.png (added); i18n/zh-Hans/.../SKILLS/image/conversational-install.png (added)

Description

Two binary PNG files are added to the image directories for the Skills section, but no corresponding ![]() image reference appears anywhere in the changed portions of docs/McpServer-Skills/SKILLS/QuickStart.md or any other modified file in this PR. The images are therefore either:

  1. Orphaned (added but not yet referenced — a forgotten step), or
  2. Referenced in an unchanged line of a file (in which case this is a non-issue, but should be verified)

An unreferenced image adds binary weight to the repository without serving any user-visible purpose.

Recommendation

Verify whether these images are actually referenced anywhere in the current docs:

grep -r "conversational-install" docs/ i18n/

If no reference exists, either add the ![Conversational install screenshot](./image/conversational-install.png) reference in the appropriate location in the Skills QuickStart guide, or remove the image files from the PR.


Suggestions

[S-01] Clarify That "Conversational Install" Still Requires Node.js Installed Before Use

File: docs/McpServer-Skills/MCP/TRONMCPServer/OfficialServerAccess.md · SUNMCPServer/OfficialServerAccess.md

Description: The Conversational Install method correctly notes in a :::tip Prerequisite callout that Node.js must be installed. However, the prerequisite is nested inside the Method 1 section, making it easy to overlook. If a user skips the prerequisite and the npx call silently fails, they will receive no meaningful error — the AI may simply report that the command failed.

Suggestion: Move the Node.js prerequisite callout to the top of the "How to Connect" section, above all three method descriptions, so it applies globally rather than appearing to be Method 1-specific. This is already done correctly in SKILLS/QuickStart.md where the Node.js tip appears before the method list.


[S-02] Consider Adding the New BANK OF AI Section to the Existing Navigation Structure Note

File: sidebars.js and i18n/zh-Hans/.../sidebars.js

Description: The new BANK OF AI category is inserted as the first item in docsSidebar with collapsed: false. This means it is always expanded when the sidebar loads, pushing all existing navigation entries (x402, 8004, Agent-Wallet, MCP Server, Skills, LLM Service…) further down. For returning users, this is a significant navigation disruption.

Suggestion: Consider whether collapsed: true is more appropriate as a default for a section that experienced users may not need to expand, or add a brief migration/changelog note indicating the new section was added and where existing content moved. Since this is a docs site, a :::note New in v1.2.9 admonition at the top of the main docs landing page would also help orient returning users.


Positive Observations

Area Observation
Security guidance Password security warnings are consistent, prominent, and appropriately severe. Every location where a master password is involved uses :::caution or :::danger admonitions with clear instructions to back up externally and never share via chat, email, or repos.
Architecture diagram The new bankofai-architecture.svg is an inline SVG with well-structured layers, meaningful colour coding, bidirectional arrows, and a legend — a substantial improvement over text-only architecture descriptions. Separate localised copies with translated labels are a thoughtful touch.
Progressive disclosure The new three-method installation pattern (Conversational → Command-Line → Interactive) is well-designed: each method is clearly labelled with a difficulty hint, and links between them are consistent.
i18n parity Every English change is correctly mirrored in the i18n/zh-Hans/ tree, including SVG labels and UI copy in the architecture diagram.
Heading hierarchy correction The Agent-Wallet QuickStart correctly demotes sub-steps from ### to #### when they are nested under the new top-level method sections — a subtle but correct structural fix.
New skill documentation usdd-skill and trx-staking-skill sections follow the established pattern (read-only examples, confirmation-required examples, real-world scenarios, cautionary callouts) and include domain-accurate information (e.g. 18-decimal USDD vs. 6-decimal USDT normalisation, 14-day unbonding period, vote replacement semantics).
Testnet-first guidance The :::warning Three Rules for Beginners callout (testnet first, review every transaction, start small) is prominent and well-positioned in the new BANK OF AI QuickStart.

Checklist Results

Category Items Checked Pass Fail N/A Notes
Correctness 5 3 2 0 Restart steps removed (MJ-01); auto-detection claim unverified (MJ-02)
Security 5 5 0 0 Password guidance is thorough; no secrets or credentials in changed files
Performance 3 0 0 3 Not applicable — documentation only
Code Quality 4 3 1 0 Skill count inconsistency (MN-01); structure and naming otherwise consistent
Testing 2 0 0 2 Not applicable — documentation only
Documentation 6 4 2 0 Orphaned image (MN-02); missing fallback guidance (MJ-02)
Compatibility 3 2 1 0 Sidebar change may disrupt existing navigation for returning users (S-02)
Observability 1 0 0 1 Not applicable — documentation only

Disclaimer

This is an automated code review. It supplements but does not replace human review. The reviewer analyzed only the diff between the specified branches. Runtime behavior, integration testing, and deployment impact are not covered. All findings relate to documentation correctness and user-experience quality rather than application code.


Report generated by Code Review Skill v1.0.0
Date: 2026-04-16

@github-actions
Copy link
Copy Markdown

Code Review Report

Project: x402-tron / BANK OF AI Documentation Site
PR: mainupdate-mcp-server
Review Date: 2026-04-17
Reviewer: AI Code Reviewer (Code Review Skill v1.0.0)


PR Overview

Branch Information

Property Value
From Branch main
To Branch update-mcp-server
Commits 8
Files Changed 28
Lines Added +1,787
Lines Removed -103

Commit History

Hash Message
f4914e0 add bankofai
c53bdfe add skills
c7c6683 add bankofai
a72b661 add bankofai
2248ef7 add bankofai
86022be add bankofai
0134a17 Add general introduction and quick installation.
a936d87 Merge pull request #42 from BofAI/ai-bankofai-patch-1

Review Summary

Verdict

Verdict: Request Changes

Findings at a Glance

Critical Major Minor Suggestion
Count 0 3 4 4

Summary

This PR is a documentation-only update to a Docusaurus site for the BANK OF AI platform. It introduces a new top-level "BANK OF AI" documentation section (Introduction + Quick Start), expands the Skills catalogue with two new entries (usdd-skill and trx-staking-skill), adds a bilingual architecture diagram (SVG), and refactors all MCP Server and Skills installation guides to promote a new "conversational install" method as the primary path. A minor version bump (1.2.8 → 1.2.9) accompanies the changes.

Overall the documentation is well-structured, clearly written, and includes good security warnings (wallet password guidance is thorough). However, three major issues require attention before merging: restart instructions were silently removed from command-line install paths leaving users who follow Methods 2/3 without the key troubleshooting step they need; the MCP Server troubleshooting checklist was shortened in a way that removes the most common fix for connection problems; and a numeric inconsistency in skill counts (8 → 10 in Intro vs 11 shown in install output) will confuse new users. Four minor and four suggestions round out the findings.


Change Summary

1. New BANK OF AI Section (English + Chinese)

File Change Type Description
docs/BANK-OF-AI/Intro.md Added 249-line introduction covering the 4-layer product matrix (Model, Protocol, Tool, Ecosystem)
docs/BANK-OF-AI/QuickStart.md Added 231-line 2-step quick start guide
docs/BANK-OF-AI/image/bankofai-architecture.svg Added SVG architecture diagram (TRC20 transfer flow)
i18n/zh-Hans/.../BANK-OF-AI/Intro.md Added Chinese translation of Intro
i18n/zh-Hans/.../BANK-OF-AI/QuickStart.md Added Chinese translation of QuickStart
i18n/zh-Hans/.../BANK-OF-AI/image/bankofai-architecture.svg Added Chinese-labelled SVG

Purpose: Introduce BANK OF AI as the product umbrella with a unified onboarding path.


2. New Skills: usdd-skill & trx-staking-skill

File Change Type Description
docs/McpServer-Skills/SKILLS/BANKOFAISkill.md Modified Added 87-line documentation for usdd-skill and trx-staking-skill
docs/McpServer-Skills/SKILLS/Intro.md Modified Updated skill count 8→10; added new skill summaries
i18n/zh-Hans/.../BANKOFAISkill.md Modified Chinese translation of new skill sections
i18n/zh-Hans/.../Intro.md Modified Chinese translation

Purpose: Document two newly available skills covering USDD/JUST Protocol operations and TRX staking + SR voting.


3. Conversational Install Refactor (MCP Servers + Skills)

File Change Type Description
docs/McpServer-Skills/MCP/SUNMCPServer/OfficialServerAccess.md Modified Restructured to 3 methods; added conversational install as Method 1
docs/McpServer-Skills/MCP/SUNMCPServer/QuickStart.md Modified Replaced bare command with conversational install steps
docs/McpServer-Skills/MCP/TRONMCPServer/OfficialServerAccess.md Modified Same restructure as SUN
docs/McpServer-Skills/MCP/TRONMCPServer/QuickStart.md Modified Same restructure as SUN
docs/McpServer-Skills/SKILLS/QuickStart.md Modified Added conversational install as Method 1; added Node.js prerequisite
docs/McpServer-Skills/SKILLS/image/conversational-install.png Added Screenshot of conversational install
Chinese mirrors of all the above Modified Chinese translations

Purpose: Promote conversational AI-driven install as the lowest-friction onboarding path.


4. Agent-Wallet QuickStart Restructure

File Change Type Description
docs/Agent-Wallet/QuickStart.md Modified Added Method 1 (conversational) before existing command-line flow; de-branded from OpenClaw to generic AI agent
i18n/zh-Hans/.../Agent-Wallet/QuickStart.md Modified Chinese translation

Purpose: Align wallet creation docs with the new conversational-first philosophy.


5. Navigation & Configuration

File Change Type Description
sidebars.js Modified Added BANK OF AI category at top of sidebar
i18n/zh-Hans/.../sidebars.js Modified Same for Chinese locale
i18n/zh-Hans/.../current.json Modified Added i18n label for new sidebar category
package.json Modified Version bump 1.2.8 → 1.2.9

Purpose: Wire up new content to site navigation and bump the package version.


Detailed Findings


Major

[MJ-01] Restart Requirement Silently Removed from Command-Line Methods

Property Value
Severity Major
Category Correctness / Documentation
File docs/McpServer-Skills/MCP/TRONMCPServer/OfficialServerAccess.md : Lines 87–95 · docs/McpServer-Skills/MCP/SUNMCPServer/OfficialServerAccess.md : Lines 68–70 · docs/McpServer-Skills/MCP/TRONMCPServer/QuickStart.md : Lines ~38–44 · docs/McpServer-Skills/MCP/SUNMCPServer/QuickStart.md : Lines ~32–36

Description

The PR removes all "restart your AI Agent" / "restart your MCP client" instructions from Method 2 (Quick Auto-Install) and Method 3 (Interactive Install) in both TRON and SUN MCP Server guides. The removed text was:

"Once installation is complete, restart your AI Agent, and you can start interacting …"

and

"After the command completes, restart your MCP client."

The conversational install (Method 1) likely doesn't require a restart because the AI client detects the updated config at runtime. However, Methods 2 and 3 write to on-disk config files. Most AI clients (Claude Desktop, Cursor, VS Code extensions) read their MCP config only at startup and do not hot-reload it. A user who follows Method 2 or 3 will find the MCP Server unavailable and have no documented path to resolution — they'll think the install failed.

Code

-Once installation is complete, restart your AI Agent, and you can start interacting with TRON blockchain via TRON MCP Server.
+Once installation is complete, you can start interacting with the TRON blockchain via TRON MCP Server.

Recommendation

Once installation is complete, **restart your AI client** so it picks up the updated
MCP config, then you can start interacting with the TRON blockchain via TRON MCP Server.

> **Note for conversational install (Method 1):** No restart is needed — the AI detects
> the new config automatically.

Alternatively, if Method 1 genuinely eliminates the need for restart for all methods, add an explicit explanation of why that is the case, so users and future maintainers understand the behaviour change.


[MJ-02] Troubleshooting Section Lost the Most Common Fix

Property Value
Severity Major
Category Documentation / Correctness
File docs/McpServer-Skills/MCP/SUNMCPServer/OfficialServerAccess.md : Line 158 · i18n/zh-Hans/.../SUNMCPServer/OfficialServerAccess.md : Line 164

Description

The troubleshooting checklist originally contained three items; this PR deletes item 3:

3. AI client has been fully quit and restarted (not just refreshed)

This is the single most common reason MCP Servers fail to appear after installation. Removing it without explanation means users hitting that exact problem will see only two items in the checklist and go unhelped. The deletion appears to be a side-effect of the restart-removal in MJ-01 rather than an intentional editorial choice.

Note: The TRON MCP Server OfficialServerAccess.md troubleshooting section was not changed and still contains all three items (the change was only applied to SUN). This inconsistency makes the omission look accidental.

Code

 If you encounter issues, first confirm:
 1. Node.js version >= 20.0.0 (run `node --version` to check)
 2. Network can reach `sun-mcp-server.bankofai.io`
-3. AI client has been fully quit and restarted (not just refreshed)

Recommendation

If you encounter issues, first confirm:
1. Node.js version >= 20.0.0 (run `node --version` to check)
2. Network can reach `sun-mcp-server.bankofai.io`
3. AI client has been fully quit and restarted (not just refreshed)
   *(not required if you used the Conversational Install — Method 1)*

[MJ-03] Skill Count Inconsistency: Intro says 10, Install Output Shows 11

Property Value
Severity Major
Category Documentation / Correctness
File docs/McpServer-Skills/SKILLS/Intro.md : Line 1080 · docs/BANK-OF-AI/QuickStart.md : Lines ~406–435

Description

Intro.md was updated from "Eight core skills" to "Ten core skills" in this PR. However, the example AI output shown in the collapsible <details> block of the BANK-OF-AI QuickStart.md (and its Chinese mirror) lists 11 skills in a table:

agent-wallet, bankofai-guide, multi-sig-account-permissions, recharge-skill, sunperp-perpetual-futures-trading, sunswap-dex-trading, trc20-token-toolkit, tronscan-data-lookup, trx-staking-sr-voting, usdd-just-protocol, x402-payment

and the text above says "✅ 11 Skills installed.". If Intro.md should say 10, then either the example output is wrong, or the introduction is one off. New users comparing the number in the Introduction to the install output will be confused.

Code

-Eight core skills covering the most common scenarios in the TRON ecosystem.
+Ten core skills covering the most common scenarios in the TRON ecosystem.

vs. QuickStart install output:

✅ **11 Skills installed.**

Recommendation

Audit the actual skill count and make it consistent across all files. If the correct number is 11, update Intro.md to "Eleven" (and its Chinese counterpart). If it's 10, update the QuickStart example output. Also update the BANKOFAISkill.md header table row count to match.


Minor

[MN-01] runtime_secrets.json File Permissions Not Mentioned

Property Value
Severity Minor
Category Security / Documentation
File docs/Agent-Wallet/QuickStart.md : Lines ~47–54 · docs/BANK-OF-AI/QuickStart.md : Lines ~582–586

Description

Multiple sections advise users that the master password is auto-saved to ~/.agent-wallet/runtime_secrets.json for convenience. This is excellent UX, but the documentation does not mention that this file should be access-restricted (e.g., chmod 600). If a multi-user machine or a compromised process reads this file, the wallet can be unlocked without the user's knowledge. The password security warnings are otherwise excellent (backup, never share, etc.), so the omission of file permissions stands out.

Recommendation

Add a note alongside the runtime_secrets.json mention:

⚠️ `~/.agent-wallet/runtime_secrets.json` is created with restricted permissions
automatically on most systems. If you're on a shared machine, verify with
`ls -la ~/.agent-wallet/runtime_secrets.json` that only your user can read it (mode `600`).

[MN-02] BANK OF AI i18n Sidebar Label Not Translated

Property Value
Severity Minor
Category Documentation / Consistency
File i18n/zh-Hans/docusaurus-plugin-content-docs/current.json : Lines 5–8

Description

The new sidebar category label was added to the Chinese i18n file with "message": "BANK OF AI" — identical to the key and to the English label. Every other category in this file is properly translated (e.g., "x402支付协议", "当前"). While "BANK OF AI" is a brand name and may deliberately remain in English, the inconsistency is jarring and looks like an oversight.

Code

"sidebar.docsSidebar.category.BANK OF AI": {
  "message": "BANK OF AI",
  "description": "The label for category BANK OF AI in sidebar docsSidebar"
},

Recommendation

If the brand name is intentionally kept in English, add a comment explaining this. If a Chinese rendering is desired (e.g., "BANK OF AI(AI 银行)"), update the message. At minimum, confirm this is intentional to avoid future translators treating it as a missed translation.


[MN-03] Install Prompt Uses Shorthand BofAI/skills but Method 2 Uses Full GitHub URL

Property Value
Severity Minor
Category Documentation / Consistency
File docs/McpServer-Skills/SKILLS/QuickStart.md : Lines 25–27 and 47

Description

The conversational install prompt (Method 1) tells users to run:

npx skills add BofAI/skills

while Method 2 (Quick Auto-Install) uses:

npx skills add https://github.com/BofAI/skills -y -g

Additionally, the BANK OF AI QuickStart uses the shorthand form without -g and with a note to install to the current Agent's directory only. These three variant invocations are presented without explanation of when each form is appropriate, which could lead users to wonder whether they install to different locations.

Recommendation

Add a brief note explaining the equivalence of the shorthand and full URL, and why the -g flag is omitted in the conversational install context. This prevents users from second-guessing the install path.


[MN-04] Hardcoded OpenClaw Path in Example Output of Broadened Documentation

Property Value
Severity Minor
Category Documentation / Consistency
File docs/BANK-OF-AI/QuickStart.md : Lines ~419 · docs/McpServer-Skills/SKILLS/QuickStart.md

Description

The example AI output in the new BANK OF AI Quick Start prominently shows:

Location: ~/.openclaw/workspace/.agents/skills/  (this Agent's directory)

The PR's stated goal is to broaden support beyond OpenClaw to Claude Code, Cursor, Telegram bots, etc. The example output uses a path that is specific to OpenClaw, making users of other AI clients wonder if the install worked correctly or went to the wrong location.

Recommendation

Replace the hardcoded path with a placeholder or show multiple examples:

Location: <your-agent-skills-dir>  (auto-detected for your Agent)
# e.g., ~/.openclaw/workspace/.agents/skills/  (OpenClaw)
#       ~/.claude/skills/                       (Claude Code)

Suggestions

[S-01] PSM Reserve Warning Could Quantify "Low"

File: docs/McpServer-Skills/SKILLS/BANKOFAISkill.mdusdd-skill section
Description: The PSM caution warns users to check reserves before redeeming, but "if USDT reserves are low" is vague. If there is a known threshold or a typical depletion pattern, sharing it would help users calibrate their expectations.
Suggestion: Optionally add: "Reserves below ~X USDT may cause large redemptions to fail; consider splitting into smaller batches." (Fill in the appropriate threshold based on protocol behaviour.)


[S-02] 14-Day Unstaking Clarification — Distinguish from TRX "Unstake" vs. Skill Scope

File: docs/McpServer-Skills/SKILLS/BANKOFAISkill.mdtrx-staking-skill danger callout
Description: The :::danger callout says "When TRX is unstaked (via the companion staking flow)". If unstaking is not directly supported by this skill (the description says "read-only" for that operation), the wording might imply users can trigger it through this skill and encounter the 14-day lockup. A clarification that unstaking is handled by a separate flow (and pointing to where) would prevent confusion.
Suggestion: Add: "Note: unstaking itself is handled by the companion trx-staking-management flow, not this skill directly." (Or update to reflect the actual scope.)


[S-03] Architecture SVG Is Duplicated for English/Chinese — Consider Shared Asset

File: docs/BANK-OF-AI/image/bankofai-architecture.svg and i18n/zh-Hans/.../bankofai-architecture.svg
Description: Two nearly identical SVG files are maintained — one with English labels, one with Chinese. SVG text is inline, so there is no shared base asset. Any future change to the diagram layout must be applied twice. Over time this could lead to diagrams diverging.
Suggestion: Consider externalising labels (e.g., using CSS classes, a JS-rendered diagram library, or a shared SVG with localised <text> blocks via Docusaurus's i18n mechanism) to reduce maintenance burden. This is a long-term suggestion and not blocking for this PR.


[S-04] Version Bump Commit Message Does Not Describe Scope

File: package.json
Description: The version was bumped from 1.2.8 to 1.2.9 across multiple commits with generic messages like "add bankofai". The absence of a CHANGELOG entry or a descriptive commit means 1.2.9 carries no human-readable record of what changed.
Suggestion: Add a CHANGELOG.md entry (or equivalent) documenting what was added in 1.2.9 — new BANK OF AI section, new skills, conversational install path, etc.


Positive Observations

Area Observation
Security warnings Password security guidance is thorough and prominent — multiple :::caution / :::danger callouts warn about the master password being shown once, the importance of external backups, and never sharing via chat/email/screenshots.
User experience The "conversational install" concept lowers the barrier significantly for non-technical users. The step-by-step with exact prompts to paste is clear and actionable.
Bilingual parity English and Chinese documentation appear to be in sync — every new English file has a corresponding Chinese file, and structural changes are mirrored accurately.
SVG architecture diagram The inline SVG is clean, well-commented, and uses semantic color coding to distinguish flow layers. Both English and Chinese versions correctly localise all visible text.
Risk callouts on new skills The trx-staking-skill danger callout about the 14-day unbonding period and the PSM caution for usdd-skill are well-placed and appropriately prominent for financial operations.
Sidebar placement The new BANK OF AI category is placed at the top of the sidebar with collapsed: false, giving it high visibility — appropriate for an umbrella introduction.

Checklist Results

Category Items Checked Pass Fail N/A Notes
Correctness 5 3 2 0 MJ-01 (removed restart), MJ-03 (skill count mismatch)
Security 4 3 1 0 MN-01 (file permissions not mentioned)
Performance 3 3 0 0 No performance concerns in doc changes
Code Quality 5 3 2 0 MN-03 (install command inconsistency), MN-04 (hardcoded path)
Testing 2 0 0 2 N/A — documentation only
Documentation 6 4 2 0 MJ-02 (truncated troubleshooting), MN-02 (missing i18n translation)
Compatibility 2 2 0 0 Sidebar additions are backward-compatible
Observability 1 0 0 1 N/A — documentation only

Disclaimer

This is an automated code review. It supplements but does not replace human review. The reviewer analysed only the diff between main and update-mcp-server. Runtime behaviour of the Docusaurus site build, link validity, image rendering, and end-to-end installation flows were not tested.


Report generated by Code Review Skill v1.0.0
Date: 2026-04-17

@github-actions
Copy link
Copy Markdown

Code Review Report

Project: @x402-tron/docs (BANK OF AI Documentation Site)
PR: main -> update-mcp-server
Review Date: 2026-04-17
Reviewer: AI Code Reviewer (Code Review Skill v1.0.0)


PR Overview

Branch Information

Property Value
From Branch main
To Branch update-mcp-server
Commits 9
Files Changed 28
Lines Added +1,787
Lines Removed -103

Commit History

Hash Message
5a7a7a7 Merge branch 'main' into update-mcp-server
6fda8c8 add bankofai version
f4914e0 add bankofai
c53bdfe add skills
c7c6683 add bankofai
a72b661 add bankofai
2248ef7 add bankofai
86022be add bankofai
0134a17 Add general introduction and quick installation

Review Summary

Verdict

Verdict: Request Changes (Minor)

Findings at a Glance

Critical Major Minor Suggestion
Count 0 1 4 3

Summary

This PR is a documentation-only update to a Docusaurus-based documentation site for the BANK OF AI Web3/AI platform. There are no changes to application source code, server logic, or security-sensitive runtime components. All 28 changed files are Markdown documentation pages, SVG/PNG assets, sidebar configuration, i18n translation files, and a minor version bump in package.json.

The PR delivers substantial new content: a full new "BANK OF AI" section with an introduction and quick-start guide (in both English and Chinese), two new skill reference sections (usdd-skill and trx-staking-skill), and a new "conversational install" onboarding flow across all MCP Server and Skills quick-start pages. The new content is well-structured, uses Docusaurus admonitions correctly, and is consistent between the English and Chinese locales.

The one major concern is that the PR removes "restart your AI Agent/MCP client" instructions from the CLI-based installation methods without explanation. These restarts are still required for config changes to take effect for command-line installs, so users following Method 2 or Method 3 may find their MCP Server is not available after installation until they discover they need to restart. Several minor inconsistencies in install commands and skill counts were also identified.


Change Summary

1. New BANK OF AI Documentation Section

File Change Type Description
docs/BANK-OF-AI/Intro.md Added Full product introduction for BANK OF AI (249 lines)
docs/BANK-OF-AI/QuickStart.md Added Two-step quick start guide (231 lines)
docs/BANK-OF-AI/image/bankofai-architecture.svg Added SVG architecture diagram showing layer interactions
i18n/zh-Hans/.../BANK-OF-AI/Intro.md Added Chinese translation of the introduction
i18n/zh-Hans/.../BANK-OF-AI/QuickStart.md Added Chinese translation of the quick start
i18n/zh-Hans/.../BANK-OF-AI/image/bankofai-architecture.svg Added Localized Chinese SVG diagram

Purpose: Introduces the overarching BANK OF AI product umbrella (4-layer model: Model/Protocol/Tool/Ecosystem) as a new top-level section in the documentation, giving users a unified entry point before diving into individual products.


2. Conversational Install Flow Added to MCP Server Docs

File Change Type Description
docs/McpServer-Skills/MCP/TRONMCPServer/OfficialServerAccess.md Modified Added Method 1 (conversational) + renamed Methods 2 & 3
docs/McpServer-Skills/MCP/TRONMCPServer/QuickStart.md Modified Replaced single install command with conversational flow
docs/McpServer-Skills/MCP/SUNMCPServer/OfficialServerAccess.md Modified Added Method 1 (conversational) + renamed Methods 2 & 3
docs/McpServer-Skills/MCP/SUNMCPServer/QuickStart.md Modified Replaced single install command with conversational flow
i18n/zh-Hans/... (4 files mirroring the above) Modified Chinese translations of all the above

Purpose: Adds a new "conversational install" path (Method 1) for users who already have an AI agent that can run shell commands — the user pastes a prompt into the AI, and the AI installs the MCP Server automatically without the user touching a terminal. Restart instructions were removed from all CLI-based methods.


3. Conversational Install Added to Skills Quick Start

File Change Type Description
docs/McpServer-Skills/SKILLS/QuickStart.md Modified Added Method 1 (conversational), Node.js prerequisite tip
docs/McpServer-Skills/SKILLS/image/conversational-install.png Added Screenshot illustrating conversational install
i18n/zh-Hans/.../McpServer-Skills/SKILLS/QuickStart.md Modified Chinese translation of updated quick start

Purpose: Same pattern as MCP docs — introduces the conversational install as the recommended beginner path.


4. Agent-Wallet Quick Start Updated

File Change Type Description
docs/Agent-Wallet/QuickStart.md Modified Added Method 1 (Conversational Setup) before the existing CLI method
i18n/zh-Hans/.../Agent-Wallet/QuickStart.md Modified Chinese translation

Purpose: Expands the wallet creation guide with a simpler conversational path for users of the BANK OF AI skill suite.


5. Two New Skill Reference Sections

File Change Type Description
docs/McpServer-Skills/SKILLS/BANKOFAISkill.md Modified Added usdd-skill and trx-staking-skill sections (87 lines each)
docs/McpServer-Skills/SKILLS/Intro.md Modified Updated count ("Eight" → "Ten"), added summaries for 2 new skills
i18n/zh-Hans/... (2 files) Modified Chinese translations

Purpose: Documents the USDD/JUST Protocol Peg Stability Module skill and the TRX Staking & SR Voting skill that are now included in the BANK OF AI skill suite.


6. Navigation and Version

File Change Type Description
sidebars.js Modified Added BANK OF AI category (collapsed: false) at top
i18n/zh-Hans/.../current.json Modified Added i18n label for new sidebar category
package.json Modified Version bump: 1.2.9 → 1.2.10

Purpose: Wires the new BANK OF AI section into the site navigation and bumps the package version.


Detailed Findings


Major

[MJ-01] Removed Restart Instructions from CLI Install Methods May Break User Experience

Property Value
Severity Major
Category Correctness / Documentation Accuracy
File docs/McpServer-Skills/MCP/TRONMCPServer/OfficialServerAccess.md : Lines 892, 904; docs/McpServer-Skills/MCP/SUNMCPServer/OfficialServerAccess.md : Lines 766, 778; docs/McpServer-Skills/MCP/TRONMCPServer/QuickStart.md : Lines 960–966; docs/McpServer-Skills/MCP/SUNMCPServer/QuickStart.md : Lines 832–836

Description

The PR removes "restart your AI Agent / MCP client" instructions from all installation methods, including the CLI-based methods (Method 2: Quick Auto-Install and Method 3: Interactive Install). The original text in at least four places read:

Once installation is complete, restart your AI Agent, and you can start interacting
with the TRON blockchain via TRON MCP Server.

and in the TRONMCPServer/QuickStart.md:

After saving the configuration, completely quit and restart your AI client. After
restarting, the client will automatically connect to TRON MCP Server.

Both were removed in this PR. The conversational install (Method 1) may indeed avoid a manual restart — the AI runs the install and the session may pick up the changes dynamically. However, for Method 2 (direct terminal npx add-mcp ... -y) and Method 3 (interactive terminal), writing to the MCP config file does not hot-reload the MCP client. Most AI clients (Claude Code, Cursor, OpenClaw) require a full restart to register new MCP server entries. Users following Methods 2 or 3 who skip the restart will find the MCP server not responding, with no guidance in the docs explaining why.

Similarly, the troubleshooting checklist item "3. AI client has been fully quit and restarted (not just refreshed)" was removed from both the SUN and TRON OfficialServerAccess docs, eliminating a common fix from the debugging path.

Code (removed lines, diff context):

-Once installation is complete, restart your AI Agent, and you can start interacting
-with the TRON blockchain via TRON MCP Server.
+Once installation is complete, you can start interacting with the TRON blockchain
+via TRON MCP Server.
-After saving the configuration, **completely quit and restart** your AI client.
-After restarting, the client will automatically connect to TRON MCP Server.
-
-Then enter your first query in the chat:
+## Test It Out
+
+Enter your first query in the chat:

Recommendation

Differentiate restart instructions by method. For Method 1 (conversational), it is acceptable to say no restart is needed. For Methods 2 and 3 (CLI-based), retain the restart instruction:

### Method 2: Quick Auto-Install (Command Line)

...

Once installation is complete, **restart your AI client** to load the new MCP
configuration, then you can start interacting via TRON MCP Server.

### Method 3: Interactive Install (Most Control)

...

Once installation is complete, **restart your AI client** to load the new MCP
configuration, then you can start interacting via TRON MCP Server.

Also restore the troubleshooting checklist item:

If you encounter issues, first confirm:
1. Node.js version >= 20.0.0 (run `node --version` to check)
2. Network can reach `tron-mcp-server.bankofai.io`
3. AI client has been fully quit and restarted (not just refreshed)

Minor

[MN-01] Install Command Format Inconsistency Between BANK-OF-AI/QuickStart and Skills/QuickStart

Property Value
Severity Minor
Category Documentation Accuracy
File docs/BANK-OF-AI/QuickStart.md : Line 393; docs/McpServer-Skills/SKILLS/QuickStart.md : Line 1154

Description

The BANK-OF-AI/QuickStart.md (the new top-level entry point) uses the short form install prompt with no flags:

Run npx skills add BofAI/skills to install every BANK OF AI Skill.
After the install completes, run bankofai-guide to walk me through the next steps.
Note: please install into this Agent's own skills directory.

The Skills/QuickStart.md Method 2 uses the full URL with -y -g flags:

npx skills add https://github.com/BofAI/skills -y -g

Two inconsistencies arise:

  1. Short form BofAI/skills vs. full URL https://github.com/BofAI/skills — behavior depends on whether the skills CLI supports GitHub shorthand notation.
  2. No -y flag in the BANK-OF-AI prompt may trigger interactive mode rather than auto-installing all skills, contradicting the one-step onboarding premise.

Recommendation

Align the conversational install prompts to explicitly specify all-accept behavior, or add a note clarifying that the AI agent should respond with -y if prompted. Additionally, confirm that BofAI/skills (short form) is reliably resolved by the npx skills CLI before recommending it as the default entry point.


[MN-02] Skill Count Inconsistency: "Ten core skills" vs. 11 Installed

Property Value
Severity Minor
Category Documentation Accuracy
File docs/McpServer-Skills/SKILLS/Intro.md : Line 1080; docs/BANK-OF-AI/QuickStart.md : Lines 423–433

Description

Intro.md was updated to read "Ten core skills covering the most common scenarios in the TRON ecosystem." However, the example AI output shown in BANK-OF-AI/QuickStart.md lists 11 Skills installed:

| 1  | `agent-wallet`                     |
| 2  | `bankofai-guide`                   |
| 3  | `multi-sig-account-permissions`    |
| 4  | `recharge-skill`                   |
| 5  | `sunperp-perpetual-futures-trading`|
| 6  | `sunswap-dex-trading`              |
| 7  | `trc20-token-toolkit`              |
| 8  | `tronscan-data-lookup`             |
| 9  | `trx-staking-sr-voting`            |
| 10 | `usdd-just-protocol`               |
| 11 | `x402-payment`                     |

The "ten" likely refers to user-facing operational skills (excluding agent-wallet and bankofai-guide which are infrastructure/guide tools), but this is not explained. A reader who counts the list will find the mismatch confusing.

Recommendation

Either update the description to "eleven skills" (or "11 skills") to match the exact install output, or add a clarifying note such as: "Ten operational skills, plus agent-wallet (wallet infrastructure) and bankofai-guide (setup guide) — 12 items total in the repository." Verify the actual count against the current repository state.


[MN-03] collapsed: false for New Sidebar Category May Affect Navigation UX

Property Value
Severity Minor
Category Documentation / UX
File sidebars.js : Lines 4–11

Description

The new BANK OF AI sidebar category is added at the top of docsSidebar with collapsed: false:

{
  type: 'category',
  label: 'BANK OF AI',
  collapsed: false,
  items: [
    'BANK-OF-AI/Intro',
    'BANK-OF-AI/QuickStart',
  ],
},

Setting collapsed: false means the category will be permanently expanded on first load (and cannot be collapsed by default in Docusaurus unless collapsible: true is also present). While this is intentional for discoverability of the new section, all other sidebar categories use the default (collapsible) behavior, making this one visually inconsistent and potentially pushing other sections further down the page for new visitors.

Recommendation

Confirm this is the intended behavior. If the goal is just to have it expanded by default but still collapsible, the current Docusaurus config is correct — verify that other categories do not specify collapsed: true explicitly. If the intent is to match the style of other categories, remove collapsed: false to use the default.


[MN-04] Duplicate Security Warning Text Across Multiple New Documents

Property Value
Severity Minor
Category Documentation Maintainability
File docs/Agent-Wallet/QuickStart.md : Lines 47–51; docs/BANK-OF-AI/QuickStart.md : Lines 582–586

Description

The master password backup warning appears verbatim (or near-verbatim) in at least three places:

  • docs/Agent-Wallet/QuickStart.md (Method 1 section)
  • docs/BANK-OF-AI/QuickStart.md (Step 2 and "A Few Reminders" section)
  • Both Chinese translations

Example repeated text:

:::caution Your master password is critical — back it up immediately
The master password is only shown once. Although it is auto-saved to
`~/.agent-wallet/runtime_secrets.json`, you should also save it manually to a
password manager (1Password, Bitwarden, etc.). ...
⚠️ Never share this password via chat, email, screenshots, or public repositories.
:::

While safety warnings benefit from repetition, having near-identical admonition blocks in multiple documents creates maintenance debt — a future update to the security guidance would need to be applied in multiple places.

Recommendation

This is acceptable for a documentation site where cross-referencing is standard. However, consider whether a single canonical location (e.g., a dedicated "Security" page or a Docusaurus :::caution include via MDX) would reduce duplication. At minimum, add a comment in the source noting the other locations where this text exists.


Suggestions

[S-01] BANK-OF-AI/QuickStart.md Verify Step References Balance Query Which Requires an Activated Account

File: docs/BANK-OF-AI/QuickStart.md : Line 533
Description: The "Verify the Install" step asks users to query TRX and USDT balances of the just-created wallet. The docs note that a brand-new TRON address may be "not activated" and show balance 0. However, the USDT balance query on an unactivated address may return an error rather than 0, which could make users think the install failed even when everything is working correctly.
Suggestion: Update the verify step to use a read-only query that works regardless of wallet activation state — for example, "Check the current price of TRX on SunSwap" — and move the balance query to a secondary "try after funding" section.


[S-02] SVG Architecture Diagrams Use Only Fixed-Width Layout

File: docs/BANK-OF-AI/image/bankofai-architecture.svg
Description: Both SVG files use a fixed viewBox="0 0 720 900" (portrait, 720px wide). The SVG will scale with the container via viewBox, but the text is sized in absolute font units (font-size="18", font-size="12", etc.), which may render very small on narrow mobile viewports. The diagram is embedded in the doc with no explicit width constraint.
Suggestion: Add a wrapping <div> with a max-width in the MDX/Markdown to constrain the SVG display size, or verify that the Docusaurus theme handles SVG scaling adequately on mobile breakpoints.


[S-03] Consider Using Docusaurus admonition Includes for Repeated Node.js Prerequisite

File: docs/McpServer-Skills/SKILLS/QuickStart.md, docs/McpServer-Skills/MCP/SUNMCPServer/OfficialServerAccess.md, docs/McpServer-Skills/MCP/TRONMCPServer/OfficialServerAccess.md
Description: An identical Node.js prerequisite tip box appears in multiple new files:

:::tip Prerequisite
**Node.js is required** on the machine where the AI Agent runs (the Agent uses `npx`
under the hood). If Node.js isn't installed yet, grab the LTS installer from
[nodejs.org](https://nodejs.org) — install once, double-click and follow the prompts.
:::

Suggestion: Docusaurus supports MDX partial imports. Consider extracting this tip into a shared partial (e.g., docs/_partials/nodejs-prerequisite.md) and importing it across the files that reference it, reducing duplication and ensuring consistent wording.


Positive Observations

Area Observation
i18n consistency Every English change has a corresponding Chinese (zh-Hans) translation. The translations mirror the English structure faithfully, including all code blocks, admonitions, and table layouts — demonstrating strong localization discipline.
Security guidance The password backup warnings are appropriately prominent (placed in :::caution and :::danger admonition blocks) and appear immediately after the step where the password is generated, minimizing the chance of a user missing them.
Progressive disclosure The three-method install pattern (Conversational → Quick CLI → Interactive) provides a clear skill-based ladder — beginners start with Method 1, power users use Method 3. Each method has a clear label summarizing its tradeoff.
<details> example output Using collapsible <details> blocks for example AI outputs is an excellent pattern — it illustrates what to expect without cluttering the main reading flow.
Admonition usage The PR correctly uses Docusaurus admonition types semantically: :::tip for helpful extras, :::caution for reversible risks, :::danger for irreversible consequences (e.g., 14-day unstaking lockup), and :::warning for general best practices.
Cross-linking New docs are well cross-linked to related sections (Quick Start → Intro → individual product docs), and the new sidebar entry is placed at the top as the logical entry point for new users.
SVG quality The architecture SVG is hand-crafted with proper semantic layer organization, clean color coding, directional arrows with markers, a legend, and both a forward-flow path and a return-path — providing genuine visual value over a placeholder image.
Version bump The package.json version increment (1.2.9 → 1.2.10) correctly accompanies the documentation content release.

Checklist Results

Category Items Checked Pass Fail N/A Notes
Correctness 8 6 1 1 Removed restart instructions for CLI methods (MJ-01)
Security 10 9 0 1 No hardcoded secrets; password guidance is present and appropriate
Performance 7 0 0 7 No runtime code changed
Code Quality 10 7 0 3 Minor inconsistencies in install commands and skill counts
Testing 7 0 0 7 Documentation only; no test coverage applicable
Documentation 6 5 0 1 New public features are documented; some duplication noted
Compatibility 5 4 0 1 Backward-compatible additions only; new sidebar entry uses collapsed: false
Observability 4 0 0 4 No runtime code changed

Disclaimer

This is an automated code review. It supplements but does not replace human review. The reviewer analyzed only the diff between the specified branches. Runtime behavior, integration testing, and deployment impact are not covered. As this PR contains exclusively documentation changes, security, performance, and testing categories are not applicable to the runtime application.


Report generated by Code Review Skill v1.0.0
Date: 2026-04-17

@Will-Guan Will-Guan merged commit cfdff7f into main Apr 17, 2026
4 checks passed
@github-actions github-actions Bot mentioned this pull request Apr 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants