Setting code owners and Adding a Release Pipeline#12
Merged
Edilmo merged 5 commits intoreleases/0.6.6from Apr 1, 2020
Merged
Conversation
Edilmo
changed the title
Edilmo
force-pushed
the
edpalenc/codeowners
branch
3 times, most recently
from
acadb63 to
5eb68a9
Compare
Edilmo
force-pushed
the
edpalenc/codeowners
branch
from
5eb68a9 to
cdfb3c1
Compare
NicholasGorski
previously approved these changes
Mar 31, 2020
NicholasGorski
approved these changes
Apr 1, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
We need code owner review process in place for the 0.6.6 branch.
Also we need a way to re-run our pipeline when a PR lands here, and out of that run, the generated versions must be formal release versions. This is achieved removing the "dev" suffix from the version number.
Related issue number
AB#15367
Checks
scripts/format.shto lint the changes in this PR.