Skip to content

Make seeding possible even if env cannot be seeded.#45

Merged
AdityaGudimella merged 2 commits intoreleases/0.8.6from
adgudime/seed_without_env
Oct 12, 2020
Merged

Make seeding possible even if env cannot be seeded.#45
AdityaGudimella merged 2 commits intoreleases/0.8.6from
adgudime/seed_without_env

Conversation

@AdityaGudimella
Copy link

We should be able to set the seed even if the env is not seedable.

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/latest/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failure rates at https://ray-travis-tracker.herokuapp.com/.
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested (please justify below)

@AdityaGudimella AdityaGudimella self-assigned this Oct 9, 2020
@AdityaGudimella AdityaGudimella requested a review from Edilmo October 9, 2020 21:09
Copy link

@Edilmo Edilmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AdityaGudimella AdityaGudimella merged commit 3a47a19 into releases/0.8.6 Oct 12, 2020
@Edilmo Edilmo deleted the adgudime/seed_without_env branch December 7, 2020 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants