Timeout#137
Open
kaizencodes wants to merge 5 commits into
Open
Conversation
StoneFrog
reviewed
Oct 31, 2019
| @@ -314,7 +314,11 @@ def middleware | |||
| end | |||
|
|
|||
| def faraday_options | |||
Contributor
There was a problem hiding this comment.
Maybe better to allow top override them? i.e. replace this part of initializer:
@conn = Faraday.new(faraday_options)
with:
@conn = Faraday.new(faraday_options.merge(options.fetch(:faraday_options, {}))) (but in more readable way )
Contributor
Author
|
@StoneFrog updated, another complication is the faraday update on master. we can't use it on channels, so I've rebased the pr onto v11 |
StoneFrog
approved these changes
Nov 19, 2019
Contributor
StoneFrog
left a comment
StoneFrog
left a comment
There was a problem hiding this comment.
I think it would be worth to document that change as well, code-wise it's ok
Contributor
Author
|
I guess we don't need to deploy this, just use the version I've pushed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bookingsync.atlassian.net/browse/CM-87832