Page List Support #418
Merged
Page List Support #418
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marron-at-work
approved these changes
Nov 22, 2025
Collaborator
Author
|
Looks like CI is failing due to a LFS quota issue: |
Collaborator
|
Force merged will fiddle with quota later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for a more central
PageListclass. Much of my operations on page storage was quite ad hoc which lead to weird bugs - having everything centralized should help. The code here ended up being simple enough to where I feel we don't need to introducestd::list.I also removed the buckets of binary trees and replaced them with lists just to make things simpler and it shouldn't have an impact on performance. If anything removing binary trees may help perf.