CI Hanging on GC Tests Fix #421
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe this fixes the issue with CI hanging when running GC tests. After some thought, it appears using
std::jthreadfor our decs thread is problematic as join is called on these at the destruction of aBSQMemoryThreadLocalInfoobject, not necessarily when we signal from main that our program is done.So, we now use
std::threadand (inDecsProcessor::signalFinished()) once the worker thread has ack'd completion we call an explicit join.I tested this locally using
actand it appears to be fixed, so hopefully this is reflected in github CI.