Add new parameters/visibilities/calculations names#204
Conversation
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Guzz-T
force-pushed
the
try/field-names
branch
2 times, most recently
from
7ba48d6 to
add62b9
Compare
Guzz-T
changed the title
Guzz-T
changed the title
Guzz-T
force-pushed
the
try/field-names
branch
from
add62b9 to
db2cba3
Compare
| 1117: Unknown("Unknown_Parameter_1117"), | ||
| 1118: Unknown("Unknown_Parameter_1118"), | ||
| 1119: Unknown("Unknown_Parameter_1119"), | ||
| 1119: Timestamp(["LAST_DEFROST_TIMESTAMP", "Unknown_Parameter_1119"]), |
There was a problem hiding this comment.
Out of curiosity: Why is this written in all upper case, since most other names are written in a different way?
There was a problem hiding this comment.
The names in capital letters are used in this way in the HA integration of BenPru. In principle, I would be in favor of a case-insensitive name search (if not already implemented), so that this makes no difference.
kbabioch
left a comment
kbabioch
left a comment
There was a problem hiding this comment.
Overall looks good to me, just wondering regarding the naming scheme (see previous comment).
See my other comment. |
|
I just did a quick test, we are case sensitive at the moment. |
|
I'll merge this now, we can add case insensitivity later |
3 participants
First small step towards #198
Please feel free to suggest more suitable names. Anything is better than “unknown”.