Support Smart-Home-Interface Part 6: Integration into Luxtronik#207
Merged
kbabioch merged 4 commits intoBouni:mainfrom Dec 30, 2025
Merged
Support Smart-Home-Interface Part 6: Integration into Luxtronik#207kbabioch merged 4 commits intoBouni:mainfrom
kbabioch merged 4 commits intoBouni:mainfrom
Conversation
Coverage Report
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
kbabioch
reviewed
Dec 25, 2025
kbabioch
approved these changes
Dec 25, 2025
Collaborator
kbabioch
left a comment
There was a problem hiding this comment.
Overall looks very clean and good again. From my point of view it could be merged, just pointed out some minor inconsistencies.
31f7791 to
dc80741
Compare
Contributor
Author
|
Rebased branch to the top of main |
dc80741 to
ddf0d07
Compare
Collaborator
Contributor
Author
|
I'd be ready for a merge. Hopefully, there shouldn't be any conflicts. I would merge this pull request first and then #213. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sixth (and last) pull request to gradually integrate the smart home interface. This pull request includes:
LuxtronikAllData: Combined data object from LuxtronikData and LuxtronikSmartHomeData
LuxtronikInterface: Combined interface from LuxtronikSocketInterface and LuxtronikSmartHomeInterface
Luxtronik: Expansion of the existing Luxtronik class with the Smart Home Interface
Scripts: Several scripts for maintenance/commissioning/debugging of the smart home interface
New unit-tests
Part 6 (last) for #190