Return "Unknown_{value}" for not supported selections#212
Merged
kbabioch merged 1 commit intoBouni:mainfrom Dec 25, 2025
Merged
Return "Unknown_{value}" for not supported selections#212kbabioch merged 1 commit intoBouni:mainfrom
kbabioch merged 1 commit intoBouni:mainfrom
Conversation
Coverage Report
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
kbabioch
approved these changes
Dec 25, 2025
Collaborator
kbabioch
left a comment
kbabioch
left a comment
There was a problem hiding this comment.
The overall approach makes sense to me, changes itself also look fine.
Collaborator
|
@Bouni Should we proceed with the merge, or do you want to review/proceed here? |
Owner
|
Sure, feel free to go on! No need to ask for my permission, you guys are more involved as I am at the moment and if you agree with changes, go ahead |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In my opinion, there is no reason to return
Nonefor unknown values.Fixes #197