Add definitions for the config interface f.k.a socket interface similar to those of the smart home interface#218
Merged
kbabioch merged 2 commits intoBouni:mainfrom Jan 3, 2026
Conversation
…ar to those of the smart home interface The definitions are currently still very incomplete and should be added over time.
Coverage Report
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
kbabioch
approved these changes
Jan 3, 2026
Collaborator
kbabioch
left a comment
There was a problem hiding this comment.
Changes itself look fine to me. Based on the fact that unit tests are still working, I'm happy to proceed with the merge ;-).
Collaborator
|
Wow, such a quick turn-around on your side @Guzz-T. Thank you so much for your contributions. This is a welcome change, it makes this more robust. Since we don't have full documentation, we can only test this "in the field", but changes look straight forward to me and based on the fact that unit tests are still green, I'm going to merge this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The definitions are currently still very incomplete and should be added over time.