Skip to content

Return True if there is no modbus data to write#267

Merged
kbabioch merged 2 commits intoBouni:mainfrom
Guzz-T:try/modbus
Mar 18, 2026
Merged

Return True if there is no modbus data to write#267
kbabioch merged 2 commits intoBouni:mainfrom
Guzz-T:try/modbus

Conversation

@Guzz-T
Copy link
Contributor

@Guzz-T Guzz-T commented Mar 17, 2026

If we use luxtronik.write(), shi.write() is also called, even though only parameters should be written. This previously led to an invalid result.

@github-actions
Copy link

Coverage

Coverage Report
FileStmtsMissCoverMissing
luxtronik
   __main__.py25250%3–66
   datatypes.py450199%147
   discover.py58198%63
luxtronik/cfi
   interface.py175398%167–168, 256
luxtronik/definitions
   __init__.py208199%216
luxtronik/scripts
   __init__.py35586%7–16, 51
   discover_shi.py60600%8–98
   dump_cfi.py14657%18–25, 29
   dump_shi.py15660%21–28, 32
   performance_shi.py63630%7–89
   update_screen.py1058222%6, 20–41, 46–48, 51–61, 64, 70–75, 78, 81–85, 88–92, 95–97, 100–103, 106–111, 115–116, 119–126, 129–136
   watch_cfi.py321650%36–47, 50–56, 60
   watch_shi.py331652%38–49, 52–58, 62
luxtronik/shi
   interface.py337399%438, 519, 527
TOTAL243228888% 

Tests Skipped Failures Errors Time
378 0 💤 0 ❌ 0 🔥 17.932s ⏱️

@kbabioch kbabioch merged commit 2b339ba into Bouni:main Mar 18, 2026
4 checks passed
@Guzz-T Guzz-T deleted the try/modbus branch March 18, 2026 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants