Es 7755

[smorgan-brainomix]

No description provided.

[salty-horse]

Hey,

Is it OK if I submit a modified version of this (with certificate authentication support) back into Pr0Ger/PyAPNs2?

Judging by the codenames and review process, I'm assuming you're using this as part of an internal company, and I don't know if it's being made available under the same license as the original project.

[smorgan-brainomix]

Hi @salty-horse - you are correct we are using this internally at our company. It's still under the MIT licence so you are free to do what you like with it, but as per the LICENSE file, we cannot offer any warranty or support for it.

For a bit of background, this was heavily influenced by https://github.com/pocketlabs/PyAPNs2 but tidied up a bit to ensure we understood it before using it in our products. Compared to the original PyAPNs2 implementation with hyper this no longer does the HTTP/2 request multiplexing explicitly and my understanding of httpx is that it won't do this for you unless using it in an async function. So the performance when sending large numbers of notifications might be worse than the original, although we haven't benchmarked the two implementations against each other.