fix double counting of spell crit talents#442
Draft
Alessandro-Barbieri wants to merge 3 commits intoBreakBB:masterfrom
Draft
fix double counting of spell crit talents#442Alessandro-Barbieri wants to merge 3 commits intoBreakBB:masterfrom
Alessandro-Barbieri wants to merge 3 commits intoBreakBB:masterfrom
Conversation
now arcane instability is correct on classic and TBC
devastation crit bonus was double counted
Owner
|
Thanks for tackling this @Alessandro-Barbieri - I guess you are testing the changes you do for the specific classes? |
Contributor
Author
|
I was thinking what to do with the wotlk stuff, I suspect spell crit is already accounted. I can test only on mage/warlock in classic era and on mage in tbc |
Owner
|
I honestly think it's better to keep a low profile with these changes and only change what we know for sure that needs changes. Everything else will be reported at some point 🤷🏻♂️ From the recent history I am no longer confident about general rules with the stat APIs (e.g. "All spells with this description are already included in Crit). What do you think? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#441