[BI-1281] refactor obsVarName error messages to use Name#150
[BI-1281] refactor obsVarName error messages to use Name#150dmeidlin merged 7 commits intorelease/0.5from
Conversation
HMS17
left a comment
HMS17
left a comment
There was a problem hiding this comment.
Tested with a file with name and description exceeding character limits, got:
"Name: Name exceeds 12 character limit in row 2
method.description: Method description exceeds 30 character limit in row 2"
Based on the card, the second line should be more akin to "Method Description: Method description exceeds 30 character limit in row x", correct?
Also tested a scenario with insufficient scale categories and got "scale.categories: Ordinal scales must have at least two categories. in row 4" which matches the expected result but I'm wondering if that is a typo given that seems more the variable name than the column name.
nickpalladino
left a comment
nickpalladino
left a comment
There was a problem hiding this comment.
I think this should target the v0.5 release branch right?
dmeidlin
force-pushed
the
bug/BI-1281
branch
from
237c79e to
a882e34
Compare
| @Override | ||
| public ValidationError getMissingObsVarNameMsg() { | ||
| return new ValidationError("observationVariableName", "Missing observation variable name", HttpStatus.BAD_REQUEST); | ||
| return new ValidationError("name", "Missing Name", HttpStatus.BAD_REQUEST); |
There was a problem hiding this comment.
Should this be capitalized?
There was a problem hiding this comment.
Same question for entity and attribute in here and TraitValidationError.
There was a problem hiding this comment.
Should trait traitDescription, programObservationLevel.name, and method.formula be updated?
| return new ValidationError("Method Description", "Method description exceeds 30 character limit", HttpStatus.UNPROCESSABLE_ENTITY); | ||
| } | ||
|
|
||
| @Override |
There was a problem hiding this comment.
Should the terminology here and in TraitValidationError be changed to name rather than trait name? Should it also be capitalized?
There was a problem hiding this comment.
Trait name is now a concatenation of entity + attribute; whereas, obs var. name is the Name. So my feeling is to keep trait name as is for now, but I updated the rest of the field names to have consistent formatting/capitalization.
dmeidlin
changed the title
3 participants
Description
Story: BI-1281
trait import validation error messages for observation variable names were changed to refer instead to "name"
Dependencies
bi-web
developTesting
try importing a trait with a name that exceeds the 12 char limit.
Checklist: