BI-1881 (Remove Need to Provide Parents to processGermplasmForDisplay)#288
BI-1881 (Remove Need to Provide Parents to processGermplasmForDisplay)#288
Conversation
davedrp
requested review from
a team,
mlm483 and
nickpalladino
and removed request for
a team
There was a problem hiding this comment.
Looking at the failures in the TAF run and testing locally, I'm noticing that uploading Germplasm in a program that doesn't have any Germplasm yet fails. It will hang after the user clicks "Upload" or "Confirm", I think depending on when the cache gets hit.
If you want to run the failing TAF scenarios locally, here are the tags.
--tags \"@BI-1805 or @BI-1598 or @BI-1603 or @BI-1775 or @BI-1776 or @BI-1592 or @BI-1501 or @BI-1514 or @BI-1593 or @BI-1588 or @BI-1600\"
| return programGermplasmMap; | ||
| } | ||
|
|
||
| private boolean expand_programGermplasmByFullName(ProgramEntity program, Map<String, BrAPIGermplasm> programGermplasmByFullName) throws ApiException { |
There was a problem hiding this comment.
Unless the underscore in the name is part of a convention I don't know about, I would remove it.
| log.trace("processing germ for display: " + germplasmList); | ||
| Map<String, BrAPIGermplasm> programGermplasmByFullName = new HashMap<>(); | ||
| for (BrAPIGermplasm germplasm: programGermplasm) { | ||
| boolean isExpanded_programGermplasmByFullName = false; |
There was a problem hiding this comment.
Unless the underscore in the name is part of a convention I don't know about, I would remove it.
isExpandedProgramGermplasmByFullName would be OK with me, something like isMissingParents would be OK too.
| } | ||
|
|
||
| private boolean expand_programGermplasmByFullName(ProgramEntity program, Map<String, BrAPIGermplasm> programGermplasmByFullName) throws ApiException { | ||
| List<BrAPIGermplasm> allProgramGermplasm = getRawGermplasm(program.getId()); |
There was a problem hiding this comment.
getRawGermplasm hits the cache, calling it from the method processGermplasmForDisplay which is used to populate the cache may be causing the issues I'm seeing locally and in the TAF run.
There was a problem hiding this comment.
I thought the original intent of this card was to grab the accession numbers from the pedigree string [programKey-accessionNumber] and use that to create the newPedigreeString rather than requiring the parent germplasm objects @timparsons? Although I'm not sure how it would create the name and UUID pedigree strings in that case.
| log.trace("processing germ for display: " + germplasmList); | ||
| Map<String, BrAPIGermplasm> programGermplasmByFullName = new HashMap<>(); | ||
| for (BrAPIGermplasm germplasm: programGermplasm) { | ||
| boolean isExpanded_programGermplasmByFullName = false; |
| } | ||
|
|
||
| private boolean expand_programGermplasmByFullName(ProgramEntity program, Map<String, BrAPIGermplasm> programGermplasmByFullName) throws ApiException { | ||
| List<BrAPIGermplasm> allProgramGermplasm = getRawGermplasm(program.getId()); |
There was a problem hiding this comment.
I thought the original intent of this card was to grab the accession numbers from the pedigree string [programKey-accessionNumber] and use that to create the newPedigreeString rather than requiring the parent germplasm objects @timparsons? Although I'm not sure how it would create the name and UUID pedigree strings in that case.
rob-ouser-bi
force-pushed
the
develop
branch
from
e7a2a8c to
0ec6b35
Compare
|
Closing in favor of #290 |
3 participants
Description
BI-1881 Remove Need to Provide Parents to processGermplasmForDisplay
Checklist: