Skip to content

[BI-1960] Exp import proceeds with multiple exp names & error message improvement#313

Closed
dmeidlin wants to merge 22 commits intodevelopfrom
feature/BI-1960
Closed

[BI-1960] Exp import proceeds with multiple exp names & error message improvement#313
dmeidlin wants to merge 22 commits intodevelopfrom
feature/BI-1960

Conversation

@dmeidlin
Copy link
Contributor

@dmeidlin dmeidlin commented Nov 28, 2023

Description

Story: BI-1960

An additional check for multiple unique experiment titles in the same import file was put in place when creating the trial PIO during experiment import. An exception is thrown if multiple exp titles detected.

Dependencies

none

Testing

  1. create an experiment import file containing multiple rows with at least two distinct experiment titles listed: for example, EXP-A and EXP-B.
  2. attempt to import the experiments

A red error banner should appear citing "File contains more than one Experiment Title"

Checklist:

  • I have performed a self-review of my own code
  • I have tested my code and ensured it meets the acceptance criteria of the story
  • I have tested that my code works with both the brapi-java-server and BreedBase
  • I have create/modified unit tests to cover this change
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to documentation
  • I have run TAF: <please include a link to TAF run>

@dmeidlin dmeidlin requested review from a team, davedrp and mlm483 and removed request for a team November 28, 2023 19:36
Copy link
Contributor

@mlm483 mlm483 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, working.

Because the changes for BI-1960 are relatively few, I might close this PR and create a new PR off of develop with the changes for BI-1960 alone. But if you want to keep this PR and merge after BI-1830, that's OK with me as well.

@dmeidlin dmeidlin closed this Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants