Skip to content

BI-2014 - unable to download experiment #325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davedrp merged 2 commits into from
Jan 11, 2024
Merged

BI-2014 - unable to download experiment #325

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6c1278f
[BI-2014] removed code that was causing a problem. We _may_ need to …
davedrp Dec 22, 2023
fd9d7ad
Merge branch 'release/0.9' into bug/BI-2014
davedrp Jan 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions ...ain/java/org/breedinginsight/brapps/importer/services/processors/ExperimentProcessor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1051,10 +1051,7 @@ private void addObsVarsToDatasetDetails(PendingImportObject<BrAPIListDetails> pi
referencedTraits.forEach(trait -> {
String id = Utilities.appendProgramKey(trait.getObservationVariableName(), program.getKey());

// Don't append the key if connected to a brapi service operating with legacy data(no appended program key)
if (trait.getFullName() == null) {
id = trait.getObservationVariableName();
}
// TODO - Don't append the key if connected to a brapi service operating with legacy data(no appended program key)

if (!details.getData().contains(id) && ImportObjectState.EXISTING != pio.getState()) {
details.getData().add(id);
Expand Down