-
Notifications
You must be signed in to change notification settings - Fork 1
[BI-2256] - Experimental Collaborator BI-API Changes #390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
35 commits
Select commit
Hold shift + click to select a range
c276114
[BI-2256] - Experimental Collaborator BI-API Changes
HMS17 5a15024
Added first GET collaborators test and updated controller method
nickpalladino 2a9b748
[BI-2256] - Small refactoring, endpoint progress
HMS17 4b5f9b4
[BI-2256] - Working on GET, RoleService helper method
HMS17 c8763fe
Added second GET test and some user setup and teardown
nickpalladino 6f24db7
Delete src/main/java/org/breedinginsight/utilities/out.csv
nickpalladino 65cbbde
Added test for POST with invalid program user id and updated request …
nickpalladino feb6258
[BI-2256] - GET method, some other fixes
HMS17 29b28ac
[BI-2256] - Experimental Collaborator BI-API Changes
HMS17 ef7dd26
Added first GET collaborators test and updated controller method
nickpalladino 90b976d
[BI-2256] - Small refactoring, endpoint progress
HMS17 3ad6c1b
[BI-2256] - Working on GET, RoleService helper method
HMS17 3e61b68
Added second GET test and some user setup and teardown
nickpalladino b584e68
Delete src/main/java/org/breedinginsight/utilities/out.csv
nickpalladino 6556601
Added test for POST with invalid program user id and updated request …
nickpalladino 4f18253
[BI-2256] - GET method, some other fixes
HMS17 1845cf2
Added post and delete test
nickpalladino e9fb5fa
[BI-2256] - Switch to using userId, code to retrieve collabId
HMS17 328fca7
Merge remote-tracking branch 'origin/feature/BI-2256' into feature/BI…
HMS17 5f7d9e2
Added another get test
nickpalladino 2126274
Merge branch 'develop' into feature/BI-2256
HMS17 a138f57
Added get after deactivated test
nickpalladino cd8303b
Merge branch 'feature/BI-2256' of https://github.com/Breeding-Insight…
nickpalladino 05284cc
Simplified test
nickpalladino 7061ed5
Removed comment
nickpalladino 6f9541f
Added response checks for active=false case
nickpalladino 5c050c4
Added response checks for active=true case
nickpalladino 49a4127
[BI-2256] - Cleanup
HMS17 3ffbdb2
Merge remote-tracking branch 'origin/feature/BI-2256' into feature/BI…
HMS17 f3beeb0
[BI-2256] - Cleanup and fixing unit test
HMS17 b7d03f2
[BI-2256] - Removing unused programUserId in response
HMS17 06aa11d
[BI-2256] - unit test
HMS17 2254603
[BI-2256] - unit test
HMS17 ad3c5cb
[BI-2256] - moved tests
HMS17 2ebbd86
Merge branch 'develop' into feature/BI-2256
nickpalladino File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
19 changes: 19 additions & 0 deletions
19
src/main/java/org/breedinginsight/api/model/v1/request/ExperimentCollaboratorRequest.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| package org.breedinginsight.api.model.v1.request; | ||
|
|
||
| import io.micronaut.core.annotation.Introspected; | ||
| import lombok.*; | ||
|
|
||
| import javax.validation.constraints.NotBlank; | ||
| import java.util.UUID; | ||
|
|
||
| @Getter | ||
| @Setter | ||
| @Builder | ||
| @ToString | ||
| @AllArgsConstructor | ||
| @NoArgsConstructor | ||
| @Introspected | ||
| public class ExperimentCollaboratorRequest { | ||
| @NotBlank | ||
| private UUID userId; | ||
| } |
44 changes: 44 additions & 0 deletions
44
...main/java/org/breedinginsight/api/model/v1/response/ExperimentalCollaboratorResponse.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| /* | ||
| * See the NOTICE file distributed with this work for additional information | ||
| * regarding copyright ownership. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.breedinginsight.api.model.v1.response; | ||
|
|
||
| import lombok.*; | ||
| import lombok.experimental.Accessors; | ||
|
|
||
| import javax.validation.constraints.NotBlank; | ||
| import javax.validation.constraints.NotNull; | ||
| import java.util.UUID; | ||
|
|
||
| @Getter | ||
| @Setter | ||
| @Accessors(chain=true) | ||
| @ToString | ||
| @NoArgsConstructor | ||
| @AllArgsConstructor | ||
| public class ExperimentalCollaboratorResponse { | ||
| //collaboratorId is null in case where active=false | ||
| private UUID collaboratorId; | ||
| @NotNull | ||
| private Boolean active; | ||
| @NotBlank | ||
| private String name; | ||
| @NotBlank | ||
| private String email; | ||
| @NotBlank | ||
| private UUID userId; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an improvement, thanks!