Skip to content

BI-2156 - Upgrade Apache Tika to 2.3.0+ #432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mlm483 merged 4 commits into from
Nov 20, 2024
Merged

BI-2156 - Upgrade Apache Tika to 2.3.0+ #432

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5ac1ba9
[BI-2156] - updated apache tika
mlm483 Nov 14, 2024
92b08d0
[BI-2156] - hard-coded apache commons compress version
mlm483 Nov 14, 2024
22e0003
[BI-2156] - removed unused variable from pom.xml
mlm483 Nov 20, 2024
2aedf3b
Merge branch 'develop' into bug/BI-2156
mlm483 Nov 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 8 additions & 30 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,11 +90,9 @@
<okhttp.version>4.9.3</okhttp.version>
<mockito.version>4.3.1</mockito.version>
<brapi-java-client.version>2.1-SNAPSHOT</brapi-java-client.version>
<commons-io.version>2.11.0</commons-io.version>
<tika-app.version>2.2.1</tika-app.version>
<!-- Version of apache-poi depends on version of tika. Tika uses these. -->
<apache-poi.version>4.1.2</apache-poi.version>
<apache-poi-ooxml.version>4.1.2</apache-poi-ooxml.version>
<tika-app.version>2.9.2</tika-app.version>
<!-- Hard-coded version of transitive dependency commons compress seems to be needed. -->
<commons-compress.version>1.26.1</commons-compress.version>
<javaxmail.version>1.6.2</javaxmail.version>
<st4.version>4.3.1</st4.version>
<tablesaw.version>1.0.0-SNAPSHOT</tablesaw.version>
Expand Down Expand Up @@ -378,36 +376,16 @@
<artifactId>brapi-java-client</artifactId>
<version>${brapi-java-client.version}</version>
</dependency>
<dependency>
Copy link
Member

@nickpalladino nickpalladino Nov 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume tika is pulling all these in?

Copy link
Contributor Author

@mlm483 mlm483 Nov 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, maven pulls those in to build tika as they are dependencies of tika. I don't know how common or advisable it is to hard-code transitive dependencies with maven projects, I used trial and error to determine that maven did the right thing for all the transitive dependencies besides apache commons compress, which I hard-coded. I think the issue might have been that two primary dependencies of bi-api both depend on apache commons compress, and maven was defaulting to using a version that didn't work with tika.

<groupId>org.apache.commons</groupId>
<artifactId>commons-csv</artifactId>
<version>${apache-commons-csv.version}</version>
</dependency>
<dependency>
<groupId>org.apache.poi</groupId>
<artifactId>poi</artifactId>
<version>${apache-poi.version}</version>
</dependency>
<dependency>
<groupId>org.apache.poi</groupId>
<artifactId>poi-ooxml</artifactId>
<version>${apache-poi-ooxml.version}</version>
</dependency>
<dependency>
<groupId>org.apache.commons</groupId>
<artifactId>commons-lang3</artifactId>
<version>${apache-commons-lang.version}</version>
</dependency>
<dependency>
<groupId>commons-io</groupId>
<artifactId>commons-io</artifactId>
<version>${commons-io.version}</version>
</dependency>
<dependency>
<groupId>org.apache.tika</groupId>
<artifactId>tika-app</artifactId>
<version>${tika-app.version}</version>
</dependency>
<dependency>
<groupId>org.apache.commons</groupId>
<artifactId>commons-compress</artifactId>
<version>${commons-compress.version}</version>
</dependency>
<dependency>
<groupId>com.sun.mail</groupId>
<artifactId>javax.mail</artifactId>
Expand Down