[BI-2055] - Remove missingValueString tablesaw values#438
Closed
[BI-2055] - Remove missingValueString tablesaw values#438
Conversation
7 tasks
davedrp
approved these changes
Jan 15, 2025
mlm483
approved these changes
Jan 15, 2025
Contributor
mlm483
left a comment
There was a problem hiding this comment.
Tested, working.
I left one suggested change to clean up a comment.
...inginsight/brapps/importer/services/processors/experiment/validator/field/TextValidator.java
Outdated
Show resolved
Hide resolved
Co-authored-by: mlm483 <128052931+mlm483@users.noreply.github.com>
7 tasks
Contributor
Author
|
Closing due to change in requirements for card no longer including null among the values to remove from missingValueString |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Story: BI-2055 - Remove missingValueString tablesaw values
Default tablesaw behavior silently converts certain values to an empty string when processing tables, which can lead to unexpected behavior when importing files in DeltaBreed. This follows up on work implemented in BI-1993 to also remove this silent conversion for N/A, NaN, *, and null values and update associated tests. Since before this card any of the aforementioned values would be converted to null, this revealed some unexpected behavior in downstream workflows processing said values, which this part of the card addressed.
Dependencies
tablesaw: bug/BI-2055 (should be merged into master before this card is tested to avoid a great deal of pain)
Testing
For both the new experiment and append/overwrite workflows
Smoke test other upload workflows as a sanity measure
Checklist: