Skip to content

[BI-1347] - Germplasm Pedigree View#225

Closed
HMS17 wants to merge 14 commits intodevelopfrom
feature/BI-1347
Closed

[BI-1347] - Germplasm Pedigree View#225
HMS17 wants to merge 14 commits intodevelopfrom
feature/BI-1347

Conversation

@HMS17
Copy link
Contributor

@HMS17 HMS17 commented May 9, 2022

Description

Story: BI-1347 - Germplasm Pedigree View

Integrated the BrAPI Pedigree Viewer into the germplasm view.

Implementation notes:

  • made forks of both the pedigree viewer and brapi-js libraries from the solgenomics repo in order to expand functionality and make some bug fixes.
  • the build GitHub Action was updated to use node 12, and then update npm to v8. This was because of the use of HTTP links for the brapi-js, brapi-pedigree-viewer, and d3-pedigree-tree dependencies

NOTE: Before merging this PR:

Out of scope:

  • Utilize configuration in PedigreeViewer to allow pedigree to link to corresponding node's germplasm details page - This will be handled in BI-1494

Dependencies

Testing

Has been tested during development with a program pointed to Breedbase

  1. Load germplasm with multiple pedigree connections into your program
  2. Navigate to a germplasm that has pedigree connections
  3. Verify that the pedigree tree renders, and you can click on any of the arrows (up, down, right) to expand the pedigree tree
  4. Verify that when your mouse is over the tree you can zoom in and out by scrolling your mouse
  5. Verify that you can move the tree by clicking and dragging

Checklist:

  • I have performed a self-review of my own code
  • I have tested my code and ensured it meets the acceptance criteria of the story
  • I have create/modified unit tests to cover this change
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to documentation
  • I have run TAF: <link to TAF run>

@timparsons timparsons marked this pull request as ready for review June 8, 2022 19:54
@timparsons timparsons closed this Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants