Merged
Conversation
timparsons
approved these changes
Oct 20, 2023
Comment on lines
+259
to
+264
| removeUnique(str: string|undefined): string { | ||
| if(!str){ return "";} | ||
| str = str.trim(); | ||
| const reg = /\[[^\]]*\]$/; | ||
| return str.replace(reg, '').trim(); | ||
| } |
Member
There was a problem hiding this comment.
For v0.8.1 I don't see a problem leaving this code in there, but I think it should be handled in bi-api. Could look to fix this in v0.9
Contributor
There was a problem hiding this comment.
I agree, we have static Utilities methods to remove program keys in bi-api. If it's not too much effort, I would make the change now.
Contributor
Author
There was a problem hiding this comment.
A new story for this (BI-1973) has been written.
mlm483
requested changes
Oct 20, 2023
Contributor
mlm483
left a comment
mlm483
left a comment
There was a problem hiding this comment.
Functionality looks good, I would strip the program key in bi-api.
Comment on lines
+259
to
+264
| removeUnique(str: string|undefined): string { | ||
| if(!str){ return "";} | ||
| str = str.trim(); | ||
| const reg = /\[[^\]]*\]$/; | ||
| return str.replace(reg, '').trim(); | ||
| } |
Contributor
There was a problem hiding this comment.
I agree, we have static Utilities methods to remove program keys in bi-api. If it's not too much effort, I would make the change now.
12 tasks
mlm483
approved these changes
Oct 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
BI-1911 - in response to Shahana's testing notes.
Dependencies
bi-api: bug/BI-1911-2 branch
Testing
Expected Results
Env Year,Env, andExp unit IDcolumns should appear as they did in the import file.Checklist: