[BI-1761] Error message with the backend code#352
Merged
Conversation
mlm483
requested changes
Nov 22, 2023
Contributor
There was a problem hiding this comment.
I recommend closing this PR and making the change in bi-api instead:
- Remove
"<br/><br/>"fromMISSING_OBS_UNIT_ID_ERRORin ExperimentProcessor.
EDIT:
I see the techspecs on the Jira card, but I don't think we should start treating error messages from bi-api as HTML just for this one line break.
I would take Shawn's suggested error message, and make the change on the backend. It's shorter, it can be a single line. https://breedinginsight.atlassian.net/browse/BI-1761?focusedCommentId=14200
Contributor
|
developer test PASSED |
davedrp
approved these changes
Nov 29, 2023
Contributor
Author
|
I changed the message on the back end and created a new PR for bi-api, but I'm leaving the changes in place on the front end since they work with the existing messages and if rich messages are needed in the future, it won't break anything. |
mlm483
approved these changes
Dec 6, 2023
7c01f1e to
95bd8d9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Story: BI-1761
The npm packages dompurify and @types/dompurify were added as project dependencies.
The component
ErrorNotificationwas changed to sanitize the error message from the backend with calling dompurify and render the result as html.Dependencies
bi-api:latest
Testing
Checklist: