Skip to content

BI-2364 Downloaded ontology file had 'units' added to trait with scale class text.#413

Merged
davedrp merged 1 commit intorelease/1.0from
bug/BI-2364
Nov 5, 2024
Merged

BI-2364 Downloaded ontology file had 'units' added to trait with scale class text.#413
davedrp merged 1 commit intorelease/1.0from
bug/BI-2364

Conversation

@davedrp
Copy link
Contributor

@davedrp davedrp commented Oct 31, 2024

Description

BI-2364 Downloaded ontology file had 'units' added to trait with scale class text.

Deleted lines in the setScaleClass(value: string) method, that set units to value. (value will be one of the following strings "Date", "Nominal", "Numerical", "Ordinal",or "Text")

Dependencies

None.

Testing

WHEN user is on the Ontology List screen,
AND selects the 'Show details' link of an existing ontology,
AND select the 'Edit' link,
AND changes the Scale Class to anything besides "Numerical",
AND selects 'Save'.
WHEN user selects the 'Manage Ontology' pull-down,
AND selects 'Download File'.
THEN the row associated with the edited ontology should have a value in the Units column.

Checklist:

  • I have performed a self-review of my own code
  • I have tested my code and ensured it meets the acceptance criteria of the story
  • I have create/modified unit tests to cover this change
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to documentation
  • I have run TAF: <link to TAF run>

@davedrp davedrp requested review from a team, HMS17 and mlm483 and removed request for a team October 31, 2024 20:13
@github-actions github-actions bot added the bug Something isn't working label Oct 31, 2024
Copy link
Contributor

@mlm483 mlm483 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, working as expected. I was able to reproduce the issue on the release/1.0 branch.

I'm guessing I missed the trait-creation-via-the-UI codepath in my PR for BI-2053.

@davedrp davedrp merged commit 6e483dc into release/1.0 Nov 5, 2024
@davedrp davedrp deleted the bug/BI-2364 branch November 5, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants