BI-2364 Downloaded ontology file had 'units' added to trait with scale class text.#413
Merged
davedrp merged 1 commit intorelease/1.0from Nov 5, 2024
Merged
BI-2364 Downloaded ontology file had 'units' added to trait with scale class text.#413davedrp merged 1 commit intorelease/1.0from
davedrp merged 1 commit intorelease/1.0from
Conversation
HMS17
approved these changes
Nov 1, 2024
mlm483
approved these changes
Nov 1, 2024
Contributor
mlm483
left a comment
There was a problem hiding this comment.
Tested, working as expected. I was able to reproduce the issue on the release/1.0 branch.
I'm guessing I missed the trait-creation-via-the-UI codepath in my PR for BI-2053.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
BI-2364 Downloaded ontology file had 'units' added to trait with scale class text.
Deleted lines in the setScaleClass(value: string) method, that set
unitstovalue. (valuewill be one of the following strings "Date", "Nominal", "Numerical", "Ordinal",or "Text")Dependencies
None.
Testing
WHEN user is on the Ontology List screen,
AND selects the 'Show details' link of an existing ontology,
AND select the 'Edit' link,
AND changes the
ScaleClassto anything besides "Numerical",AND selects 'Save'.
WHEN user selects the 'Manage Ontology' pull-down,
AND selects 'Download File'.
THEN the row associated with the edited ontology should have a value in the
Unitscolumn.Checklist: