Simplified Code and added Sliding Date Range to limit records modified #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…of while loop. Replaced Chunks with simplified .Take(100 ).ToList() call instead. Added status message for how many people were modified. Added ability to configure job to only modify people created within a relative date range.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disclaimer
Feel free to dump this PR if you want. I ended up changing a lot.
Changes
Reduced to building query a single time with a do/while loop instead of while loop.
Replaced Chunks with simplified .Take(100 ).ToList() call instead.
Added status message for how many people were modified.
Added ability to configure job to only modify people created within a relative date range.
Testing
Successfully ran on my dev box with live data. Updated 6,500 records in 37 seconds.