Skip to content

isl_verse_markers verse checking fix#484

Merged
AthulyaMS merged 2 commits into
devfrom
islverse_markers_api
May 14, 2026
Merged

isl_verse_markers verse checking fix#484
AthulyaMS merged 2 commits into
devfrom
islverse_markers_api

Conversation

@NoelSudhish
Copy link
Copy Markdown
Contributor

@NoelSudhish NoelSudhish commented May 13, 2026

User description

#486

isl_verse_markers verse checking is done using data from versification.json

if timestamp 0 is given as input then verse 0 and timestamp 0 will not be automatically added else it will be added


CodeAnt-AI Description

Fix verse validation and intro marker handling for ISL verse markers

What Changed

  • Verse checks now use chapter limits from the versification data, so invalid verses and verse ranges are rejected consistently for each book
  • Intro markers are only added when needed: if the first marker already starts at 00:00:00:00, verse 0 is not inserted
  • Clearer validation errors are returned when a book, chapter, or verse cannot be matched

Impact

✅ Fewer invalid verse submissions
✅ Correct handling of intro markers at timestamp zero
✅ Clearer verse validation errors

💡 Usage Guide

Checking Your Pull Request

Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.

Talking to CodeAnt AI

Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:

@codeant-ai ask: Your question here

This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.

Example

@codeant-ai ask: Can you suggest a safer alternative to storing this secret?

Preserve Org Learnings with CodeAnt

You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:

@codeant-ai: Your feedback here

This helps CodeAnt AI learn and adapt to your team's coding style and standards.

Example

@codeant-ai: Do not flag unused imports.

Retrigger review

Ask CodeAnt AI to review the PR again, by typing:

@codeant-ai: review

Check Your Repository Health

To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.

@NoelSudhish NoelSudhish requested a review from AthulyaMS May 13, 2026 11:35
@NoelSudhish NoelSudhish self-assigned this May 13, 2026
@codeant-ai
Copy link
Copy Markdown

codeant-ai Bot commented May 13, 2026

CodeAnt AI is reviewing your PR.


Thanks for using CodeAnt! 🎉

We're free for open-source projects. if you're enjoying it, help us grow by sharing.

Share on X ·
Reddit ·
LinkedIn

@codeant-ai codeant-ai Bot added the size:M This PR changes 30-99 lines, ignoring generated files label May 13, 2026
@codeant-ai
Copy link
Copy Markdown

codeant-ai Bot commented May 13, 2026

CodeAnt AI finished reviewing your PR.

@vercel
Copy link
Copy Markdown

vercel Bot commented May 13, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
vachan-admin-v2 Ready Ready Preview, Comment May 13, 2026 0:05am

Request Review

@AthulyaMS AthulyaMS merged commit d3c7050 into dev May 14, 2026
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M This PR changes 30-99 lines, ignoring generated files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants