Skip to content

Dictionary index words sort case insensitive#488

Merged
AthulyaMS merged 1 commit into
devfrom
dictindex
May 14, 2026
Merged

Dictionary index words sort case insensitive#488
AthulyaMS merged 1 commit into
devfrom
dictindex

Conversation

@tejaswini143
Copy link
Copy Markdown

@tejaswini143 tejaswini143 commented May 14, 2026

User description


CodeAnt-AI Description

Sort dictionary index words without case differences

What Changed

  • Dictionary index entries are now ordered without treating uppercase and lowercase letters differently.
  • Words that only differ by case now appear in a consistent order in the index.

Impact

✅ Predictable dictionary browsing
✅ Consistent word order
✅ Easier lookup for mixed-case entries

💡 Usage Guide

Checking Your Pull Request

Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.

Talking to CodeAnt AI

Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:

@codeant-ai ask: Your question here

This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.

Example

@codeant-ai ask: Can you suggest a safer alternative to storing this secret?

Preserve Org Learnings with CodeAnt

You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:

@codeant-ai: Your feedback here

This helps CodeAnt AI learn and adapt to your team's coding style and standards.

Example

@codeant-ai: Do not flag unused imports.

Retrigger review

Ask CodeAnt AI to review the PR again, by typing:

@codeant-ai: review

Check Your Repository Health

To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.

@codeant-ai
Copy link
Copy Markdown

codeant-ai Bot commented May 14, 2026

CodeAnt AI is reviewing your PR.


Thanks for using CodeAnt! 🎉

We're free for open-source projects. if you're enjoying it, help us grow by sharing.

Share on X ·
Reddit ·
LinkedIn

@vercel
Copy link
Copy Markdown

vercel Bot commented May 14, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
vachan-admin-v2 Ready Ready Preview, Comment May 14, 2026 4:47am

Request Review

@codeant-ai codeant-ai Bot added the size:XS This PR changes 0-9 lines, ignoring generated files label May 14, 2026

# Sort all entries by word form before grouping
entries.sort(key=lambda x: x[1])
entries.sort(key=lambda x: x[1].lower())
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: Using lower() does not provide full Unicode case-insensitive ordering, so words with special case mappings (for example ß/SS or Turkish İ/i) can still be sorted incorrectly. If this endpoint is intended to be truly case-insensitive for dictionary data, normalize with casefold() (optionally with Unicode normalization) in the sort key. [logic error]

Severity Level: Major ⚠️
- ⚠️ /dictionary/{id}/index returns inconsistently ordered Unicode words.
- ⚠️ Dictionary browsing harder for languages with special casing.
Steps of Reproduction ✅
1. Ensure a DICTIONARY resource exists in `db_models.Resource` with `resource_id=1` and
`content_type='dictionary'`, which is validated in
`backend/app/crud/content_crud.py:22-35` within `get_dictionary_index`.

2. Insert rows into `db_models.Dictionary` for that resource where `word_forms` (queried
at `backend/app/crud/content_crud.py:38-41`) contains comma-separated Unicode words with
special case mappings, e.g. `"Straße,Strasse"` or `"İstanbul,istanbul"`.

3. Call the HTTP endpoint `GET /dictionary/1/index` defined in
`backend/app/router/content.py:15-39`, which invokes
`content_crud.get_dictionary_index(db_, resource_id=1)` at
`backend/app/router/content.py:31-34`.

4. Observe in the JSON response that within each `letter` group (built at
`backend/app/crud/content_crud.py:58-66`), the `words` list ordering is determined by
`entries.sort(key=lambda x: x[1].lower())` at `backend/app/crud/content_crud.py:314`;
Python `str.lower()` does not implement full Unicode case-folding (e.g., `ß` vs `ss`,
Turkish `İ` vs `i`), so ordering for such characters is not truly case-insensitive.
Changing the sort key to use `x[1].casefold()` (optionally combined with Unicode
normalization) would provide more correct case-insensitive ordering for dictionary entries
containing these characters.

Fix in Cursor | Fix in VSCode Claude

(Use Cmd/Ctrl + Click for best experience)

Prompt for AI Agent 🤖
This is a comment left during a code review.

**Path:** backend/app/crud/content_crud.py
**Line:** 314:314
**Comment:**
	*Logic Error: Using `lower()` does not provide full Unicode case-insensitive ordering, so words with special case mappings (for example `ß`/`SS` or Turkish `İ`/`i`) can still be sorted incorrectly. If this endpoint is intended to be truly case-insensitive for dictionary data, normalize with `casefold()` (optionally with Unicode normalization) in the sort key.

Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix
👍 | 👎

@codeant-ai
Copy link
Copy Markdown

codeant-ai Bot commented May 14, 2026

CodeAnt AI finished reviewing your PR.

@AthulyaMS AthulyaMS merged commit ff1b8be into dev May 14, 2026
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS This PR changes 0-9 lines, ignoring generated files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants