Structure #2
Merged
Structure #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Brookoko
reviewed
May 25, 2019
|
|
||
| import labs.introtoprogramming.lab5.geometry.Vector3; | ||
|
|
||
| public interface Camera { |
Owner
There was a problem hiding this comment.
Maybe make it an abstract class or a class that extends SceneObject? I think it is logical to treat camera as part of scene and manipulate it.
Collaborator
Author
There was a problem hiding this comment.
My initial assumption was that we will need objects on scene to be divided into three categories:
- regular objects, which are rendered
- camera (s)
- lights, which are accessed when computing shadows.
But since all of them share some common properties, it is a good idea indeed to make them extend the same class.
src/main/java/labs/introtoprogramming/lab5/scene/PointLight.java
Outdated
Show resolved
Hide resolved
Brookoko
approved these changes
May 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.