Skip to content

Conversation

@Ekatereana
Copy link
Collaborator

No description provided.

@Ekatereana Ekatereana changed the base branch from master to dev June 2, 2019 13:14
@codecov-io
Copy link

codecov-io commented Jun 2, 2019

Codecov Report

Merging #6 into dev will increase coverage by 1.6%.
The diff coverage is 86.66%.

Impacted file tree graph

@@             Coverage Diff             @@
##                dev       #6     +/-   ##
===========================================
+ Coverage     76.78%   78.39%   +1.6%     
- Complexity      223      261     +38     
===========================================
  Files            34       39      +5     
  Lines           741      861    +120     
  Branches         62       76     +14     
===========================================
+ Hits            569      675    +106     
- Misses          167      178     +11     
- Partials          5        8      +3
Impacted Files Coverage Δ Complexity Δ
.../introtoprogramming/lab5/object/Parser/Vertex.java 100% <100%> (ø) 6 <6> (?)
...introtoprogramming/lab5/object/Parser/Polygon.java 56.25% <56.25%> (ø) 5 <5> (?)
...otoprogramming/lab5/object/Parser/StringUtils.java 79.16% <79.16%> (ø) 5 <5> (?)
...oprogramming/lab5/object/Parser/PolygonObject.java 88.88% <88.88%> (ø) 4 <4> (?)
...toprogramming/lab5/object/Parser/ParseObjFile.java 95.08% <95.08%> (ø) 17 <17> (?)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b229ded...a272d22. Read the comment docs.

@Brookoko
Copy link
Owner

Brookoko commented Jun 4, 2019

PR#6 (Loading obj)

public static void main(String[] args) {
throw new NotImplementedException();
}
public static void main(String[] args) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file should not be changed

@Brookoko Brookoko merged commit 1a3b962 into dev Jun 11, 2019
@Brookoko Brookoko deleted the loadingOBJ branch June 11, 2019 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants