Fix controller/focusNode disposal causing rendering issues on parent setState

[Copilot]

The widget unconditionally disposed externally-provided controllers and focus nodes, violating Flutter ownership semantics. When parent widgets called setState() via onChange callbacks, disposed controllers would cause errors or incorrect state.

Changes

Core Fix

• Track resource ownership via _isControllerInternal and _isFocusNodeInternal flags
• Dispose only internally-created resources in dispose()

Tests

• External controller survives widget disposal and parent rebuilds
• Internal controller properly disposed
• External controller with onChange triggering setState works correctly

Example

• Added example_on_changed.dart demonstrating external controller with onChange callback

Before/After

// Before - always disposed, even if external
@override
void dispose() {
  _chipsAutocompleteController.dispose();
  _focusNode.dispose();
  super.dispose();
}

// After - conditional disposal based on ownership
@override
void dispose() {
  if (_isControllerInternal) {
    _chipsAutocompleteController.dispose();
  }
  if (_isFocusNodeInternal) {
    _focusNode.dispose();
  }
  super.dispose();
}

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

• canonical-bos01.cdn.snapcraftcontent.com
  • Triggering command: /usr/lib/snapd/snapd (dns block)
• https://storage.googleapis.com/flutter_infra_release/flutter/035316565ad77281a75305515e4682e6c4c6f7ca/dart-sdk-linux-x64.zip
  • Triggering command: curl --retry 3 --continue-at - --location --output /tmp/flutter/bin/cache/dart-sdk-linux-x64.zip REDACTED (http block)
• https://storage.googleapis.com/flutter_infra_release/releases/stable/linux/flutter_linux_3.24.5-stable.tar.xz
  • Triggering command: wget -q REDACTED -O flutter.tar.xz (http block)

If you need me to access, download, or install something from one of these locations, you can either:

• Configure Actions setup steps to set up my environment, which run before the firewall is enabled
• Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

Original prompt

---

This section details on the original issue you should resolve

<issue_title>Rendering goes weird if onChange called and if controller property is set</issue_title>
<issue_description>I've noticed a rendering problem with ChipsInputAutocomplete when...

1. The controller property is set; and
2. The onChange handler is set that causes a 'setState()' call

</issue_description>

Comments on the Issue (you are @copilot in this section)

@EmilyMoonstone Can you provide a code example?

• Fixes Rendering goes weird if onChange called and if controller property is set #2

---

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.