This repository was archived by the owner on Sep 27, 2023. It is now read-only.
Merged
Conversation
akiomik
commented
Dec 26, 2022
| } | ||
|
|
||
| static columnDescriptionKey(): string { | ||
| return `${this.prefix}-column-description` |
Contributor
Author
There was a problem hiding this comment.
column_description のスキーマは kpi の個数によって左右されないので、他のエンドポイントと同じくすべてのエンドポイントで共通
{
"kpi":{
"name":{"name_jp":"指標","unit":"なし"},
"value":{"name_jp":"値","unit":"指標による"}
}
}
akiomik
commented
Dec 26, 2022
| } | ||
|
|
||
| if (Array.isArray(value)) { | ||
| throw new TypeError(`An array property is currently not supported`) |
Contributor
Author
There was a problem hiding this comment.
配列 (kpi) へのアクセスはエラーにする
akiomik
commented
Dec 26, 2022
Comment on lines
+22
to
+24
| if (isObject(value) || Array.isArray(value)) { | ||
| throw new TypeError(`Can't access to a non-primitive type`) | ||
| } |
Contributor
Author
There was a problem hiding this comment.
指定された科目がオブジェクトや配列だった場合はエラー扱いにする (e.g. beta.years_2 や kpi など)
Contributor
There was a problem hiding this comment.
beta.years_2.beta みたいに指定する必要があるってことですね
t2h5
approved these changes
Dec 26, 2022
Comment on lines
+22
to
+24
| if (isObject(value) || Array.isArray(value)) { | ||
| throw new TypeError(`Can't access to a non-primitive type`) | ||
| } |
Contributor
There was a problem hiding this comment.
beta.years_2.beta みたいに指定する必要があるってことですね
akiomik
commented
Jan 4, 2023
| return path.split('.') | ||
| } | ||
|
|
||
| static listPathsOf(data: object, prefix: string | null = null): string[] { |
Contributor
Author
There was a problem hiding this comment.
パスのバリデーション用に作ったサポートしているプロパティを列挙するためのメソッドですが、値の取得時にも再帰する必要があり2回同じことをするのは無駄なので結局使ってません… (デバッグ用としては使えるかもですが)
shoe116
approved these changes
Jan 13, 2023
| } | ||
|
|
||
| private static joinPath(...components: string[]): string { | ||
| return components.join('.') |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
月次エンドポイント
GET /api/v3/monthlyをサポートするようにします。ネストしたオブジェクト (
beta) のアクセスはサポートしていますが、配列 (kpi) のサポートはしていません。