This repository was archived by the owner on Sep 27, 2023. It is now read-only.
Merged
Conversation
shoe116
approved these changes
Aug 25, 2021
| @@ -0,0 +1,166 @@ | |||
| import * as company from '~/__mocks__/fixtures/v3/company' | |||
Contributor
There was a problem hiding this comment.
ここ、好みもあるけど test 用の api token 使って実際叩くテスト書くのもありっちゃありな気がする。
レスポンスと細かい部分というよりは、http status だけチェックするみたいな
Contributor
Author
There was a problem hiding this comment.
個人的にはあんまり好きじゃないです。「外部サービスに何を期待しているか」が曖昧になるし、外部に依存してると意図してない形でテストが落ちたりするので、単体テスト (googleのいうsmall test) はモックを使って書いた方がいいと思ってます。単体テストとは別にモックせずにテストするテストケースがあるのはいいと思うけど、developのCIとかのレベルで頻繁に回すようなものではないかなとも思うので実行タイミングが難しい…
Contributor
There was a problem hiding this comment.
了解 確かにここにはないほうが自然だよね。
CI がいい感じに別の stage でやってくれるとかっこいい感じ
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.