This repository was archived by the owner on Sep 27, 2023. It is now read-only.
Merged
Conversation
akiomik
commented
Nov 3, 2021
Comment on lines
+33
to
+35
| throw new Error( | ||
| `<<引数が不正な形式です。param1: ${param1} (${typeof param1}), param2: ${param2} (${typeof param2})>>` | ||
| ) |
Contributor
Author
There was a problem hiding this comment.
将来的にはここで bcodeV3 を呼び出します。
shoe116
reviewed
Nov 3, 2021
Comment on lines
+26
to
+29
| param1: string | number | Date, | ||
| param2: string | number, | ||
| param3: string | boolean = false, | ||
| param4: string | boolean = false, |
| } else if (code === 429) { | ||
| throw new Error('<<APIの実行回数が上限に達しました>>') | ||
| } else if (Math.floor(code / 100) === 4) { | ||
| throw new Error('<<無効なリクエストです>>') |
Contributor
There was a problem hiding this comment.
これ、問い合わせ対応を考えるとちょっと行儀悪くてもメッセージ出力したいな
akiomik
force-pushed
the
add-bcode-wrapper-function
branch
from
baec8f4 to
4153c8b
Compare
shoe116
approved these changes
Nov 3, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.