This repository was archived by the owner on Sep 27, 2023. It is now read-only.
Merged
Conversation
akiomik
commented
Nov 5, 2021
| import { default as quarter } from '~/__mocks__/fixtures/v3/quarter.js' | ||
|
|
||
| export class BuffettCodeApiClientV2 { | ||
| export class BuffettCodeApiClientV3 { |
shoe116
reviewed
Nov 5, 2021
| import { default as quarter } from '~/__mocks__/fixtures/v3/quarter.js' | ||
|
|
||
| export class BuffettCodeApiClientV2 { | ||
| export class BuffettCodeApiClientV3 { |
| @@ -0,0 +1,23 @@ | |||
| import { DateParam } from '~/fiscal-periods/date-param' | |||
|
|
|||
| export class DailyCache { | |||
Contributor
There was a problem hiding this comment.
ここ、resource 毎にcache class 分ける今みたいな実装と、 end_point + params で cache の key を作って cache としては1つにするか 2つやり方がありそう。
excel の方は後者の作戦だね、リソース管理がめんどくさいから。
shoe116
approved these changes
Nov 5, 2021
Contributor
shoe116
left a comment
shoe116
left a comment
There was a problem hiding this comment.
大丈夫そう、 LY, LQ を渡すときの cache がちょっとどうするか考えどこだけど、まぁこれでいいか。
cacheを使うっていうのそういうことだな、「最新かどうかは保証しないけど、早くレスポンスを返す」
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.