This repository was archived by the owner on Sep 27, 2023. It is now read-only.
Merged
Conversation
shoe116
reviewed
Nov 7, 2021
Contributor
shoe116
left a comment
shoe116
left a comment
There was a problem hiding this comment.
日付のParseのしかただけちょっと気になりました
Comment on lines
+27
to
+30
| str = str.toLowerCase() | ||
| if (str == 'latest') { | ||
| return new DateParam(str) | ||
| } |
Comment on lines
+32
to
+35
| const matches = str.match(/^(\d{4})-(\d{2})-(\d{2})$/) | ||
| if (matches == undefined) { | ||
| throw new ParseError(`Invalid date format: ${str}`) | ||
| } |
Contributor
There was a problem hiding this comment.
あー これ自前でvalidation する？直接 Date.parse して例外処理っていうのもありだと思うけど。
実行環境毎に Date.parse の挙動が違うとかそういうのを想定してる？
Contributor
Author
There was a problem hiding this comment.
jsの new Date(str) はいろんなフォーマットでパースできてしまうので、将来的に別のフォーマットを追加した際に挙動が変わってしまう懸念があり、なるべくフォーマットは固定化した方がいいと思っています
(例えば年次ごとの値を取得するエンドポイントが追加されたとき、 BCODE(ticker, 2020, propName) みたいな関数呼び出しの口になると、 new Date('2020') のパースと = 2020-01-01 と衝突してしまう)
shoe116
approved these changes
Nov 8, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.