This repository was archived by the owner on Sep 27, 2023. It is now read-only.
Merged
Conversation
akiomik
commented
Nov 13, 2021
|
|
||
| test('(uncached)', () => { | ||
| expect(QuarterCache.get(ticker, period.toYearQuarter())).toBeNull() | ||
| expect(QuarterCache.getData(ticker, period.toYearQuarter())).toBeNull() |
Contributor
Author
There was a problem hiding this comment.
v2の既存のコードは、キャッシュの取得時は QuarterCache.get だったのを QuarterCache.getData に、設定時は QuarterCache.put だったのを QuarterCache.putData に変更すれば同じ挙動で動くようになります
akiomik
commented
Nov 13, 2021
| return `${this.prefix}-column-description` | ||
| } | ||
|
|
||
| static getData(ticker: string, yearQuarter: YearQuarter): object | null { |
Contributor
Author
There was a problem hiding this comment.
キャッシュの取得ロジックはメソッド名が変わっただけでコード自体の変更はないため、v2では変更後の名前に修正すれば挙動は変わりません。
akiomik
commented
Nov 13, 2021
| return new Quarter(cachedData, cachedColumnDescription) | ||
| } | ||
|
|
||
| static putData( |
shoe116
reviewed
Nov 14, 2021
Contributor
shoe116
left a comment
shoe116
left a comment
There was a problem hiding this comment.
- もともとあった
getputの挙動を変更 getDataputDataは変更前のgetputと同じ挙動で、互換はそれでとる
ってことだよね。LGTM です
shoe116
approved these changes
Nov 14, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.