Skip to content
This repository was archived by the owner on Sep 27, 2023. It is now read-only.

Use v3 endpoint in csv exporter#61

Merged
akiomik merged 2 commits intodevelopmentfrom
use-v3-endpoint-in-csv-exporter
Dec 10, 2021
Merged

Use v3 endpoint in csv exporter#61
akiomik merged 2 commits intodevelopmentfrom
use-v3-endpoint-in-csv-exporter

Conversation

@akiomik
Copy link
Copy Markdown
Contributor

@akiomik akiomik commented Dec 8, 2021

No description provided.

@akiomik akiomik requested a review from shoe116 December 8, 2021 02:55
@akiomik akiomik self-assigned this Dec 8, 2021
Copy link
Copy Markdown
Contributor

@shoe116 shoe116 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

import { OndemandApiPeriodRange } from '~/api/ondemand-api-period-range'
import { CachingBuffettCodeApiClientV2 } from '~/api/v2/caching-client'
import { CachingQuarterProperty } from '~/api/v2/caching-quarter-property'
import { CachingBuffettCodeApiClientV3 } from '~/api/v3/caching-client'
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment on lines +67 to +68
const labelA = a.period().toString()
const labelB = b.period().toString()
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment on lines +83 to +85
const values = quarter.propertyNames().map(name => {
const data = sortedQuarters.map(quarter => quarter.data[name])
return [name, quarter.labelOf(name), quarter.unitOf(name), ...data]
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

なるほど

@akiomik akiomik merged commit 5574bcc into development Dec 10, 2021
@akiomik akiomik deleted the use-v3-endpoint-in-csv-exporter branch December 10, 2021 01:33
@akiomik akiomik mentioned this pull request Dec 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants