Skip to content
This repository was archived by the owner on Sep 27, 2023. It is now read-only.

Improve DateParam#82

Merged
shoe116 merged 1 commit intodevelopmentfrom
improve-date-param
Jan 21, 2022
Merged

Improve DateParam#82
shoe116 merged 1 commit intodevelopmentfrom
improve-date-param

Conversation

@akiomik
Copy link
Copy Markdown
Contributor

@akiomik akiomik commented Jan 19, 2022

No description provided.

@akiomik akiomik requested a review from shoe116 January 19, 2022 09:47
@akiomik akiomik self-assigned this Jan 19, 2022
Copy link
Copy Markdown
Contributor

@shoe116 shoe116 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm です

Comment on lines +10 to +11
public isLatest(): this is DateParamLatest {
return false
Copy link
Copy Markdown
Contributor

@shoe116 shoe116 Jan 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

これ、もうすこしシンプルに書く書き方がある気がするな・・・

@shoe116 shoe116 merged commit 2a05cea into development Jan 21, 2022
@shoe116 shoe116 deleted the improve-date-param branch January 21, 2022 01:50
@akiomik akiomik mentioned this pull request Jun 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants