This repository was archived by the owner on Sep 27, 2023. It is now read-only.
Merged
Conversation
akiomik
commented
Jun 15, 2022
Comment on lines
-18
to
+24
| company(): object { | ||
| company(ticker: string): object { | ||
| if (ticker !== '2371') { | ||
| const res = new HTTPResnpose() | ||
| throw new HttpError('/v3/company', res) | ||
| } |
Contributor
Author
There was a problem hiding this comment.
テスト用にfixtureとして用意しているデータが2371のものなので、2371以外のリクエストが来た際には404扱いのエラーを返すようにする
akiomik
commented
Jun 15, 2022
Comment on lines
-13
to
-15
| static putAll(companies: object): void { | ||
| Object.keys(companies).forEach(ticker => CompanyCache.put(ticker, companies[ticker][0])) | ||
| } |
Contributor
Author
There was a problem hiding this comment.
完全にv2用のI/Fで使いにくい && v3では使わないので削除します。
akiomik
commented
Jun 15, 2022
Comment on lines
-20
to
-22
| public isSupportedTicker(): boolean { | ||
| return !!this.company | ||
| } |
Contributor
Author
There was a problem hiding this comment.
v2クライアントでは対象trickerがないに client.company(ticker) がnullを返す可能性があった (HTTPリクエストは成功しているがレスポンス中に当該tickerがない場合) のですが、v3クライアントは対象trickerがないときにはnullではなく例外を出すようになっているため、 isSupportedTicker() でデータが取れたかどうかの確認を行う必要はなくなりました。
akiomik
commented
Jun 15, 2022
Comment on lines
+44
to
+46
| const message = | ||
| 'BCODE(ticker, FY, FQ, name)の形式は現在サポートしていません。BCODE(ticker, FYFQ, name)をご利用ください。' | ||
| throw new Error(message) |
Contributor
Author
There was a problem hiding this comment.
v2形式でアクセスされた場合のエラー文言
shoe116
approved these changes
Jun 15, 2022
2 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BCODE関数のv2形式での実装を削除し、v2スタイルのBCODE関数で実行された際にはエラーを出すようにします。また、v2に依存している
BCODE_LABEL関数およびBCODE_UNIT関数を廃止します。これらはすでにドキュメントからも削除されており、usageでも「近日廃止予定」としていたものです。